how can i compare three strings?

Question

3.00/5 (2 votes)

See more:

hi,!
I want to compare three strings, so far I have tried with compareTo, but it seems it only works with 2 strings.
I hope someone can help me out!
thanks.

Posted 2-Mar-13 9:19am

appleduardo

Add a Solution

4 solutions

Solution 2

C++

BOOL 3StringsIdentical(char *s1,char *s2,char *s3)
{
     if(strcmp(s1,s2)==0 && strcmp(s1,s3)==0)
          return TRUE;
     else
          return FALSE;
}

Then just call:

C++

BOOL TheyAreIdentical=3StringsIdentical("abc","abc","abc");

or

C++

BOOL TheyAreIdentical=3StringsIdentical("abc","xxx","abc");

Posted 2-Mar-13 11:13am

Michael Haephrati

Comments

Sergey Alexandrovich Kryukov 2-Mar-13 22:40pm

I voted one, because it shows some fundamental luck of understanding of very basic programming.

if (something)
   return true;
else
   return false;

is strictly equivalent to

return something;

Besides, your code is not valid as C# code, but this is less important.

Please think about it: if you give an advice, you should be able to write reasonably good code.

Sorry.
—SA

Per Söderlund 3-Mar-13 8:54am

I agree, this is bad in many ways.

Sergey Alexandrovich Kryukov 3-Mar-13 12:33pm

The real problem is that Michael tries to defend himself. Please see the comments below.
—SA

Michael Haephrati 3-Mar-13 3:06am

I disagree. First, my solution do the job and second, that's the beauty of C / C++ : you can write the same logic in many forms of code. At the same time I could have suggested:
return(!strcmp(s1,s2) && !strcmp(s1,s3));
One line of code.... Very impressive! BUT I am trying to help someone understand.... So, NO. I wouldn't want to use 'return something' as you suggest, but stay with my answer, and that is for instructional purposes. By the way I have been coding for 25 years, and a member here since 2003, so I don't appreciate your implications about my coding skills...

Per Söderlund 3-Mar-13 8:58am

You are trying to make someone understand C/C++ in a C# question.

Michael Haephrati 3-Mar-13 9:00am

You got a point! I wasn't aware that the solution must be in c#, nevertheless, I hope I helped him.

Sergey Alexandrovich Kryukov 3-Mar-13 12:31pm

You help can be more damaging than helping. When we develop software, I consider fragment as the one you show as a big harm and demand re-writing. People writing such code are not taken as reliable workers.

Answering questions is a great responsibility. Your code cause confusion and promoted misconceptions. It's harmful.

You self-defense along goes against the very basic professional principle. When someone point out my mistake, I fix myself and say "thank you". Think what are you doing.
—SA

Michael Haephrati 3-Mar-13 12:37pm

Sergey, I don't appreciate the fact that you give a "1" rating, generally speaking (you should need a very good reason), and in my case. You are definitely right about coding standards when it comes to articles, where people download code samples. In such case, fragmentation is an important issue. In the scope of this question, I disagree, but I am listening to others, and listen to you. I might be wrong. All you have to do is suggest. So if you expect people to thank you, please don't hurry to downvote them...

Michael Haephrati 3-Mar-13 12:46pm

In any case, Solution 4 seems to be the best, so issue is solved as far as I am concerned. Solution 4 provides a solution for any number of strings to compare which is great and is better than any other solution, including my own...

Solution 5

here is y solution. scales to any number of strings.
probably performs a bit better than the other alternatives:

C#

bool AreEqualStrings(params string[] Strings)
{
    for (int i = 1; i < Strings.Length; i++)
    {
        if (Strings[i].Length != Strings[0].Length)
            return false;
    }
    for (int i = 0; i < Strings[0].Length; i++)
    {
        for (int j = 1; i < Strings.Length; i++)
        {
            if (Strings[j][i] != Strings[0][i])
                return false;
        }
    }
    return true;
}

Posted 4-Mar-13 7:45am

Yossi Yaari

Solution 3

C#

class Program
    {
        static void Main(string[] args)
        {
            string a1 = "aaaaa";
            string a2 = "aaaaa";
            string a3 = "aaaaa";
            string.com
            bool b = CompMethod(a1, a2, a3);

            Console.WriteLine(b.ToString());

        }
        public static bool CompMethod(string a1, string a2, string a3)
        {
            return Convert.ToBoolean(a1 == a2 && a1 == a3);
        }
    }

Source : http://forums.asp.net/t/1687989.aspx/1[^]

Posted 2-Mar-13 17:36pm

Krunal Rohit

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Per Söderlund · Accepted Answer · 2013-03-03T03:12:00

Solution 4

If you want a bool saying that your strings are equal.

C#

bool IsEqualStrings(params string[] Strings)
        {
            for (int i = 1; i < Strings.Length; i++)
            {
                if (Strings[i] != Strings[0])
                    return false;
            }
            return true;
        }

Now you can use as many strings as you like.
Like this

C#

bool Equalstrings = IsEqualStrings("MyString","MyString","MyString","MyString");

Posted 3-Mar-13 3:12am

Per Söderlund

Updated 3-Mar-13 3:14am

v2

Comments

Thomas Daniels 3-Mar-13 9:22am

+5!

Per Söderlund 3-Mar-13 9:24am

Thanks

Jibesh 4-Mar-13 18:32pm

+5