BinaryWriter in C# adding junk data

Question

0.00/5 (No votes)

See more:

Hi,
I am using BinaryWriter in C#.
It adds junk characters at the end of data.
I have also close and flush the binarywriter.

Here is code snippet:

C#

 using (FileStream objFileStream = new FileStream(sFilePath, fMode))
{
      using (BinaryWriter objStreamWriter = new BinaryWriter(objFileStream))
          {
                        // Write Char String Data to the OCE file
                        //objStreamWriter.Write(sDataToWrite.ToCharArray(), 0, sDataToWrite.Length);
                        objStreamWriter.Write(sDataToWrite.ToCharArray());                        objStreamWriter.Flush();
                        objStreamWriter.Close();
                        
                    }
                    objFileStream.Close();
                }

Please suggest the solution.

Posted 14-Jan-13 2:37am

Vipin_Arora

Add a Solution

Comments

Alan N 14-Jan-13 9:04am

Do you have an example of what you mean by "junk" and the input string that produced it. It would also be helpful to see the intermediate character array.

Vipin_Arora 14-Jan-13 10:10am

junk characters are like:

6A¦''?LP¤¹¾”¬Ì»†Oæl(#©¤-–<‘ô§ÆÛ—švpÜu¥ãž”¸”‡¤4î=)1íGAŠSÖšN:ÎÏZöàR~'ð¥Æ{ÄÑÓ°¥öüai‡ƒÎsFqG^1Iß(è}(è;P>”¤sŠFéïô£¶I£4ÞE;©ëùRtíH9Ï ~§ëIüx'ŠQŒ›ëJõ¤ÉÍ)¸¤$t=¨'èsA Û4‡Ž£ó§/AÁçÞ—qÏåM¥Ï°üé¹çÿ

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2013-01-14T03:31:00

Solution 1

When I try your code here:

C#

string sFilePath = @"D:\Temp\BBbinwriter.hex";
FileMode fMode = FileMode.Create;
string sDataToWrite = File.ReadAllText(@"D:\Temp\101.txt");
using (FileStream objFileStream = new FileStream(sFilePath, fMode))
    {
    using (BinaryWriter objStreamWriter = new BinaryWriter(objFileStream))
        {
        // Write Char String Data to the OCE file
        //objStreamWriter.Write(sDataToWrite.ToCharArray(), 0, sDataToWrite.Length);
        objStreamWriter.Write(sDataToWrite.ToCharArray()); objStreamWriter.Flush();
        objStreamWriter.Close();

        }
    objFileStream.Close();
    }

I get two identical files - the same length, the same data. What am I doing that you aren't, or you doing that I'm not?
I can only assume that it is a data problem, and your sDataToWrite does not contain what you think it does...:laugh:

Posted 14-Jan-13 3:31am

OriginalGriff

Comments

Vipin_Arora 15-Jan-13 23:17pm

But it is the case only on one machine (64-bit win2008 server), on other machines (64-bit win2008 server), it is working fine

OriginalGriff 16-Jan-13 2:03am

Exactly what mode value are you using?

OriginalGriff 16-Jan-13 3:27am

Do I assume from the deleted comment that you found it wasn't? :laugh:

Vipin_Arora 16-Jan-13 4:03am

I m sorry, previously I wrote create mode mistakenly. thats why I delete it. I cross check the same and it is actually:Append

Vipin_Arora 16-Jan-13 4:00am

Its not: FileMode.Create.
It is: FileMode.Append

OriginalGriff 16-Jan-13 4:17am

There is your problem!
When you use Append the existing content of the file is preserved - so when you write your data, if what you write is shorted than the existing file then the data that was there previously will be left behind at the end of the "new" file.
I would suggest that you might want to rename the original to a backup name (deleting any old copy perhaps) and then use Create instead to ensure you get a clean file.

Vipin_Arora 16-Jan-13 23:55pm

The new data is appended at the end of the file, not overwriting the existing content.