Single Command Object for execute multiple SQL Query

Question

0.00/5 (No votes)

See more:

I have a method where i am using different Command objects to execute different SQL statements. Currently i am using the following code block-

C#

private static Voucher CreateEntity(Voucher voucher)
    {
        OleDbConnection Connection = new OleDbConnection(voucher.ConnectionString);

        OleDbCommand cmdInsert1 = new OleDbCommand("INSERT INTO table1(Field1, Field2,..) VALUES(Value1,Value2,..)", Connection);

        OleDbCommand cmdInsert2 = new OleDbCommand("INSERT INTO table2(Field1, Field2,..) VALUES(Value1,Value2,..)", Connection);

        OleDbCommand cmdLastId = new OleDbCommand("SELECT MAX(Field1) AS LastId FROM Table1", Connection);

        OleDbTransaction transaction = null;

        try
        {
            Connection.Open();
            transaction = Connection.BeginTransaction();

            cmdInsert1.Transaction = transaction;
            cmdInsert2.Transaction = transaction;
            cmdLastId.Transaction = transaction;

            cmdInsert1.ExecuteNonQuery();
            cmdInsert2.ExecuteNonQuery();

            object LastId = cmdLastId.ExecuteScalar();

            transaction.Commit();
            Connection.Close();
            //voucher.MarkOld();
            //return voucher;
        }
        catch (Exception ex)
        {
            if (transaction != null)
            {
                transaction.Rollback();
            }
            throw ex;
        }
    }

My question is, can i use single Command object here without declaring multiple Command objects? Specially, when using Transaction object?

For example, cmdInsert.CommandText=sqlString1, cmdInsert.CommandText=sqlString2,.. If I do so, is there any performance problem?

Regards
Saumitra Kumar Paul

Posted 21-Nov-12 20:26pm

Saumitra Kumar Paul

Updated 21-Nov-12 20:29pm

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Mohd. Mukhtar · Accepted Answer · 2012-11-21T20:39:00

Hi Saumitra,

You can execute multiple query by separating with semicolon ";".

Update your code as below.

C#

private static Voucher CreateEntity(Voucher voucher)
    {
        OleDbConnection Connection = new OleDbConnection(voucher.ConnectionString);
        string query = "INSERT INTO table1(Field1, Field2,..) VALUES(Value1,Value2,..);INSERT INTO table2(Field1, Field2,..) VALUES(Value1,Value2,..);SELECT MAX(Field1) AS LastId FROM Table1;";        
        OleDbCommand cmd = new OleDbCommand(query, Connection);
 
        OleDbTransaction transaction = null;
 
        try
        {
            Connection.Open();
            transaction = Connection.BeginTransaction();            
            cmd.Transaction = transaction;             
            object LastId = cmd.ExecuteScalar(); 
            transaction.Commit();
            Connection.Close();
            //voucher.MarkOld();
            //return voucher;
        }
        catch (Exception ex)
        {
            if (transaction != null)
            {
                transaction.Rollback();
            }
            throw ex;
        }
    }

Hope thi will help you.