is the update query syntax correct?

Question

5.00/5 (1 vote)

See more:

i am newbie so dont angry on my question also i am weak in english
i have edited my query which was before an insert query and i have edited to become a uodate query but the last portion is not correct as data is updated successfull but i want to show a messagebox if updation was success then it will be suceess and if updation was failed then a message box will show which will contain message of error.
here is my crazy code

SqlConnection conn = new SqlConnection();
          conn.ConnectionString = @"Data Source=.\SQLEXPRESS;AttachDbFilename=E:\project\Projects\labelnameinsecondformtry\labelnameinsecondformtry\Database1.mdf;Integrated Security=True;User Instance=True";
          try
          {
              conn.Open();
          }
          catch (Exception)
          {
              MessageBox.Show("Error with the databse connection");
          }
          string qry2 = "UPDATE Table1 SET Password =@Password WHERE UserName=@username";
          SqlCommand com = new SqlCommand(qry2, conn);
          com.Parameters.AddWithValue("@username", this.textBox1.Text);
          com.Parameters.AddWithValue("@Password", this.textBox2.Text);
          SqlDataReader dr = com.ExecuteReader();
          while (dr.Read())
          {
              if (dr.HasRows == true)
              {
                  MessageBox.Show("updated sucesfull");
              }
          }
          if (dr.HasRows == false)
          {
              MessageBox.Show("updation failed ");
          }

Posted 15-Nov-12 0:26am

shaikh-adil

Add a Solution

2 solutions

Solution 1

Try the following:

C#

int x = cmd.ExecuteNonQuery();
if (x == -2)
{
   //fail and show the message
}

please check the following for example:

http://stackoverflow.com/questions/2963703/how-to-know-whether-a-sql-update-statement-executed-successfully-or-failed[^]

Posted 15-Nov-12 0:43am

Om Prakash Pant

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Mohd. Mukhtar · Accepted Answer · 2012-11-15T00:45:00

Hi Adil,

Please update your code as below.

C#

SqlConnection conn = new SqlConnection();
            conn.ConnectionString = @"Data Source = .\SQLEXPRESS;AttachDbFilename=E:\project\Projects\labelnameinsecondformtry\labelnameinsecondformtry\Database1.mdf;Integrated Security=True;User Instance=True";
       try
       {
            conn.Open();
            string qry2 = "UPDATE Table1 SET Password =@Password WHERE UserName=@username";
            SqlCommand com = new SqlCommand(qry2, conn);
            com.Parameters.AddWithValue("@username", this.textBox1.Text);
            com.Parameters.AddWithValue("@Password", this.textBox2.Text);
            int result = com.ExecuteNonQuery();
            if (result > 0)
            {
                MessageBox.Show("updated sucesfull");
            }
            else
                 MessageBox.Show("updated failed");
         }
         catch (Exception)
         {
                MessageBox.Show("Error with the databse connection");
         }

Hope this will help you.