Save and Update using one button

Question

1.00/5 (1 vote)

See more:

C#

namespace RERMS.HR
{
    public partial class LateAttendance : System.Web.UI.Page
    {
        Button btnSave;
        protected void Page_Load(object sender, EventArgs e)
        {
            (this.Master as SiteMaster).SaveClicked += new EventHandler(Save_Click);
            (this.Master as SiteMaster).DeleteClicked += new EventHandler(Delete_Click);
            if (!IsPostBack)
            {  LoadGridView();
            }
            if (Request.QueryString["LateAttendanceApprovalID"] == null || Request.QueryString["LateAttendanceApprovalID"].ToString() == "")
            {}
            else if (Request.QueryString["LateAttendanceApprovalID"].ToString() != null || Request.QueryString["LateAttendanceApprovalID"].ToString() != "")
            {
                LateAttendanceApprovalForEdit();
            }
 }
 private void LateAttendanceApprovalForEdit()
        {
            btnSave = this.Master.FindControl("btnSave") as Button;
            if (btnSave.Text != "Update")
            {
                var LateRepository = new LateAttendanceRepository();
                var LateApprovalDto = new LateAttendanceApprovalDto();
                LateApprovalDto.LateAttendanceApprovalID = Convert.ToString(Request.QueryString["LateAttendanceApprovalID"]);
                LateApprovalDto = LateRepository.LoadLateAttendanceForEdit(LateApprovalDto).AttendanceApproval;
                txtApproveDate.Text = Convert.ToString(LateApprovalDto.ApprovalDate);
                txtArrivingTime.Text = Convert.ToString(LateApprovalDto.ArrivingTime);
                txtRemarks.Text = Convert.ToString(LateApprovalDto.Remarks);
                ddlEmployee.SelectedValue = LateApprovalDto.Employee.EmployeeID;
                btnSave.Text = "Update";
            }
        }

        private void LoadGridView()
        {
            LateAttendanceRepository LateRepository = new LateAttendanceRepository();
            LateRepository.LoadGridView(grdLateAttendance);
          
        }
void Save_Click(object sender, EventArgs e)
        {
            if (btnSave.Text == "Update")
            {
                UpdateLateAttendance();
            }
            else if (btnSave.Text == "Save")
            {
                SaveLateAttendance();
            }
             LoadGridView();
        }
        private void SaveLateAttendance()
        {
            var LateRepository = new LateAttendanceRepository();
            var LateApprovalDto = new LateAttendanceApprovalDto();
            var Company = new CompanyDto();
            var employeeDto = new EmployeeDto();
            var departmentDto = new DepartmentDto();
            LateApprovalDto.LateAttendanceApprovalID = "LT-10";
            LateApprovalDto.ApprovalDate = Convert.ToDateTime(txtApproveDate.Text);
            LateApprovalDto.ArrivingTime = Convert.ToDateTime(txtArrivingTime.Text); LateRepository.AddLateAttendance(LateApprovalDto);
        }
When i insert data then create this exception"Object reference not set to an instance of an object." Error line 81. because btnSave cant find value Update or Save.But i cant understand that.Sorry my poor English.
Source Error:

Line 79:         void Save_Click(object sender, EventArgs e)
Line 80:         {
Line 81:             if (btnSave.Text == "Update")
Line 82:             {
Line 83:                 UpdateAttendance();

pls solute the problem

Posted 22-Oct-12 1:07am

Nilsomudra

Updated 22-Oct-12 17:30pm

v3

Add a Solution

Comments

I.explore.code 22-Oct-12 7:12am

Put a break point on the button click event and debug it using "F10" key on your keyboard!

Ambesha 22-Oct-12 7:19am

:)

govardhan4u 22-Oct-12 8:22am

update aspx page code too.

senguptaamlan 22-Oct-12 9:00am

Oh god...I'm unable to locate the question.....please, be specific while posting a question....here the guys are not working for Ur project or resolving your business logic.

joshrduncan2012 22-Oct-12 11:14am

What is your question here? We can't infer as to what you are referring to with just the code that you have supplied?

Sergey Alexandrovich Kryukov 22-Oct-12 12:18pm

Why Save and Update is the same button?!
And this is not the question.
Besides, it's not clear where the exception is thrown. Indicate the line of code.
--SA

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2012-10-22T06:30:00

Please see all the comments to the questions — they all are reasonable.

First of all, using the same button for those two different actions is a bad idea even if you never use them at the same time. The user should always see the visual clue on "what else is there". So, much better UI style would be having two separate buttons, but each should be enabled or disabled depending on current state; and this enable status should be updated each time the state is changed.

Now, look what you are doing! The use of immediate constants like "Save" and "Update" it totally unacceptable. Worse, you use such constant values in different parts of the code. How can you ever support it? This is nearly impossible. Imagine you want to modify one of the button names. Are you going to change it in several places and remember how they are related? And your check like if (btnSave.Text == "Update") will screw up things very well. This is not even bad coding — this is not programming at all. Rewrite the code completely. Such constants belong to resources; at least, make them explicit constants, but never ever hard-code them.

And finally, you did not show where the exception with the message "Object reference not set to an instance of an object" is thrown, but this is one of the very easiest cases to detect and fix. It simply means that some member/variable of some reference type is dereferenced by using and of its instance (non-static) members, which requires this member/variable to be non-null, but in fact it appears to be null. Simply execute it under debugger, it will stop the execution where the exception is thrown. Put a break point on that line, restart the application and come to this point again. Evaluate all references involved in next line and see which one is null while it needs to be not null. After you figure this out, fix the code: wither make sure the member/variable is properly initialized to a non-null reference, or check it for null and, in case of null, do something else.

Case closed.

—SA

Nilsomudra · Accepted Answer · 2012-10-22T21:19:00

C#

void Save_Click(object sender, EventArgs e)
        {
            btnSave = this.Master.FindControl("btnSave") as Button;
            if (btnSave.Text == "Update")
            {
                UpdateLateAttendance();
            }
            else if (btnSave.Text == "Save")
            {
                SaveLateAttendance();
            }
             LoadGridView();
        }

Save and Update using one button

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0