am trying to delete listbox selected item it is not getting

Question

0.00/5 (No votes)

See more:

this is my code

----------------------

C#

private void btnDelete_Click(object sender, EventArgs e)
       {
           SQLiteConnection connection = new SQLiteConnection(connectionString);

             delcmd.CommandText = "DELETE FROM Table WHERE ID='" + Listbox1.ToString() +"'";
               connection.Open();
               delcmd.Connection = connection;
               delcmd.ExecuteNonQuery();
               connection.Close();
               bindListbox1();
               Listbox1.Update();
               MessageBox.Show("Row Deleted");

                  }

Posted 17-Jul-12 2:51am

rockpune

Updated 17-Jul-12 2:52am

Sebastian T Xavier

v2

Add a Solution

Comments

Sebastian T Xavier 17-Jul-12 8:53am

Whats the error you are getting....

rockpune 17-Jul-12 8:57am

no error but no deleting any item

Sebastian T Xavier 17-Jul-12 9:11am

Not getting deleted from database or from listbox?

rockpune 17-Jul-12 10:26am

both delete from database and listbox

StianSandberg 17-Jul-12 9:19am

The generated sql from your code will be:
"DELETE FROM Table WHERE ID = 'System.Windows.Forms.ListBox Items.Count:21,Items[0]:Div3'" You have to read the SelectedItem property of your listbox. Listbox1.SelectedValue

Kenneth Haugland 17-Jul-12 10:55am

If you provide us with the class that you use to populate the listbox with we can give you the exact code that would fix your issue.

j.yanga 18-Jul-12 9:47am

If you wanted the string selected in the listbox, use Listbox1.SelectedItem.ToString(). Or, if you wanted the ID or index of the selected item in listbox, use Listbox1.SelectedIndex().

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

StianSandberg · Answer 1 · 2012-07-17T03:00:00

Solution 1

Listbox1.ToString() wont give you what you need..

try with Listbox1.SelectedValue

C#

private void btnDelete_Click(object sender, EventArgs e)
{
   SQLiteConnection connection = new SQLiteConnection(connectionString); 
   SQLiteCommand delcmd = new SQLiteCommand(); // did you miss this?
   delcmd.CommandText = "DELETE FROM Table WHERE ID='" + Listbox1.SelectedValue +"'";
   connection.Open();
   delcmd.Connection = connection;
   delcmd.ExecuteNonQuery();
   connection.Close();
   bindListbox1();
   Listbox1.Update();
   MessageBox.Show("Row Deleted");

}

Posted 17-Jul-12 3:00am

StianSandberg

Updated 17-Jul-12 3:05am

v3

Comments

rockpune 17-Jul-12 9:03am

ya i tryed still not getting

StianSandberg 17-Jul-12 9:04am

is it a asp.net web application or a windows form?

rockpune 17-Jul-12 9:04am

windowsform C#

StianSandberg 17-Jul-12 9:06am

ok. Try to MessageBox.Show(Listbox1.ToString()) to see if you actually have the correct value from your dropdown.. I don't think Listbox1.ToString() will give you what you are looking for..

StianSandberg 17-Jul-12 9:12am

Then you can try this:

private void btnDelete_Click(object sender, EventArgs e)
{
var selectedValue = Convert.ToString(Listbox1.SelectedValue);
MessageBox.Show("Selected value is" + selectedValue);
}

rockpune 17-Jul-12 9:12am

in messagebox it showing (System.Windows.Forms.ListBox Items.Count:21,Items[0]:Div3) like this

StianSandberg 17-Jul-12 9:14am

exactly. That is because you cant do a .ToString() on an object like that. It will give you a string representing the object. Not the objects property values.

rockpune 17-Jul-12 9:19am

in messagebox it shows system.data.datarow

StianSandberg 17-Jul-12 9:21am

You should read about listbox: http://msdn.microsoft.com/en-us/library/system.windows.forms.listcontrol.selectedvalue.aspx

rockpune 17-Jul-12 9:22am

ok thanx for your replay

Richard MacCutchan · Answer 2 · 2012-07-17T03:01:00

Solution 2

C#

delcmd.CommandText = "DELETE FROM Table WHERE ID='" + Listbox1.ToString() +"'";

Use proper parameterised commands in SQL. Concatenating strings in this way can expose you to SQL injection attacks and the loss or corruption of your database.
Why are you trying to convert the entire listbox[^] to a string and pass it into your command?

[edit]
Fixed bad link.
[/edit]

Posted 17-Jul-12 3:01am

Richard MacCutchan

Updated 17-Jul-12 4:43am

v2

Comments

rockpune 17-Jul-12 9:07am

Server not found your link

Richard MacCutchan 17-Jul-12 10:43am

Fixed. More importantly, do you see what is wrong with your code?

Richard MacCutchan 17-Jul-12 11:00am

Why are you telling me this?