Throws the StacKOverFlowException was Unhandled..

Question

0.00/5 (No votes)

See more:

Hello
I m getting error "An unhandled exception of type 'System.StackOverflowException' occurred in windowsApplication1.exe" on my application.

I have two forms in My application: Form1 and Form2. Both Form containong 2 textbox and one button.

The code i written in Form1 is Below:

C#

public string firstName
{
    set{ txtFirst.Text = value;}
    get { return firstName;}
}

public string lastName
{
    set{ txtLast.Text = value;}
    get { return lastName;}
}

private void btnNext_Click(Object sender, EventArgs e)
{
    Form2 f2 = new Form2();
    f2.show();
}

The code i written in Form2 is Below:

C#

Form1 f1 = new Form1(); // Throws exception " StackOverFlowException was unhandled"

private void insertRecord()
{
   //Code for SqlConnetion String and SqlCommand
   cmdParameters.addWithValue("@FirstName", f1.firstName);
   cmdParameters.addWithValue("@LastName", f1.lastName);
   cmdParameters.addWithValue("@Address", txtBox1.Text);
   cmdParameters.addWithValue("@City", txtBox2.Text);
}

private void btnNext_Click(Object sender, EventArgs e)
{
    insertRecord();
}

Anybody Plz Help me out. Its an urgent task for me bt while running this code i m getting error on Form2.

Regards

Posted 24-Jun-12 23:56pm

Maahi Sawarkar

Updated 25-Jun-12 0:05am

Mehdi Gholam

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Dylan Morley · Answer 1 · 2012-06-25T00:22:00

Your property names are causing recursion that is generating the Exception. Look at this code..

C#

public string firstName
    {
        set{ txtFirst.Text = value;}
        get { return firstName;}
    }

When you access the firstName property, it is running the 'get' code which is calling firstName again. This will cause never ending recursion which ends up in a StackOverflow exception.

You should really name like this...

C#

private string firstName = string.empty;
public string FirstName
    {
        set{ txtFirst.Text = value;}
        get { return firstName;}
    }

Public fields should be capitalised, this will also avoid the StackOverflow since firstName and FirstName are treated differently now.

This also applies to your 'lastName' property.

NB: In future, you can figure out where StackOverflow exceptions are occuring in your code by using your debug window. When the exception causes the code to stop, from your Debug menu choose Debug->Windows->Call stack. This will show you all the calls that have happened up to this point, you will see lots of the same function calls in here (the recursive calls) which will tell you where the problem lies.