Help to Correct the query

Question

0.00/5 (No votes)

See more:

SQL-Server-2005

SQL

select Sheetno,VehicleNo,EDate,SKM,EKM,TKM,Driver1,Driver2,Cleaner,AdvAmt,Mile,Tfrieght,Trecv,TBal,TEAmt,NetBal from TripSheet where VehicleNo ='" & cb_VehNo.Text & "' and EDate between '" & dtp_Fdate.Value & "' and '" & dtp_Ldate.Value & "'

Plz... Say is this correct or not?....

Posted 6-Jun-12 0:12am

PunithaSabareeswari

Add a Solution

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

thatraja · Answer 1 · 2012-06-06T10:20:00

That's wrong
Yes, have you heard about SQL injection[^]? Never concatenate strings to for SQL things. Use parametrized queries.

C#

SqlCommand cmd = new SqlCommand("SELECT Sheetno,VehicleNo,EDate,SKM,EKM,TKM,Driver1,Driver2,Cleaner,AdvAmt,Mile,Tfrieght,Trecv,TBal,TEAmt,NetBal FROM TripSheet WHERE VehicleNo =@VehicleNo AND EDate BETWEEN @FromDate AND @ToDate",con);
cmd.Parameters.AddWithValue("@VehicleNo", cb_VehNo.Text);
cmd.Parameters.AddWithValue("@FromDate", dtp_Fdate.Value);
cmd.Parameters.AddWithValue("@ToDate", dtp_Ldate.Value);

Interesting read - Give me parameterized SQL, or give me death[^]

RDBurmon · Answer 2 · 2012-06-06T00:17:00

Solution 1

This is correct.

Hope this helps , If yes then plz accept and vote the answer. Any queries / questions on this are always welcome.

Thanks & Regards
RDBurmon.Sr.Software Engineer

Posted 6-Jun-12 0:17am

RDBurmon

Comments

PunithaSabareeswari 6-Jun-12 6:23am

i wrote this comment in DateTimePicker2_ValueChanged event.. is it possible..

VJ Reddy · Answer 3 · 2012-06-06T00:27:00

This appears to be correct.

One point to see is the format of dtp_Fdate.Value and dtp_Ldate.Value, which can be like 'yyyyMMdd' or 'yyyy-MM-dd'.

Further as explained http://msdn.microsoft.com/en-us/library/ms187922.aspx[^] the query includes the records with From and To dates of the Between clause.

Arul R Ece · Answer 4 · 2012-06-06T00:39:00

Solution 3

Hi ..

Please try this ,,,

C#

select Sheetno,VehicleNo,EDate,SKM,EKM,TKM,Driver1,Driver2,Cleaner,AdvAmt,Mile,Tfrieght,Trecv,TBal,TEAmt,NetBal from TripSheet where VehicleNo ='" + cb_VehNo.Text + "' and EDate between '" + dtp_Fdate.Value + "' and '" + dtp_Ldate.Value +"'

Posted 6-Jun-12 0:39am

Arul R Ece

Comments

PunithaSabareeswari 6-Jun-12 6:51am

Sorry... I won't Work..... query selected only that veh.no records it won't check the date

Arul R Ece 6-Jun-12 6:55am

U which data type used for dates

PunithaSabareeswari 6-Jun-12 7:40am

datetime data type....

Help to Correct the query

4 solutions

Solution 4

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0