having trouble in finding geatest 4 ?!

Question

0.00/5 (No votes)

See more:

Hi...!!
Please check my CODE I just have one error, I'm gonna mad of thinking how to solve this .. [error C2059: syntax error : 'constant']

C++

// Greatest-4.cpp : Defines the entry point for the console application.
 //

 #include "stdafx.h"
 #include <iostream>
 using namespace::std;

 int Greatest4 (int *a)
 {
   int p=0;
   a[p];

   for(int i=0; i<4; i++, p++)
   {
     if(a[p]>i)
     {
       i=a[p];
     }
   }
   return 302;
 }

 int main()
 {
   int a[4];
   a[0]=9;
   a[1]=1;
   a[2]=5;
   a[3]=4;
   int Greatest4(int a,4);
   cout<<"Greatest4 Is:"<<Greatest4<<endl;
   return 0;
 }

Posted 11-Apr-12 2:23am

Usman Hunjra

Updated 11-Apr-12 2:32am

CPallini

v3

Add a Solution

2 solutions

Solution 2

C++

int Greatest4(int a,4);

What you want to in the above statement ?
Did you got the error resolved now ?

No?
I suppose you want to catch the return of Greatest4 function. Also you have declared Gretest4() to take one argument (a int pointer), but you are passing too many !!
It should be

C++

int ret = Greatest4(a);

And

C++

cout<<"Greatest4 Is:"<<ret;

Posted 11-Apr-12 2:37am

Lakamraju Raghuram

Comments

Usman Hunjra 11-Apr-12 8:42am

Yes error resolved but answer is wrong ..

Usman Hunjra 11-Apr-12 8:53am

I'm New In C++ nd this is my first assignment .....
HELP NEEDED .!!

Lakamraju Raghuram 11-Apr-12 9:01am

Check solution by CPallini.

Usman Hunjra 11-Apr-12 9:02am

THANK YOU SOOOOOOOOOOOOO MUCH ..

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Accepted Answer · 2012-04-11T02:31:00

To make it compile change (inside the main function) the

C++

int Greatest4(int a,4);

line to the proper function call

C++

Greatest4(a);

However, making your program meaningful is more difficult, in my opinion.

[update]

Try the code below:

C++

#include <iostream> 
#include <cassert>

using namespace std; 
int GreatestOf (int  a[], int size)
 {
   assert(size > 0);
   int max = a[0];
   for(int i=1; i<size; i++)
   {
     if(max < a[i])
     {
       max = a[i];
     }
   }
   return max;
 }
 
 int main()
 {
   int a[4] = { 9, 1, 5, 4};
   int size = sizeof(a)/sizeof(a[0]); //  or just 'size = 4;'
   cout<<"Greatest4 Is:"<< GreatestOf(a, size) << endl;
   return 0;
 }

[/update]