Function returning complex class

"is of course a typo, it is "one" " - How do we know ?? We can't assume. Right ?

Now as you resolved it, here is my anwser :

CObject (from where CArray is derived from) declares a private copy constructor, so that constructor can't be used by default unless it's implemented in a derived class.

Now when you return CArray by value, then it's copy constructor and hence it's base CObject copy const is called (and this gives an error). Instead try to return as reference or pointer (which wont lead to calling of copy const)

[EDIT]

This is not a stupid question as mentioned by OP.
In fact an error made by many.
One cannot return any class object derived from CObject by value as it will lead to calling of copy constructor of CObject, which is not allowed

Return by value in you function seems fine as the copy of the created object will be sent to the caller and nothing is problamatic. although if the size of the object is big then it might be a little performance overhead.

The second function declaration accepts a reference and you will assign that reference or change that reference values inside the function, which could work fine but this will make the caller resposible for creating the object and passing it by reference.

The convention is more like: pass all objects by const reference if you dont want them to get changed. pass them by pointer if you want them to get changed inside the function.

so I will say either you keep the original methid as is (little performance overhead on copy constructor call) or use pointer to do same thing.

function:

void GetClass(CString C, one * class_one)
{
 class_one = new one();
  if(C == "GO")
   {
     class_one->Add(5.4);
   }
   else
   {
    class_one->Add(3.5);
   }
}

and call as:

One *one;
GetClass(C, one);

I might be wrong, someone can perhaps correct me of ratify this.

one two::GetClass(CString C)
{
   two class_one;
   .....
   return class_one;

When class two is not related to class one - how can you return object of two as one ?

And regarding that C2248 error look here : http://msdn.microsoft.com/en-us/library/tsbce2bh(v=vs.80).aspx

I suppose the error is nothing to do with CArrays

Guys I know what the C2245 stands for ;) But the funny thing is that if I make the function GetClass to return void (e.g. like I wrote the second version) the error doesn't appear.

The

one two::GetClass(CString C)
{
  two class_one 
  ...
}

is of course a typo, it is "one".

Rahul Rajat Singh, thanks for the suggestion I will try using pointers, just not to forget to delete the *one after I finish with it :D

Well I thought it was obvious that is was a typo, but as you said one can't assume anything. Thanks for the answer, I will give it a try. Just to clear it, by saying to return a reference or pointer, you are speaking of something like this?

one& GetClass(CString C)

and

one* GetClass(CString C)

or as Rahul wrote?

P.S. What I wrote for the typo wasn't in a "attack" meaning, I just express my self like that :D