Problem with Virtual piano

Question

0.00/5 (No votes)

See more:

I have a virtual piano . This gives different sound based on the selected Instrument which is listed in a combobox.I have a edit box which displays Notes when i perform mousedown or keydown or mouse move based on the key high lighted.
When i click on Record button the sound what ever comes is recorded as sound.wav and played when required.

Now i have a requirement that is when i play the recorded one i should make the corresponding keys to highlight and the corresponding notes to display.
I am able to perform this when i do OnLButton down but not able to do when Keydown.
Because at a time more than one key can be pressed I am able to record the time but not able to play keys along with the playing sound.

I have tried my best to do but i am not understanding how to make this work.

Posted 13-Feb-12 19:26pm

chaiein

Updated 13-Feb-12 19:28pm

v2

Add a Solution

3 solutions

Solution 2

// I have a virtual piano .
:)

// Now i have a requirement that is when i play the recorded one
// i should make the corresponding keys to highlight and the corresponding notes to display.

If you do not plane on building of an sequence analyzer for a saved file
you could try to save the "notes logic"+"keys'n'pauses-mapping" -
in your own format, additionally to the wav-file.

Of course
the both dumps (wav and mapping) should have the same duration for each "item"
(it could be "scanned" dynamically at the play-time or statically from the edit box) :)

Posted 13-Feb-12 20:37pm

Eugen Podsypalnikov

Comments

chaiein 15-Feb-12 0:09am

i did not understand.

chaiein 1-Mar-12 23:18pm

notes logic what is it please explain. for example?

Eugen Podsypalnikov 2-Mar-12 1:57am

For example:
(ACE)99, (P)1, (DF)99, (P)1, (ACE)1000, ...
could meen:
ACE-chord plays for 99 milliseconds, then
Pause for 1 millisecond, then
DF-chord for 99 milliseconds, then
Pause for 1 millisecond, then
ACE-chord for 1 second, then ...

Solution 1

For each key press you will get the keydown message and for each release you will get the keyup message.
So its a matter of checking which is pressed and which is released.

You will need to post some code and indicate where the problem occurs.

Posted 13-Feb-12 19:51pm

«_Superman_»

Comments

chaiein 14-Feb-12 2:18am

if(record==true)
{
recordNo++;
m_KeysRecord.push_back(m_CurrKey);
m_KeysChar.push_back(m_LowNote+m_CurrKey);
GetSystemTime(&m_KeysStartTime);
}

The above code is stores the key which is high lighted.
The below function is called after the recording complete and playing the recorded data.
void CPianoCtrl::Display_RecordNote()
{
CRect InvalidRect;
for(int recording=0;recording<=recordNo;recording++)
{
XSleep(Elapsed[recording]);

m_Keys[m_KeysRecord[recording]]->NoteOn(m_NoteOnColor, InvalidRect);

InvalidateRect(&InvalidRect);

findchords(m_KeysChar[recording]);
//InvalidateRect(&InvalidRect);

}
}
when i use record of keydown and which ever keydown when i play it plays one by one.i want to play the way i pressed the key that is when one keydown and keyup is pressed other key may be still keydown that is how may be the user have pressed the key while recording.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2012-02-13T20:55:00

Separate events from actions. You should refactor you code the way you have three separate things: key up/down event, visual feedback of a key: pushed and normal state, which lighted key being optional, sound effect of the key: start/stop playing a note.

Don't hard code the two key action in the event handler, make them separate method. This way, you can call them from different places: for example, from the key handler and from the played sequence.

In two words, use loose coupling, see http://en.wikipedia.org/wiki/Loose_coupling[^].

Now, what do you stream in the play sequence, just notes? Or you can add extra information which would denote keys? No matter, there is one-to-one correspondence between keys and notes (musical tones), so finding a key from a recorded sequence is not a problem at all.

—SA