Why blank space in my file are missing when i tried to open a file

Question

0.00/5 (No votes)

See more:

Hi all, I write a small code to open the file my file contents are as follows each line length is 94 characters and line terminator is \r and \n

101 111111111 1111111111010190542A094101
9000000000001000000000000000000000000000000000000000000

// same Works for this text

101 111111111 1111111111010190608A094101
52001 1 1 CCD1 101019101019 1111000020000001 6201110000251 00000000011 1 1 0111000020000001 820000000100111000020000000000000000000000011 111000020000001 9000001000001000000010011100002000000000001000000000000

C#

private void mnuOpen_Click(object sender, EventArgs e)
    {
        string strFilePath = string.Empty;
        OpenFileDialog openFileDialog1 = new OpenFileDialog();
        openFileDialog1.FileName = string.Empty;
        openFileDialog1.RestoreDirectory = true;
        if (openFileDialog1.ShowDialog() == DialogResult.OK)
        {
            strFilePath = openFileDialog1.FileName;
            StreamReader sr = new StreamReader(strFilePath);
            string str = string.Empty;
            str = sr.ReadToEnd().Replace("\r", "").Replace("\n", "");
            sr.Close();
            if (str.Length % 94 == 0)
            {
                 //Do some thing
             }
           }

But I am not getting an error here, can anyone tell why?

Posted 19-Oct-10 22:17pm

demouser743

Updated 19-Oct-10 22:28pm

Saurabh.Garg

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2010-10-19T22:34:00

The lines of data you have shown are not 94 characters per line.If you concatenate the first two, it is 95.
Check your inputs.

1) Don't use "magic numbers" - 94 is one in your code. Why is it 94? Answer: because that is the data size. So use a constant, and call it "dataSize" of similar. That way, if the data size changes, you only have to change it in one place.

2) If you are working with line-based data, then read it as lines:

C#

string[] lines = File.ReadAllLines(openFileDialog1.FileName);

Will read your whole file, without worrying about streams, and place each line into a separate string, removing the \r and \n for you. You can then process each group of data separately, and report errors for individual "bad lines". You should not faff about with line terminators: they are not the same for all systems. The system you are working on knows what lines end with - use it!