wrong answer in loop

Question

0.00/5 (No votes)

See more:

C#

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;

namespace ConsoleApplication1
{
    class Menu
    {
        public void go()
        {
            int choice = -1;

            while (choice != 0)
            {
                WriteMenuText();
                choice = int.Parse(Console.ReadLine());
                switch (choice)
                {
                    case 1:
                        {

                        }
                    case 2:
                        {

                        }
                    case 3:
                        {

                        }
                }
            }
        }
        
             
        public void WriteMenuText()
        {

Console.WriteLine("-------------------------------------------------------");
            Console.WriteLine("      week                                    :1");
            Console.WriteLine("      Time                                    :2");
            Console.WriteLine("      Currency                                :3");
            Console.WriteLine("      calculater                              :4");
            Console.WriteLine("      Exit                                    :0");
            Console.WriteLine("-------------------------------------------------------");
            Console.WriteLine("\nYour choice");
        }
		
    }

}

I have one problem white it when im going to pick a number over 4 and under 0 its going to say wrong nummber try again and the menu will com up one moore time. but i dont get it to work.

Posted 1-Feb-12 23:52pm

Tommy116

Add a Solution

Comments

Sridhar Patnayak 2-Feb-12 6:10am

Tommy you placed WriteMenuText();
choice = int.Parse(Console.ReadLine());
in while loop, so it is displaying more times
for answer check my solution.

4 solutions

Solution 1

In switch case better to use

default :

In your case,it is like this

default   :Console.WriteLine("Entered wrong choice");

and change your code some thing like this

C#

WriteMenuText();
choice = int.Parse(Console.ReadLine());
while (choice != 0)
          {
              
              
              switch (choice)
              {
                  case 1:
                      {

                      }
                  case 2:
                      {

                      }
                  case 3:
                      {

                      }
                  case 4:
                      {

                      }
                 default: { }


              }
          }

Thanks
SP

Posted 2-Feb-12 0:01am

Sridhar Patnayak

Updated 2-Feb-12 0:06am

v3

Comments

Tommy116 2-Feb-12 6:31am

thx

Solution 2

Your while is checking for 0 only. Anything else keeps the loop running.

Posted 2-Feb-12 0:01am

Catalin Serafimescu

Solution 3

modify your go function and change the switch case to add the default case.
code is given below.

C#

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;

namespace ConsoleApplication1
{
    class Menu
    {
        public void go()
        {
            int choice = -1;

            while (choice != 0)
            {
                WriteMenuText();
                choice = int.Parse(Console.ReadLine());
                switch (choice)
                {
                    case 1:
                        {

                        }
                    case 2:
                        {

                        }
                    case 3:
                        {

                        }
                   default:
                        {
                            Console.WriteLine("Wrong Number");
                        }  

                }
            }
        }


        public void WriteMenuText()
        {

Console.WriteLine("-------------------------------------------------------");
            Console.WriteLine("      week                                    :1");
            Console.WriteLine("      Time                                    :2");
            Console.WriteLine("      Currency                                :3");
            Console.WriteLine("      calculater                              :4");
            Console.WriteLine("      Exit                                     ");
            Console.WriteLine("-------------------------------------------------------");
            Console.WriteLine("\nYour choice");
        }

    }

}

in case of any problem revert back.

Posted 2-Feb-12 0:07am

Sourav Sarkar-SS

Comments

Tommy116 2-Feb-12 6:31am

thx

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Tommy116 · Accepted Answer · 2012-02-02T00:16:00

Solution 4

thx for the help bur when i enter the default:
i get a error like this Control cannot fall through from one case label default to another

Posted 2-Feb-12 0:16am

Tommy116

Updated 2-Feb-12 0:27am

v2