problem with [SELECT] cant update

Question

0.00/5 (No votes)

See more:

HTML

<select  önchange="getCountry('country');" id="country" name = "country"><select>

HTML

function getCountry(x)
{
var y=document.getElementById(x).value;
document.getElementById('ctl00_ContentPlaceHolder1_lblCountry').innerHTML =y;
}

HTML

function load()
{
document.getElementById('country').value = document.getElementById('ctl00_ContentPlaceHolder1_lblCountry').innerHTML;
}

C#

protected void Page_Load(object sender, EventArgs e)
{
//if(!ISPostBack)
//{
string connectionString = "Data Source = .\\SQLEXPRESS;AttachDbFilename=|DataDirectory|\\Database.mdf;Integrated Security = True;Connect Timeout=30;User Instance = True";

System.Data.SqlClient.SqlConnection conn = new System.Data.SqlClient.SqlConnection(connectionString);
System.Data.SqlClient.SqlCommand cmd = conn.CreateCommand();

cmd.CommandText = "SELECT * FROM [product] where ID = '1'";

conn.Open();

System.Data.SqlClient.SqlDataReader dr = cmd.ExecuteReader();

while (dr.Read())
{
    this.lblCountry.Text = dr["country"].ToString();                
}
//}
}

protected void btnUpdate_Click(object sender, EventArgs e)
{
string connectionString = "Data Source = .\\SQLEXPRESS;" + "AttachDbFilename=|DataDirectory|\\Database.mdf;Integrated Security = True;Connect Timeout=30;User Instance = True";

System.Data.SqlClient.SqlConnection conn = new System.Data.SqlClient.SqlConnection(connectionString);
System.Data.SqlClient.SqlCommand cmd = conn.CreateCommand();

cmd.Parameters.Add("country", SqlDbType.VarChar);
cmd.Parameters["country"].Value = this.lblCountry.Text;  //retrieve as 'Japan' Instead of 'Korea' 

cmd.CommandText = "UPDATE [product] SET [country] = @country WHERE [ID] = '1'";

conn.Open();
int numberOfRows = cmd.ExecuteNonQuery();
conn.Close();
}

1. On page load, the SELECT dropdownlist is show 'Japan', so as lblCountry.
2. If i change the Item from 'Japan' to 'Korea', lblCountry also will update to 'Korea'.
3. btnUpdate been click, page will load again, but it stills show 'Japan' instead of 'Korea'. Check at database, it still remains as 'Japan'. The same code/query been used on asp:dropdownlist and it works as expected.
Any advice for this question please? :)

Posted 27-Dec-11 20:46pm

melvintcs

Updated 27-Dec-11 21:24pm

v2

Add a Solution

Comments

demouser743 28-Dec-11 3:03am

Have you added if(!IsPostback) in your page load

melvintcs 28-Dec-11 3:22am

yes, i did :) still the same

demouser743 28-Dec-11 3:27am

Why you are assigning the values from JavaScript why don't you get it from sever side code

melvintcs 28-Dec-11 5:34am

if i add runat="server", then the country list wont appear... the only way is to transfer the value to Label, then get the value from codeBehind. My country list is stored in the countries.js

2 solutions

Solution 2

Try using this code:

cmd.Parameters.AddWithValue("@country", this.lblcountry.Text);

to replace:

SQL

cmd.Parameters.Add("country", SqlDbType.VarChar);
cmd.Parameters["country"].Value = this.lblCountry.Text;

Posted 27-Dec-11 22:40pm

Ebnezer Oyenuga

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

amit28august · Accepted Answer · 2011-12-27T22:27:00

Solution 1

It may be the browser problem try

JavaScript

document.getElementById('ctl00_ContentPlaceHolder1_lblCountry').innerHTML =y;

document.getElementById('ctl00_ContentPlaceHolder1_lblCountry').value=y;

document.getElementById('ctl00_ContentPlaceHolder1_lblCountry').text=y;

it works fine for me and also include ur page load definations in IsPostback.

It works well for me.

Posted 27-Dec-11 22:27pm

amit28august

Updated 27-Dec-11 22:28pm

v2

Comments

melvintcs 28-Dec-11 5:26am

tried on chrome, IE and firefox, only the first one (innerHTML) is working, my 'working' here means lblCountry will update if change the value of the dropdownlist.

amit28august 28-Dec-11 5:41am

yes, lblCountry is updating onchange of select dropdownlist.

amit28august 28-Dec-11 5:44am

<select önchange="getCountry('country');" id="country" name = "country">
<option value ="Japan">Japan</option>
<option value ="Korea">Korea</option>
<option value ="Africa">Africa</option>
</select>

<asp:Label ID ="lblCountry" runat ="server" >

<script language ="javascript" type ="text/javascript">

function getCountry(x)
{
var y=document.getElementById(x).value;
document.getElementById('lblCountry').innerHTML =y;

alert (y);

}
</script>

You try first with this normal code then u go with ur databse assinment.

melvintcs 28-Dec-11 6:15am

ok, this is working. but did u try to store the selected value?
this is what i did:

protected void Button1_Click(object sender, EventArgs e)
{
string connectionString = "Data Source = .\\SQLEXPRESS;" + "AttachDbFilename=|DataDirectory|\\Database.mdf;Integrated Security = True;Connect Timeout=30;User Instance = True";

System.Data.SqlClient.SqlConnection conn = new System.Data.SqlClient.SqlConnection(connectionString);
System.Data.SqlClient.SqlCommand cmd = conn.CreateCommand();

cmd.Parameters.Add("country", SqlDbType.VarChar);
cmd.Parameters["country"].Value = this.lblCountry.Text;

cmd.CommandText = "INSERT INTO [member] ([country]) VALUES (@country)";

conn.Open();

int numberOfRows = cmd.ExecuteNonQuery();
conn.Close();
}

it store nothing into the field... this is the main problem i facing right now :(

amit28august 28-Dec-11 6:23am

do one thing make select available at code side by making it runat="server" in html

<select runat="server" önchange="getCountry('country');" id="country" name = "country">
<option value ="Japan">Japan</option>
<option value ="Korea">Korea</option>
<option value ="Africa">Africa</option>
</select>

and then u can use

cmd.Parameters["country"].Value =country.Value.Tostring();
to get the selected value

this works fine.

melvintcs 28-Dec-11 6:29am

yes, it able to store the selected value, but the lblCountry is no update and alert(y) is not functioning..

javascript cant work if there is runat="server", and my country list is stored in countries.js which required javascript to display them. so the scripting must be working, thx for your help :)

amit28august 28-Dec-11 6:35am

include in ur button click this at last to update the label from code behind

lblCountry.Text = country.Value.ToString();

this also works fine.

melvintcs 28-Dec-11 6:41am

yes it's working, but
onchange="getCountry('country');" is not working after add runat="server" :(

amit28august 28-Dec-11 6:43am

ya javascripts will work with runat server also. now wats the problem u r facing.

melvintcs 28-Dec-11 6:47am

after i add runat="server" like this
<select runat="server" önchange="getCountry('country');" id="country" name = "country">
the code inside 'function getCountry(x)' is not working... for example: alert (y) is not functioning also..

amit28august 28-Dec-11 6:58am

its work fine 4 me..... u have to check some prom at ur end only......

amit28august 28-Dec-11 7:01am

onchange 'o' looks different chrck the spell........

<select runat="server" onchange="getCountry('country');" id="country" name = "country">

use this over there........

melvintcs 28-Dec-11 7:16am

the 'o' became like that after i paste here, it's 'o' in my scripting.

weird... ok, can you try this code?

<%@ Page Language="C#" AutoEventWireup="true" CodeFile="test.aspx.cs" Inherits="test" %>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">
<head runat="server">
<title>Untitled Page</title>
<script type="text/javascript">

function getCountry(x)
{
var y=document.getElementById(x).value;
document.getElementById('lblCountry').innerHTML =y;

alert(y);
}
</script>
<style type="text/css">

body
{
margin: 0;
padding: 0;
}

</style>
</head>
<body>
<form id="form1" runat="server">
<select runat="server" önchange="getCountry('country');" id="country" name = "country">
<option value ="Japan">Japan</option>
<option value ="Korea">Korea</option>
<option value ="Africa">Africa</option>
</select>
<asp:Label ID ="lblCountry" runat ="server" >
<br />
<asp:Button ID="Button1" runat="server" onclick="Button1_Click" Text="Button" />
</form>
</body>
</html>

//code behind
using System;
using System.Collections;
using System.Configuration;
using System.Data;
using System.Web;
using System.Web.Security;
using System.Web.UI;
using System.Web.UI.HtmlControls;
using System.Web.UI.WebControls;
using System.Web.UI.WebControls.WebParts;

public partial class test : System.Web.UI.Page
{
protected void Page_Load(object sender, EventArgs e)
{

}
protected void Button1_Click(object sender, EventArgs e)
{
string connectionString = "Data Source = .\\SQLEXPRESS;" + "AttachDbFilename=|DataDirectory|\\Database.mdf;Integrated Security = True;Connect Timeout=30;User Instance = True";

System.Data.SqlClient.SqlConnection conn = new System.Data.SqlClient.SqlConnection(connectionString);
System.Data.SqlClient.SqlCommand cmd = conn.CreateCommand();

cmd.Parameters.Add("username", SqlDbType.VarChar);
cmd.Parameters["username"].Value = country.Value.ToString();

cmd.CommandText = "INSERT INTO [member] ([username]) VALUES (@username)";

conn.Open();

int numberOfRows = cmd.ExecuteNonQuery();
conn.Close();
lblCountry.Text = country.Value.ToString();
lblCountry.Text = this.lblCountry.Text;
}
}
//just exactly copy and paste, check either the getCountry(x) is functioning or not?

amit28august 28-Dec-11 7:22am

asp:Label closing is missing

and it works fine man............damm correct........i just change O in onchange tats it and for label. same code i pasted and it is ok........ got to go....work time is over....try man some small prob might b there. just check it, all d best man. Every thing is ok.

melvintcs 28-Dec-11 7:29am

the 'o' and Label close i have it here. i auto change after i paste here..

WHAT ELSE I MISSED? arhghhghghhhh...
My label wont auto-update after i change the value from drop down list.
did your alert(y) functioning as well?

melvintcs 28-Dec-11 7:33am

try to create a master Page and use this code?
<%@ Page Language="C#" MasterPageFile="~/Blank.master" AutoEventWireup="true" CodeFile="testing.aspx.cs" Inherits="testing" Title="Untitled Page" validateRequest="false" %>

<asp:Content ID="Content1" ContentPlaceHolderID="head" Runat="Server">
<script type="text/javascript">

function getCountry(x)
{
var y=document.getElementById(x).value;
document.getElementById('ctl00_ContentPlaceHolder1_lblCountry').innerHTML =y;

alert(y);
}
</script>

<asp:Content ID="Content2" ContentPlaceHolderID="ContentPlaceHolder1" Runat="Server">
<select runat="server" önchange="javascript:getCountry('country');" id="country" name = "country">
<option value ="Japan">Japan</option>
<option value ="Korea">Korea</option>
<option value ="Africa">Africa</option>
</select>

<asp:Label ID ="lblCountry" runat ="server" >
<br />
<asp:Button ID="Button1" runat="server" onclick="Button1_Click" Text="Button" />

amit28august 28-Dec-11 23:15pm

Hi prob in ur javascript not able to find the control 'country'

change ur html and use 'this' instead of passing the name

onchange="getCountry(this);"

and in javascript change

var y=x.value;

thats it, it will work........:)