input string was not in correct format? how to solve

Question

0.00/5 (No votes)

See more:

Can Anyone know this, ans me.......

Error code:

C#

public float getshipping(string deliveryarea)
{
    SqlCommand cmd3 = new SqlCommand("select shipping from delivery where status='A' and area='" + deliveryarea + "'", con);
    SqlDataReader dr3;
    dr3 = cmd3.ExecuteReader();
    while (dr3.Read())
    {
        shipping = float.Parse(dr3[0].ToString());
    }
    dr3.Close();
    return shipping;
}

Posted 27-Nov-11 22:08pm

M.Narmatha

Updated 27-Nov-11 22:10pm

Mehdi Gholam

v2

Add a Solution

Comments

DaveAuld 28-Nov-11 4:15am

On a side note, suggest you look at converting your code to parameterised queries.

raj ch 28-Nov-11 4:28am

May be the value ur trying to convert is not in correct format

Nickos_me 28-Nov-11 5:17am

Little advise - it's better to use SqlParameter instead of "select shipping from delivery where status='A' and area='" + deliveryarea + "'".
And better use using instead of dr3.Close();

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

vivekgvivi · Answer 1 · 2011-11-27T22:13:00

Solution 1

You are trying to convert a value to float..Check what value you are getting in dr3[0].

Posted 27-Nov-11 22:13pm

vivekgvivi

koolprasad2003 · Answer 2 · 2011-11-27T22:13:00

Solution 2

You are trying to parse the value in float that might bot be digits.
pl. check the value of dr3[0].ToString()

Posted 27-Nov-11 22:13pm

koolprasad2003

sagar15modi · Answer 3 · 2011-11-27T22:20:00

C#

public float getshipping(string deliveryarea)
  {
      float shipping =0;
      SqlCommand cmd3 = new SqlCommand("select shipping from delivery where status='A' and area='" + deliveryarea + "'", con);
      SqlDataReader dr3;
      dr3 = cmd3.ExecuteReader();
      while (dr3.Read())
      {
          float.TryParse(Convert.ToString(dr3[0]),out shipping);
      }
      dr3.Close();
      return shipping;
  }

Instead of float.Parse you can use float.TryParse which will return 0 if there is invalid value.

Eduard Lu · Answer 4 · 2011-11-27T22:24:00

Solution 4

C#

shipping = float.Parse(dr3[0].ToString());

debug it.. check if dr3[0] is convertible to float.. if not, then that is the cause of the error

-Eduard

Posted 27-Nov-11 22:24pm

Eduard Lu