Data table value to Database

Question

0.00/5 (No votes)

See more:

SQL-Server-2005

, +

Hi
I am first time trying to insert datatable value to database and getting error us insert statement wrong pls correct

Thanks

string connectionString = ConfigurationManager.ConnectionStrings["InvoiceConnectionString"].ConnectionString;
SqlConnection conn = new SqlConnection(connectionString);
StringBuilder sb = new StringBuilder(string.Empty);
string[] splitItems = null;
foreach (string item in sc)
{
    const string insertsql = "INSERT INTO Items(Description,ItemNo,Qty)VALUES";
    if (item.Contains(","))
    {
        splitItems = item.Split(",".ToCharArray());
        sb.AppendFormat("'{0}','{1}','{2}');",insertsql, splitItems[0], splitItems[1], splitItems[2]);



    }
}
try
{
conn.Open();
SqlCommand cmd = new SqlCommand(sb.ToString(),conn);
cmd.CommandType =CommandType.Text;
cmd.ExecuteNonQuery();
Page.ClientScript.RegisterClientScriptBlock(typeof(Page),"script","alert('Record Successfuly saved');",true);
}
catch(System.Data.SqlClient.SqlException ex)
{
string msg = "AddItem Error:";
    msg += ex.Message;
    throw new Exception(msg);


}
finally
{
    conn.Close();

}

the error is

C#

System.Exception was unhandled by user code
  Message="AddItem Error:Incorrect syntax near 'INSERT INTO Items(Description,ItemNo,Qty)VALUES'."
  Source="App_Web_mi2y70b-"
  StackTrace:
       at Admin_Pages_DO_Management_EditDo.addItem(StringCollection sc) in c:\Inetpub\wwwroot\Invoice\Admin_Pages\DO_Management\EditDo.aspx.cs:line 240
       at Admin_Pages_DO_Management_EditDo.Submitbtn_Click(Object sender, EventArgs e) in c:\Inetpub\wwwroot\Invoice\Admin_Pages\DO_Management\EditDo.aspx.cs:line 278
       at System.Web.UI.WebControls.Button.OnClick(EventArgs e)
       at System.Web.UI.WebControls.Button.RaisePostBackEvent(String eventArgument)
       at System.Web.UI.WebControls.Button.System.Web.UI.IPostBackEventHandler.RaisePostBackEvent(String eventArgument)
       at System.Web.UI.Page.RaisePostBackEvent(IPostBackEventHandler sourceControl, String eventArgument)
       at System.Web.UI.Page.RaisePostBackEvent(NameValueCollection postData)
       at System.Web.UI.Page.ProcessRequestMain(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint)
  InnerException:

Posted 13-Nov-11 23:03pm

Lancy.net

Updated 14-Nov-11 2:18am

Pandya Anil

v2

Add a Solution

Comments

thatraja 14-Nov-11 5:12am

what's the error message? include that in your question.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

RaisKazi · Answer 1 · 2011-11-13T23:09:00

Solution 1

Debug your code and check what is the Insert statement gets formed in sb at run-time.

Have a look at below link for "SQL Insert" syntax.

http://www.w3schools.com/sql/sql_insert.asp

Posted 13-Nov-11 23:09pm

RaisKazi

thatraja · Answer 2 · 2011-11-13T23:24:00

Solution 2

Prevent SQL injection by using parametrized queries
Using Parameterized queries to prevent SQL Injection Attacks in SQL Server[^]

Also careful with SQL Server Reserved Keywords[^], Use Square brackets[] for the field names & table names.

And your code is wrong, try this.

C#

const string insertsql = "INSERT INTO Items(Description,ItemNo,Qty)VALUES";
sb.AppendFormat("{0}",insertsql);  
foreach (string item in sc)
        {
            if (item.Contains(","))
            {
                splitItems = item.Split(",".ToCharArray());
                sb.AppendFormat("'{0}','{1}','{2}');",splitItems[0], splitItems[1], splitItems[2]);                    
            }
        }

But use parametrized queries

Posted 13-Nov-11 23:24pm

thatraja

Updated 13-Nov-11 23:28pm

v2

Comments

Lancy.net 14-Nov-11 7:53am

Hi thanks for your kind reply, i have tried your code also again i am getting the error as "AddItem Error:Incorrect syntax near 'INSERT INTO Items(Description,ItemNo,Qty)VALUES'." i will attach stack track also

thatraja 14-Nov-11 7:59am

Can you get the value for the string-builder(sb) at debugging?

Lancy.net 14-Nov-11 9:57am

yes , i made few changes pls see below

const string insertsql = "INSERT INTO Items(Description,ItemNo,Qty)VALUES (";
sb.AppendFormat("{0}", insertsql);
foreach (string item in sc)
{
if (item.Contains(","))
{
splitItems = item.Split(",".ToCharArray());
sb.AppendFormat("'{0}','{1}','{2}');", splitItems[0], splitItems[1], splitItems[2]);

}
}

Now if i have one row of data i am able to save it to database.
if more than one row getting error as incorrect statement near '{2}' pls chk

Pandya Anil · Answer 3 · 2011-11-14T02:34:00

the error description says, you are executing an incomplete query.. i.e.
INSERT INTO Items(Description,ItemNo,Qty)VALUES

the right query should be

INSERT INTO Items(Description,ItemNo,Qty)VALUES('desc1','item1','qty1');

why your query's value part is blank... ??? and there are no brackets too!!!

check your loopings and, add check conditions where required... there should be no blank queries :) :)

debug it, and get the command string before it executes.. try to execute it inside the sql before the programe executes it..

hope you notice your mistake soon :)