Error-No value given for one or more required parameters.

Question

0.00/5 (No votes)

See more:

Why this error giving.I want to submit 17 field's data out of 34.
only want to submit these below value to database
v1 = TextBox1.Text.Trim()
v2 = TextBox2.Text.Trim()
v3 = TextBox3.Text.Trim()
v4 = TextBox4.Text.Trim()
v5 = TextBox5.Text.Trim()
v6 = TextBox6.Text.Trim()
v7 = TextBox7.Text.Trim()
v8 = TextBox8.Text.Trim()
v9 = TextBox9.Text.Trim()
v10 = ta1.Value
v11 = ta2.Value
v12 = ta3.Value
v13 = ta4.Value
v14 = ta5.Value
v15 = ta6.Value
v16 = ta7.Value
v17 = ta8.Value

Error - No value given for one or more required parameters.
My code given below

VB

s = TextBox5.Text.Trim()
     Try
         cn.Open()
         cmd = New OleDbCommand("Select ccode from template where vmail='" & s & "'", cn)
         dr = cmd.ExecuteReader
         dr.Read()
         b = dr.HasRows()
         If b Then
             Label2.Text = "Record already EXIST"
             TextBox1.Focus()
             v1 = TextBox1.Text.Trim()
             v2 = TextBox2.Text.Trim()
             v3 = TextBox3.Text.Trim()
             v4 = TextBox4.Text.Trim()
             v5 = TextBox5.Text.Trim()
             v6 = TextBox6.Text.Trim()
             v7 = TextBox7.Text.Trim()
             v8 = TextBox8.Text.Trim()
             v9 = TextBox9.Text.Trim()
             v10 = ta1.Value
             v11 = ta2.Value
             v12 = ta3.Value
             v13 = ta4.Value
             v14 = ta5.Value
             v15 = ta6.Value
             v16 = ta7.Value
             v17 = ta8.Value

             v18 = TextBox10.Text.Trim()
             v19 = TextBox11.Text.Trim()
             v20 = TextBox12.Text.Trim()
             v21 = TextBox13.Text.Trim()
             v22 = TextBox14.Text.Trim()
             v23 = TextBox15.Text.Trim()
             v24 = TextBox16.Text.Trim()
             v25 = TextBox17.Text.Trim()
             v26 = TextBox18.Text.Trim()
             v27 = ta9.Value
             v28 = ta10.Value
             v29 = ta11.Value
             v30 = ta12.Value
             v31 = ta13.Value
             v32 = ta14.Value
             v33 = ta15.Value
             v34 = ta16.Value
         Else
             Try
                 str = "Insert into template (tname,tdob,tsex,tmo,tmail,tcity,tpin,tst,tco,tca,tskill,tedu,ttrain,texpt,tproj,texp,tint) values('" & v1 & "','" & v2 & "','" & v3 & "','" & v4 & "','" & v5 & "','" & v6 & "','" & v7 & "','" & v8 & "','" & v9 & "','" & v10 & "','" & v11 & "','" & v12 & "','" & v13 & "','" & v14 & "','" & v15 & "','" & v16 & "','" & v17 & "')"
                 cmd = New OleDbCommand(str, cn)
                 cmd.ExecuteNonQuery()
                 Label2.Text = "Record Added"
             Catch ex As Exception
                 Response.Write(ex.Message)
             End Try
         End If
     Catch ex As Exception
         Response.Write(ex.Message)
     End Try


     cn.Close()

Posted 7-Nov-11 21:23pm

Janardan Pandey

Updated 7-Nov-11 21:43pm

v3

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2011-11-07T21:45:00

Please, don't do it that way.
That is a major recipe for an SQL Injection attack - use Parametrized queries instead:

VB

str = "INSERT INTO template (tname,tdob,tsex,tmo,tmail,tcity,tpin,tst,tco,tca,tskill,tedu,ttrain,texpt,tproj,texp,tint) VALUES (@tname,@tdob,@tsex,@tmo...
cmd.Parameters.AddWithValue("@tname",TextBox1.Text.Trim())
cmd.Parameters.AddWithValue("@tdob",TextBox2.Text.Trim())
...

In addition, rename your controls: you may remember that TextBox7 is the "pin" today - but you won't next week. Call it something related to it's usage!
Then, you can add a check for null values to your parameter stting, and feed DBNull.Value to the database instaed, which will cure your problem.