string was not recognized as a valid boolean

Question

0.00/5 (No votes)

See more:

Hi,
The stored proc has a bit output parameter (@Success) which returns 0 or 1

My c# code gives the following error when I want to retrieve the value of @Success. What should I change in my code to solve this error please?

"String was not recognized as a valid boolean"

bool blnSuccess = bool.Parse(comm.Parameters["@Success"].Value.ToString());

Thanks

Posted 16-Oct-11 22:37pm

arkiboys

Add a Solution

4 solutions

Solution 1

Try this...

C#

string i = comm.Parameters["@Success"].Value.ToString();
bool b = bool.Parse(i == "1" ? "true" : "false");
//OR

bool b = i== "1" ? true : false;

Posted 16-Oct-11 22:47pm

Tejas Vaishnav

Comments

lukeer 17-Oct-11 4:52am

I prefer the //OR version.
But still I think it should read
bool b = ((i == "0")? false : true);

I think the parentheses make it more readable.

Solution 3

make sure comm.Parameters["@Success"] is not null by putting a breakpoint at there and observe its value

Posted 16-Oct-11 23:00pm

Amir Mahfoozi

Solution 4

bool blnSuccess = comm.Parameters["@Success"].Value=="1"?true:false

Posted 18-Oct-11 0:34am

md_refay

Add a Solution

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2011-10-16T22:51:00

Solution 2

You cannot use bool.Parse to convert "0" or "1" to a true/false result: MSDN[^] says so quite clearly.

Instead look at using something like:

C#

bool blnSuccess = comm.Parameters["@Success"].Value.ToString() == "1" ? true : false;

Posted 16-Oct-11 22:51pm

OriginalGriff

Updated 9-Jul-14 9:45am

v2

Comments

lukeer 17-Oct-11 4:55am

Shouldn't that be the other way round?

arkiboys 17-Oct-11 6:43am

Thank you

Matt T Heffron 9-Jul-14 16:21pm

Why are you using a boolean value expression to choose boolean constants that have the same value as the expression?
Why not just:
bool blnSuccess = comm.Parameters["@Success"].Value.ToString() == "1";
And if the .Value is actually numeric then why not:
bool blnSuccess = (int)(comm.Parameters["@Success"].Value) == 1;

string was not recognized as a valid boolean

4 solutions

Solution 2

Solution 1

Solution 3

Solution 4

Add your solution here

Preview 0

string was not recognized as a valid boolean

4 solutions

Solution 2

Solution 1

Solution 3

Solution 4

Add your solution here

Preview 0

Existing Members

...or Join us