Syntax error in UPDATE Statment

Question

0.00/5 (No votes)

See more:

My Solution for update is given below but Syntax error is given in Update Statement.
Please suggest me.

Table name is notification and its field is not declared as text and ntext declared as memo

C#

void update(Object sender, EventArgs e)
{
con.Open();
string va=d1.SelectedItem.Value;
//ta1.Value=va;
 
com=con.CreateCommand();
com.CommandText="UPDATE notification SET ntext = '" + ta1.Value.Replace("\'","\'\'") + "' where nid='" + va + "'";
//com.CommandText="UPDATE notification SET notice = '" + ta1.Value + "' where id='" + va + "'";
try{
com.ExecuteNonQuery();
System.Web.UI.WebControls.Label lbl1=new System.Web.UI.WebControls.Label();
lbl1.ForeColor=System.Drawing.Color.Yellow;
lbl1.BackColor=System.Drawing.Color.Blue;
lbl1.Text="Your record SUBMITED sucessfully";
ph1.Controls.Add(lbl1);
}
catch(Exception ex)
{
Response.Write(ex.Message);
}
con.Close();}

Posted 14-Oct-11 22:25pm

Janardan Pandey

Updated 14-Oct-11 22:33pm

André Kraak

v2

Add a Solution

Comments

hitech_s 15-Oct-11 4:33am

can u post the error what you got

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2011-10-14T22:39:00

There are a couple of things here:
The first thing you need to do is put a breakpoint on the try statement, and examine your com.CommandText to check exactly what is being sent to the SQL server. Without knowing the content of ta1 and va you are just guessing at this stage.

The other is that you really shouldn't do that at all - use Parametrized queries instead because if you don't you are leaving yourself open to accidental or deliberate SQL Inject attacks, which could damage or destroy you database.

C#

com.CommandText="UPDATE notification SET ntext = @NT where nid=@NI";
com.Parameters.AddWithValue("@NT", ta1.Value.Replace("\'","\'\'"));
com.Parameters.AddWithValue("@NI", va);

You may well find that you original problem disappears at the same time...