not getting correct output when storing textbox values

Question

0.00/5 (No votes)

See more:

I keep getting the output in messagebox as '0' for any numerical value I give in the textBox1. can you please fix my code ? Thanks

C#

public partial class MainWindow : Window
{
    public double[] average = new double[5];
}
private void button1_Click(object sender, RoutedEventArgs e)
{
    average[0] = Convert.ToDouble(textBox1.Text);
    MessageBox.Show(Convert.ToString(average[0]));
}

PS: I have also tried this.textBox1.Text, but it did not work. Could you please also explain me what 'this' keyword exactly does ? Thanks

Thanks everyone for the reply, but My objective here is not to display the value in the textbox, but to store it in an array. I am planning to store a new value in the double array everytime i click the button. I want the code to be something like this.

private button_click()
{
int i=0;
code to store the current value in the textbox into a double array[i] and probably display it on a messagebox
....
i++;
textbox1.clear();
}

Posted 9-Sep-11 0:26am

steersteer

Updated 9-Sep-11 1:33am

v5

Add a Solution

Comments

J.Karthick 9-Sep-11 6:38am

How come you build your code??

I got error like "expected enum or struct"

Your button Click event should come inside Class...You declare it outside

steersteer 9-Sep-11 7:35am

It is just a portion of my code, and no I did not define my button click method outside my mainwindow class.

5 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Herman<T>.Instance · Answer 1 · 2011-09-09T00:32:00

Solution 1

what 'this' means: http://msdn.microsoft.com/en-us/library/dk1507sz(v=vs.80).aspx[^]

you better do

C#

double mycheckDouble = 0;
if (double.TryParse(textBox1.Text, out mycheckDouble)
   MessageBox.Show(string.Format("value found {0}", mycheckDouble));
else
   MessageBox.Show("Failed to convert value to a double");

Posted 9-Sep-11 0:32am

Herman<T>.Instance

v2

Comments

Simon Bang Terkildsen 9-Sep-11 6:34am

+5 for TryParse the best way to do it, as you'll not get any exception when the input is incorrect.

Herman<T>.Instance 9-Sep-11 6:36am

exactly. Try Catching is expensive in use and avoiding try catch but having the same result is always a big win.

Pravin Patil, Mumbai 9-Sep-11 6:44am

My 5 tooo..... for the TryParse.
Most correct way to catch Data Type Level error.

steersteer 9-Sep-11 7:27am

My objective here is not to display the value in the textbox, but to store it in an array. I am planning to store a new value in the double array everytime i click the button. I want the code to be something like this.
private button_click()
{
int i=0;
code to store the current value in the textbox into a double array[i]
....
i++;
textbox1.clear();
}

steersteer 9-Sep-11 7:27am

Thanks for the reply btw.

Herman<T>.Instance 9-Sep-11 7:30am

so..average[i] = mycheckDouble;

steersteer 9-Sep-11 7:36am

okay..will try now..thanks..very kind of you.

Simon Bang Terkildsen · Answer 2 · 2011-09-09T00:33:00

Solution 2

Convert.ToDouble()[^] returns 0 when the input is null, an empty string or "0". So either you have more than one TextBox and using the wrong one or you do not change the value in your TextBox

the this is the reference to the current instance of your class. refer to the documentation this (C# Reference)[^]

Posted 9-Sep-11 0:33am

Simon Bang Terkildsen

Updated 9-Sep-11 1:49am

v2

Comments

Herman<T>.Instance 9-Sep-11 6:35am

Good link ;)

Tejas Vaishnav · Answer 3 · 2011-09-09T02:03:00

C#

public partial class MainWindow : Window
{
    public double[] average = new double[5];

    public static int i = 0;

  protected void AddToArray()
  {
      if(i != 5 && i < 5)
      {
          average[i] = Convert.TODouble(txtbox.text);
          i++;
      }
  }

}
// then call that mwthod to your button click you can write your code to stop clicking the button if it is at 5 times

Wayne Gaylard · Answer 4 · 2011-09-09T02:08:00

I would try something like this:-

C#

List<double> doubles = new List<double>();//use list rather than array - much easier

       private void button1_Click(object sender, EventArgs e)
       {
           double result;
           double.TryParse(textBox1.Text, out result);
           if (result != null)
           {
               doubles.Add(result);
               textBox1.Clear();
           }
           else
           {
               MessageBox.Show("Please enter valid number.");
           }
       }

Hope this helps

In reply to your comment, it is certainly possible to store any Class in a List<class>, something like this:-

C#

class Car
   {
       public string Make { get; set; }
       public string Model { get; set; }
   }

XML

List<Car> cars = new List<Car>();
            cars.Add(new Car(){ Make = "Nissan", Model="Sunny"});

Here[^] is the MSDN page for List<t></t>

As for storing one List for both windows, the best thing would be to have a public property in your Main window which returns a List<double></double> and to pass this as a prameter to your second form. then you just add the second forms doubles directly to your List.

Uday P.Singh · Answer 5 · 2011-09-09T00:40:00

Solution 3

I am wondering how is your code running, as you have written

C#

public double[] average = new int[5];

which should be like this:

C#

public double[] average = new double[5];

hope it helps :)

Posted 9-Sep-11 0:40am

Uday P.Singh

Comments

Herman<T>.Instance 9-Sep-11 6:51am

sharp!

Uday P.Singh 9-Sep-11 7:03am

what does it mean?

Herman<T>.Instance 9-Sep-11 7:17am

that you see very sharp he is declaring an int array to a double arra, which will lead to errors.

Uday P.Singh 9-Sep-11 7:23am

okay got it!

steersteer 9-Sep-11 7:18am

my bad. I pasted the code i had before fixing that error.

not getting correct output when storing textbox values

5 solutions

Solution 1

Solution 2

Solution 4

Solution 5

Solution 3

Add your solution here

Preview 0