All codes in constructor or using methods in constructor

Question

0.00/5 (No votes)

See more:

Hello,

I'm a newbie in programming. I'm thinking about the performance of a java program in terms of its load time,memory usage etc.

Which programming style will give better performance:

a) put every line of code into constructor for example :

JavaScript

Class abc 
{
   -component declarations-
  
   abc() //constructor
  {

    -all the codes line by line-
  }
}

b) As I want my code to look more organized, I create methods to be called in the
constructor for example:

JavaScript

Class abc
{
   -component declarations-

   abc() //constructor
  {
    method1();
    method2();

  }
}

I run the program by creating the object in the main function.
So which one will give better performance?

Thx for any help and guidance ^.^

Posted 8-Aug-11 4:41am

sazalihisham

Updated 8-Aug-11 4:59am

LittleYellowBird

v3

Add a Solution

Comments

LittleYellowBird 8-Aug-11 10:59am

Added some code blocks. :)

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

fjdiewornncalwe · Answer 1 · 2011-08-08T06:11:00

Solution 3

Always code in the way that will make code the most maintainable while still providing all the necessary functionality. Never create spaghetti code which is what you will get if you put all your code in the constructor.

Posted 8-Aug-11 6:11am

fjdiewornncalwe

Comments

Espen Harlinn 9-Aug-11 10:35am

Good advice, my 5

_Zorro_ · Answer 2 · 2011-08-08T05:09:00

I really don't think there's a "performance" difference between these two "methods"."

Anyway, it seems you're doing sequential coding, I'm not saying you shouldn't, but if you're trying to learn you maybe look into Object-oriented programming and Multitier architecture

That might be a good start.

YvesDaoust · Answer 3 · 2011-08-08T06:05:00

Obviously style (b) involves the overhead of two function calls (passing arguments and allocating local variables) and might give the compiler less opportunities for global optimizations.

In practice this overhead is often neglectable.

What really matters is indeed to achieve a correct structuring of your code for readability and maintenability.

If method1 and method2 are never used elsewhere than in the constructor and will never be, you can question the benefit to create them, except for the sake of keeping small functions.

Alternatively, you could just enclose the chunks of code in a local block {}.

All codes in constructor or using methods in constructor

3 solutions

Solution 3

Solution 1

Solution 2

Add your solution here

Preview 0