Form should not be shown after raising an error

Question

0.00/5 (No votes)

See more:

Hi all i have written the following code

MSIL

private void btnEntry_Click(object sender, EventArgs e)
        {

            if (cmbServiceClassCode.SelectedIndex == -1 || txtCompname.Text == string.Empty || txtCompidentification.Text == string.Empty
                || cmbStandardentryclasscode.SelectedIndex == -1 || txtOrgstatuscode.Text == string.Empty || txtODFIidentification.Text == string.Empty
                || txtBatchno.Text == string.Empty)
            {
                MessageBox.Show("Insufficient Data to Proceed");
                if (Convert.ToBoolean(DialogResult.OK))
                {
                    this.Show();
                }
            }

            string s = cmbStandardentryclasscode.SelectedItem.ToString();
            try
            {

                if (s == "CCD")
                {
                    frmEntryDetails frmentry = new frmEntryDetails(s);
                    frmentry.ShowDialog(this);
                }
                else
                {
                    frmEntryDetails frmentry = new frmEntryDetails(s);
                    frmentry.ShowDialog(this);
                }
            }


            catch (Exception ex)
            {

            }

        }

But if i select some value cmbStandardentryclasscode the error message is displayed but executing the remaining code. So can any one please help me.

Posted 3-Sep-10 18:56pm

demouser743

Updated 3-Sep-10 19:09pm

v2

Add a Solution

Comments

Sandeep Mewara 4-Sep-10 2:52am

What error?

demouser743 4-Sep-10 3:11am

I am not getting an error first it is executing If condition which was written first. If i have any value selected from combobox and if i left the other empty the messagebox is getting displayed and the remaining code executes. What i need is if the first if fails the second condition should not get executed

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

DaveAuld · Answer 1 · 2010-09-03T21:42:00

Do you not want the following structure then (i.e.add an else);

private void btnEntry_Click(object sender, EventArgs e)
        {
            if ( //the condition checks)
            {
                MessageBox.Show("Insufficient Data to Proceed");
                if (Convert.ToBoolean(DialogResult.OK))
                {
                    this.Show();
                }
            }
            else
            {
                string s = cmbStandardentryclasscode.SelectedItem.ToString();
                try
                {
                    //code as per existing try
                }
            
                catch (Exception ex)
                {
                }
           }
        }

demouser743 · Answer 2 · 2010-09-03T21:45:00

Ok i got the answer

Edited the code as follows

MSIL

private void btnEntry_Click(object sender, EventArgs e)
        {

            if (cmbServiceClassCode.SelectedIndex == -1 || txtCompname.Text == string.Empty || txtCompidentification.Text == string.Empty
                || cmbStandardentryclasscode.SelectedIndex == -1 || txtOrgstatuscode.Text == string.Empty || txtODFIidentification.Text == string.Empty
                || txtBatchno.Text == string.Empty)
            {
                MessageBox.Show("Insufficient Data to Proceed");
            }

            try
            {
                string s = cmbStandardentryclasscode.SelectedItem.ToString();

                if (s != null  && cmbServiceClassCode.SelectedIndex == -1 || txtCompname.Text == string.Empty
                    || txtCompidentification.Text == string.Empty || txtOrgstatuscode.Text == string.Empty || txtODFIidentification.Text == string.Empty)
                {
                    this.Show();
                }

                else
                {
                    if (s == "CCD")
                    {
                        frmEntryDetails frmentry = new frmEntryDetails(s);
                        frmentry.ShowDialog(this);
                    }
                    else
                    {
                        frmEntryDetails frmentry = new frmEntryDetails(s);
                        frmentry.ShowDialog(this);
                    }
                }
            }

            catch (Exception ex)
            {

            }
        }

Form should not be shown after raising an error

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0