Error In Map

Question

0.00/5 (No votes)

See more:

Hello

I have problem in following code:

struct node
{
    CString         Name;
    CString         Add;
    CStringArray    Str;
}

std::map<char*>link;

Above I declare a structure & map.
Then I add the element in map as follows:

struct node NODE;
CString lv_str;
GetDlgItemText(IDC_EDIT1,lv_str);
NODE.Name = lv_str;
GetDlgItemText(IDC_EDIT2,lv_str);
NODE.Add= lv_str;
NODE.Str.SetAt(0,lv_str);
link.insert(map<char*,node>::value_type("vaibhav",NODE));

It will give error as follows:

error C2679: binary '=' : no operator defined which takes a right-hand operand of type 'struct std::pair<char node="">'(or there is no acceptable conversion)

If this has any gramatical mistakes please ignore it & also if you have any other ideas to insert the item in the map please tell me.

One more thing is that if I remove str element from structure then this code works properly.

Posted 1-Sep-10 23:30pm

patilvaibhavrao

Updated 1-Sep-10 23:37pm

LittleYellowBird

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Aescleal · Answer 1 · 2010-09-02T00:27:00

Unfortunately CStringArray hasn't got a copy constuctor. Value types in a map have to be copy constructable so...

CStringArray not copy constructable
-> node not copy constructable
-> std::pair< char *, node > not copy constructable
-> error 2582!

One quick way around this problem is not to mess about with 1991 style collection classes and start using std::vector instead. It's a lot easier than all the manual iteration you have to do with MFC collections.

Cheers,

Ash

tolw · Answer 2 · 2010-09-01T23:49:00

Solution 1

Ignoring all minor errors, this is what should work:

First of all you need to specify the keytype in the map declaration like so:
std::map<char*,node>link;

After that you may wish to insert items simply by using the [] operator:

node NODE;
//Node init here
//...
//Insert item (the map entry will be created if it was not there yet)
link["vaibhav"] = NODE;

Good luck to you and please let me know if this helps!

Posted 1-Sep-10 23:49pm

tolw

Comments

patilvaibhavrao 2-Sep-10 6:07am

still their is an error

patilvaibhavrao 2-Sep-10 6:09am

error C2582: 'node' : 'operator =' function is unavailable

tolw 2-Sep-10 6:30am

Sorry - see Aescleal's answer instead - it's much better :)

patilvaibhavrao 2-Sep-10 6:34am

ok