Want move picturebox on a key press event,i have used the following coding.but,it's not working.need help.Could you tell me the correct coding?

Question

1.00/5 (1 vote)

See more:

C#

private void Form1_KeyUp(object sender, KeyEventArgs e)
        {
            if (e.KeyCode.ToString() == "Left")
                pictureBox1.Location = new Point(pictureBox1.Location.X - 20, pictureBox1.Location.Y);
            else if (e.KeyCode.ToString() == "Right")
                pictureBox1.Location = new Point(pictureBox1.Location.X + 20, pictureBox1.Location.Y);
            else if (e.KeyCode.ToString() == "Up")
                pictureBox1.Location = new Point(pictureBox1.Location.X, pictureBox1.Location.Y - 20);
            else if (e.KeyCode.ToString() == "Down")
                pictureBox1.Location = new Point(pictureBox1.Location.X, pictureBox1.Location.Y + 20);
        }

Posted 17-Jul-11 22:16pm

sreenathpktr

Updated 17-Jul-11 22:26pm

Аslam Iqbal

v2

Add a Solution

Comments

Аslam Iqbal 18-Jul-11 4:28am

what is you problem? Did you set the form property keypreview=true?

Valery Possoz 18-Jul-11 4:36am

Hello,

You could have used "if (e.KeyCode == Keys.Left)" but otherwise it is fine, this code is correct, the problem must be somewhere else.

Valery.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2011-07-17T22:30:00

First off, that isn't VB, or VB.NET. It's C#...

Secondly, don't use ToString and string comparison:

private void Form1_KeyUp(object sender, KeyEventArgs e)
        {
            if (e.KeyCode == Keys.Left)
                pictureBox1.Location = new Point(pictureBox1.Location.X - 20, pictureBox1.Location.Y);
            else if (e.KeyCode == Keys.Right)
                pictureBox1.Location = new Point(pictureBox1.Location.X + 20, pictureBox1.Location.Y);
            else if (e.KeyCode == Keys.Up)
                pictureBox1.Location = new Point(pictureBox1.Location.X, pictureBox1.Location.Y - 20);
            else if (e.KeyCode == Keys.Down)
                pictureBox1.Location = new Point(pictureBox1.Location.X, pictureBox1.Location.Y + 20);
        }

Third, the form probably won't get the KeyUp event anyway: If there is any control on your form which can take keyboard input, it will get the focus, and will get the keys instead (since it is supposed to handle keys, and the form isn't) - so will will need to handle this in the various controls, rather than at the form.

Fourth, it is more normal to handle KeyDown, or KeyPress, rather than KeyUp anyway...