C# Progressbar and Timer control

You have to call pbProg.Update().

The timer is not necessarily required. You can do this in different ways. You can use a for loop to increase the value of the progress bar.

#region Using directives
using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Windows.Forms;
namespace Progress_Bar_Example
{
    partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();
        }
        private void Form1_Load(object sender, EventArgs e)
        {
            
            //Set the Max. value the progress bar can hold to 100.

            progressBar1.Maximum = 100;
        
        }
        private void button1_Click(object sender, EventArgs e)
        {
            int value;
            for (value = 0; value != 1000; value++)
            {
                progressBar1.Value = progressBar1.Value + 1;
            }
  

        }
    }
}

This may not be the perfect way of doing it but still it works fine. There may be many other solutions. Let me know if this was helpful

--
AJ

Hi AJ

Thanks for your solution. The problem is actually here:

int percentage = (pbProg.Value / pbProg.Maximum) * 100;
          lblProg.Text = "Current progress: " + percentage.ToString() + "%";

The progressbar actually works (obviously not 100%) but while stepping through the code,
I can see what the current values for pbProg.Value and pbProg.Maximum are but "int percentage" is always zero. Can you suggest a different way of getting the percentage?

The "percentage" is represented by the pbProg.Value property. A progressbar shows 0-100% (that's why it's a "progress" bar). You're doing math on it that doesn't need to be done.

Assuming that trTick_Tick is correctly called by your timer, for sure your progress bar won't ever increment as you reset its value to 1 each time you enter in that function.

At most, the value would be 3 when you compute the percentage and as pointed out by someone else, it would help to do the multiplication before the division since you are using an integer type.

By the way, it would be fairly easy to see the problem by using the integrated debugger in Visual Studio and tracing that code line per line.

Hello, try the following... I've seen int have this problem before...

double percentage = ((double)value / (double)max) * 100);

If your initial thought on reading this is 'that can't be it'... try this simple console test...

int val = 5;
int total = 100;
int pct = (val / total) * 100;

Console.WriteLine(pct);

pct always zero... make everything double and hey... dar it goes.

You have to avoid multiplying by 0, just start with the multiply then division ... this should be work fine.

<pre lang="cs">int percentage = (pbProg.Value * 100) / pbProg.Maximum;

Good luck :).

This worked:

double percentage = ((double)value / (double)max) * 100);

Thanks