If conditional Problem

Question

1.67/5 (3 votes)

See more:

hello everyone
i am doing an if conditional to check a setting called run if it's true so show the form if it's false end the program and show a msgbox but it shows the msgbox and show the form. Can anyone tell me what's wrong with my code

If My.Settings.run = "False" Then
        MsgBox("CAN'T RUN")
        End
    ElseIf My.Settings.run = "True" Then

        'When the form loads
        'Enumerate available Com ports and add to ComboBox1
        comPorts = IO.Ports.SerialPort.GetPortNames()
        For i = 0 To UBound(comPorts)
            ComboBox1.Items.Add(comPorts(i))
        Next
        'Set ComboBox1 text to first available port
        ComboBox1.Text = ComboBox1.Items.Item(0)
        'Set SerialPort1 portname to first available port
        SerialPort1.PortName = ComboBox1.Text
        'Set remaining port attributes
        SerialPort1.BaudRate = 19200
        SerialPort1.Parity = IO.Ports.Parity.None
        SerialPort1.StopBits = IO.Ports.StopBits.One
        SerialPort1.DataBits = 8

    End If
End Sub

Thanks in Advance

Posted 11-Jul-11 5:53am

Seif Hatem

Updated 11-Jul-11 5:55am

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

S Houghtelin · Answer 1 · 2011-07-11T06:19:00

Solution 1

Assuming you have added the setting run as a boolean varaible. True or false should not be in quotes.

You do not need the ElseIf: second conditional on a boolean test, it's either true or false.

VB

If My.Settings.run = False  Then
    MsgBox("Can't Run")

Else
    'Run your code

End If

You might consider using a phrase other than "Can't Run" in your message box. It sounds unprofessional. You may consider something along the lines of “Unable to perform that action” or something more descriptive of what they are unable to do with a description of what they need to do in order to have the application run.

Regards

Posted 11-Jul-11 6:19am

S Houghtelin

Comments

Seif Hatem 11-Jul-11 12:28pm

Same error, PLease Help
<pre><pre lang="vb">If My.Settings.run = False Then
MsgBox("The lisscence has ended")
Else
'When the form loads
'Enumerate available Com ports and add to ComboBox1
comPorts = IO.Ports.SerialPort.GetPortNames()
For i = 0 To UBound(comPorts)
ComboBox1.Items.Add(comPorts(i))
Next
'Set ComboBox1 text to first available port
ComboBox1.Text = ComboBox1.Items.Item(0)
'Set SerialPort1 portname to first available port
SerialPort1.PortName = ComboBox1.Text
'Set remaining port attributes
SerialPort1.BaudRate = 19200
SerialPort1.Parity = IO.Ports.Parity.None
SerialPort1.StopBits = IO.Ports.StopBits.One
SerialPort1.DataBits = 8
End If</pre>
</pre>

S Houghtelin 11-Jul-11 12:31pm

Is the varaible a boolean variable?How is variable "run" declared? like this?

Dim run as Boolean

Seif Hatem 11-Jul-11 12:32pm

I fixed it by adding "End"
but now it gives me error wether it's true or false

Seif Hatem 11-Jul-11 12:35pm

I fixed it by adding My.settings.save()

Seif Hatem 11-Jul-11 12:36pm

Thanks for your help :)

S Houghtelin 11-Jul-11 12:37pm

Thank you, if you found this to be helpful, please mark the answer as solved.

Tarun.K.S 11-Jul-11 13:41pm

Good answer. 5+

S Houghtelin 11-Jul-11 13:49pm

Appreciated, thanks. :)

BTW, like your blog, good read. Especially the top article for saving forms settings. The Load and Save event section are relavant to the question.

Tarun.K.S 11-Jul-11 16:44pm

Thank you very much, glad you liked my blog and the article. :)
It's always great to get appreciation from top-class experienced developers like you. :)

S Houghtelin 11-Jul-11 19:02pm

I don't know if I would catagorize my self as top class, but thank you for your kind words. :) One could say the same for you.

Have you considered submitting some of your articles here on CP? I think you have a good writing style. The code is easy to follow and understandable.

Tarun.K.S 12-Jul-11 3:42am

Actually I thought my articles won´t be accepted well, so I was a bit scared posting it here.
But after reading your comments, I think I should go ahead write some! Thank you for very much for the encouragement. :)

Sergey Alexandrovich Kryukov 11-Jul-11 16:24pm

My 5, especially for patience :-)
--SA