I'm having an issue with a program I am developing.

Question

0.00/5 (No votes)

See more:

C#

namespace WindowsFormsApplication1
{
    class CheckUsername_Pass
    {
        public static string Check(string UsernameCheck, string PasswordCheck,string username, string password)
        {
            UsernameCheck = "Omega" + "omega";
            PasswordCheck = "Sweet12" + "sweet12";
 
            if (username == UsernameCheck & password == PasswordCheck)
            {
                System.Windows.Forms.MessageBox.Show("Login Successful");
            }
            else
            {
                System.Windows.Forms.MessageBox.Show("Login Failed \n Please Check The Username Or Password For Errors.");
            }
        }
    }
}

I'm trying to practice classes and just can't seem to get this working. I just recently started programming in C# a few days ago and what this class is supposed to do is to check to see if the username and password is correct. If the username and password are correct then a message box will appear stating that it is indeed correct. Otherwise a message box will appear saying that the login failed.

Posted 8-Jun-11 18:58pm

oppel175

Updated 9-Jun-11 7:20am

#realJSOP

v3

Add a Solution

4 solutions

Solution 2

I could try to solve this issue, but I think I better give you a reference where you can learn. Take a look here:

http://msdn.microsoft.com/en-us/vcsharp/aa336738[^]

There are lots of examples, tutorials, etc.
This will help you understand how things work in .NET

When reading your code I wonder what you are trying to do with these lines:

UsernameCheck = "Omega" + "omega";
PasswordCheck = "Sweet12" + "sweet12";

Perhaps your problem is solved when you delete these two lines.

Posted 8-Jun-11 19:21pm

Ruard

Comments

Monjurul Habib 9-Jun-11 14:31pm

nice links, my 5.

Solution 4

Gotta wonder why you're setting the check variables the way you are.

I think this has as much to do with learning the framework classes as anything else. If you set the check variables like so:

C#

string usernamecheck = "OMEGA";
string passwordcheck = "SWEE12";

and then do this comparison, you'll be gold:

C#

if (usernamecheck == username.ToUpper() && passwordcheck == password.ToUpper())
{
}

Also, in your original code snippet, your comparison is incorrect because you're using a single "&" character (see my example above for the correct usage).

Posted 9-Jun-11 7:26am

#realJSOP

Solution 3

Thanks guys. I appreciate your help :) I'll start smaller again and build up to this.

Posted 9-Jun-11 6:50am

oppel175

Comments

Monjurul Habib 9-Jun-11 14:20pm

This can not be an answer.please click on "Add Comment", write your desire comment then "Submit Comment".

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2011-06-08T19:16:00

So far, very bad. Let's see:

Method Check: you assign UsernameCheck and PasswordCheck to some immediate string constants. You should not use immediate constants as it's not supportable, but let's sat it's just to start the development. But at the moment of assignment that was variable holding the values of input parameters. By assigning them to something else you lost the values passed by the call.

Later on you perform the check. Use "&&" instead of "&". This is the same operation, but you should really use "&&" for optimization. As a Boolean operation, "&" should be used only when operands cause side effect, to avoid this side effect to be optimized out.

Now, as first two parameters of Check are ignored, the result of comparison depends only on username and password.

Always run code under debugger to see what's going on. The problems of unexpected behavior like this one will disappear. Just a note: you don't really practice OOP yet. There will be virtual functions, inheritance and late binding when real things start. You're confused with elementary things already. I would advice you to slow down and develop just simplest exercise, don't try to make real application — just yet. It will come soon.

Good luck,

—SA