Class can not receive picturebox as an argument

Question

1.00/5 (1 vote)

See more:

Hello
Program1 sends pictureBox1 to MyClass to show cat.jpg,i have also tried to use sender and casted to PictureBox
but did not works thank you in advance

What I have tried:

     public class MyClass
     {
            public Thread MyThread;
            private PictureBox ClassPictureBox1 = new PictureBox();
            private void Delay()
            {
                //ClassPictureBox1.Image = (PictureBox)Image.FromFile(NameDefinedInProgram1);
                ClassPictureBox1.Image = Image.FromFile("cat.jpg");//<== Error Line C
                Thread.Sleep(5000);
            }
        }

        public MyClass(Object Sender ,  PictureBox XpictureBox1)//,NameDefinedInProgram1)
        {
            ClassPictureBox = (PictureBox)Sender;//<== still did not works Line A
            //ClassPictureBox1 = XpictureBox1;//<=== did not works//line B
            MyThread = new Thread(this.Delay);
            MyThread.Name = Name;
            MyThread.Start();
        }
    }//MyClass
//---Below is method in program1
    private void RunThreadClick(object sender, EventArgs e)//<==the event is made from pictureBox not from button
    {
        MyClass Obj1 = new MyClass(sender, pictureBox1);
        if (Obj1.MyThread.IsAlive == false) Obj1.MyThread.Abort();
    }

Posted 22-Jan-22 19:41pm

Engineer khalid

Updated 22-Jan-22 21:30pm

v4

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2022-01-22T20:03:00

OK, let's start with the basics of Event handling.

When an event is raised by (for example) a button click, the system calls the handler method and passes it two parameters: sender which is an object, and e which is always derived from EventArgs. The former is the class instance that raised the event (the Button the user clicked) and the latter is information about the actual Click.
So in a mouse event like MouseDown, you would get the Control that the user was over when they press the mouse button as the sender and e would be a MouseEventArgs instance (which derived from EventArgs and contains more info) telling you which button(s) and where on the COntrol it was clicked.

You can't just cast either of those parameters to a "different type" unless they actually started out as that type (or something derived from it) - so

ClassPictureBox = (PictureBox)Sender;

will fail unless sender is a PictureBox.
But your RunThreadClick probably doesn't get called from a PictureBiox event - it's a lot more likely to have a Task, or Thread based object as it's sender so that it can "refer back" to that if it needs to report some progress for example. And since that isn;t derived from any Control, you definitely can't try to cast it to a PictureBox.

Your whole code looks like it was thrown together in panic - there isn't a lot there that looks like it was thought about and planned in advance.
Your class can't "show a picturebox" - it's not derived from Control, so it can't display anything, and if it's being executed on a thread other than the main thread it can't access any displayable Controls.

Why are you throwing PictureBoxes around anyway? Why not just pass the Image instead, and cut out the middleman?

Plus, when you call Image.FromFile, the source file is locked by the system so that it can't be accessed again until the Image you created from it has been Disposed - and I'm guessing that that doesn't happen until your app closes!

I'd strongly suggest that you need to throw that code away, sit down and think about exactly what you are trying to do, then plan what you need instead of rushing straight into code = it'll save you a lot of time in the long run!