How do I run bubble sort in C++

Question

1.00/5 (1 vote)

See more:

I'm using visual studio as ide. It's telling me to write arr as std::array

#

What I have tried:

C++

include<iostream>
using namespace std;


int main()
{
    int n;
    cin >> n;
    
    for (int i = 0; i < n; i++) {
        cin >> arr[i];
    }

    int counter=1;
    while (counter < n) {
        for (int i = 0; i < counter - 1; i++) {
            if (array[i] > array[i + 1]) {
                int temp = arr[i];
                arr[i] = arr[i + 1];
                arr[i + 1] = temp;

            }

        }
        counter++;

    }
    for int(i = 0; i < n; i++) {
        cout << arr[i] << " ";
    }cout << endl;
    
}

Posted 21-Oct-21 0:32am

NIPUN GAHANE

Updated 21-Oct-21 12:37pm

Nelek

v2

Add a Solution

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Answer 1 · 2021-10-21T00:57:00

C++

include<iostream>
using namespace std;


int main()
{
    int n;
    cin >> n;
    
    // here, you have to say that 'arr' is an array of size n
    for (int i = 0; i < n; i++) {
        cin >> arr[i];
    }

    int counter=1;
    while (counter < n) {
        for (int i = 0; i < counter - 1; i++) {
            if (array[i] > array[i + 1]) {
                int temp = arr[i];
                arr[i] = arr[i + 1];
                arr[i + 1] = temp;

            }

        }
        counter++;

    }
    for int(i = 0; i < n; i++) {
        cout << arr[i] << " ";
    }cout << endl;
    
}

KarstenK · Answer 2 · 2021-10-21T01:59:00

Solution 2

A bit more UI would help you understand the missing parts of your code.

C++

int main()
{
    "enter the count of elements" >> cout;
    int n, x;

    cin >> n;
    
    for (int i = 0; i < n; i++) {
    "enter element ">> std::to_string(i) >> cout;
        cin >> x;
        arr.push_back(x);
    }

Posted 21-Oct-21 1:59am

KarstenK

Comments

merano99 21-Oct-21 17:54pm

Why not use

cout << "Enter element " << i << "\n";

Definition of arr is a problem here. In Your Solution this is not solved and
you missed to tell.

Rick York · Answer 3 · 2021-10-21T05:03:00

Solution 3

I think it is telling you that arr is undefined because I don't see a declaration of it anywhere.

Posted 21-Oct-21 5:03am

Rick York

merano99 · Answer 4 · 2021-10-21T12:37:00

There are several issues in your Code

First: You missed to show the user what values he shoud enter.
And you also do no range check.

Second: You missed to declare and allocate space for arr.
You could use a vector of size (n) here.

Third: Your bubblesort does not work correct.
On Wikipedia you can find pseudocode which in C ++ gives something like this:

C++

// wikipedia: bubbleSort(Array arr)
	for (int c=arr.size(); c>1; --c) {
		for (int i=0; i<c-1; ++i) {
			if (arr[i] > arr[i+1]) {
				swap(arr[i], arr[i+1]);
			} // end if
		} // end inner for
	} // ende outer for

How do I run bubble sort in C++

4 solutions

Solution 1

Solution 2

Solution 3

Solution 4

Add your solution here

Preview 0