Click here to Skip to main content
15,881,882 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
#include<iostream>
using namespace std;
void bubble_sort(int array[], int n){
for (int i= 0; i < n-1; i++) {
for (int j = 0; j < n-1-i ; j++) {
  if (array[j] > array[j+1]) {
    int temp = array[j];
    array[j]= array[j+1];
    array[j+1] = temp;
  }
}
}
}
void print(int array[], int n){
  for (int i = 0; i < n-1; i++) {
  cout<<array[i]<<" ";
  }
  cout<<endl;
}
int main(int argc, char const *argv[]) {
  int n;
  cin>>n;

  int array[100];
for (int i = 0; i < n; i++) {
  cin>>n;
}//to take input for array;

  bubble_sort(array, n);
        print(array,n);

  return 0;
}


What I have tried:

I have tried using bubble sorting to sort an array .
Posted
Updated 26-Jul-21 4:44am
Comments
CHill60 26-Jul-21 7:44am    
Use the "Improve question" link to add details of your inputs and what your expected output(s) was/were and what your actual output was
Peter_in_2780 26-Jul-21 7:49am    
Pretend you are the computer. Get a few playing cards, say Ace to 5. Lay them out in random order the follow your code line by line. You can use pencil and paper for i, j, n etc. You'll soon figure out where your problem is.

C++
  cin>>n; 

  int array[100];
for (int i = 0; i < n; i++) {
  cin>>n; <-- what is this supposed to do???
}//to take input for array;
 
Share this answer
 
Comments
Greg Utas 26-Jul-21 13:48pm    
5. LOL. Totally missed that. If that's only bug, it's a howler.
Richard MacCutchan 27-Jul-21 3:54am    
I only spotted it by running the code.
Before we get to the bug, pretend that someone else is using your program. How would they know what to input? It would be good to use cin, right at beginning, to say that your program will sort n numbers, and then to print "Enter n: ", followed by "Sorting..." when n numbers have been entered.

It's very unlikely that anyone here will debug your code for you. If they see a glaring error, they'll point it out, otherwise they'll tell you to learn how to use a breakpoint debugger (or debug it manually if you don't want to learn, like Peter suggested).

Your code generally looks reasonable. Does it print n numbers, just not sorted? If so, the problem must be in your sort function. The three lines that swap two numbers look good, so the only possible place where you can have a problem is in your iteration: the two for statements. So concentrate on those and see if they make sense. Another possibility would be that the swap logic is correct but the indices for it are wrong.
 
Share this answer
 
Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
C#
int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!
 
Share this answer
 
Advice: Learn to indent properly your code, it show its structure and it helps reading and understanding. It also helps spotting structures mistakes.
C++
#include<iostream>
using namespace std;
void bubble_sort(int array[], int n){
	for (int i= 0; i < n-1; i++) {
		for (int j = 0; j < n-1-i ; j++) {
			if (array[j] > array[j+1]) {
				int temp = array[j];
				array[j]= array[j+1];
				array[j+1] = temp;
			}
		}
	}
}
void print(int array[], int n){
	for (int i = 0; i < n-1; i++) {
		cout<<array[i]<<" ";
	}
	cout<<endl;
}
int main(int argc, char const *argv[]) {
	int n;
	cin>>n;

	int array[100];
	for (int i = 0; i < n; i++) {
		cin>>n;
	}//to take input for array;

	bubble_sort(array, n);
	print(array,n);

	return 0;
}

Professional programmer's editors have this feature and others ones such as parenthesis matching and syntax highlighting.
Notepad++ Home[^]
ultraedit[^]
 
Share this answer
 

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900