Is my code thread safe by using parallel.invoke

Question

0.00/5 (No votes)

See more:

We have created a DotNet Core Windows Service where we are performing a scheduled tasks to create CSV files returned from database results.

We have implemented

Parallel.Invoke

with a

MaxDegreeOfParallelism

set to 3. I want to check whether my piece of code is thread safe or not.

I have invoked method

WriteListToFtp

with different parameters in parallel which fetches the data from database using Dapper to an IEnumerable result.

Can anyone help me know if the use of Parallel.Invoke will create a non thread safety scenario, as while testing all the results are returned correctly without any non thread safe exceptions.

What I have tried:

Parallel.Invoke(5,
                                () => { WriteListToFtp("SPExp_GetCountriesAll", "FLGetCountriesAll"); },
                                () => { WriteListToFtp("SPExp_GetStatesAll", "FLGetStatesAll"); },
                                () => { WriteListToFtp("SPExp_GetCitiesAll", "FLGetCitiesAll"); },
                                () => { WriteListToFtp("SPExp_GetTownsAll", "FLGetTownsAll"); },
                                () => { WriteListToFtp("SPExp_GetSendersTypeOfIdAll", "FLGetSenderStypeOfIdAll"); }                             
                           );

/// <summary>
        /// Method to fetch the results and write it to FTP.
        /// </summary>
        /// <param name="storedProcedure"></param>
        /// <param name="csvName"></param>
        /// <param name="parameters"></param>
        private void WriteListToFtp(string storedProcedure, string filename)
        {
            try
            {
                IEnumerable<dynamic> results = _primaryDBUtility.ExecuteQuery(null, storedProcedure);
                if (results != null && results.Count() > 0)
                {
                    _processCSV.IEnumerableToCSV(results, _srcFtpFilePath, _destFtpFilePath, filename);
                }
            }
            catch (Exception ex)
            {
                throw new Exception($"The job failed. Task: CatalogExport | FileName: {filename} | Error: {ex.Message}");
            }
        }

Posted 13-Jan-20 1:54am

Neetesh_Ch

Add a Solution

Comments

Kornfeld Eliyahu Peter 13-Jan-20 8:41am

Parallel.Invoke itself has nothing to do with thread safety... You have to check the classes/methods you are using inside it...

Neetesh_Ch 13-Jan-20 12:34pm

Yes, you are right but the way I have implemented Parallel.Invoke, will the method which is being called in concurrent thread will break parallel execution ?

Kornfeld Eliyahu Peter 13-Jan-20 13:34pm

So you actually ask if the methods will run parallel in real?
I see no reason not to - except that I'm not sure you defined the method properly... It should be static so Invoke would find and execute...
An other point is the _ parameters (like _primaryDBUtility), they must be thread safe to access them without problem...

Neetesh_Ch 14-Jan-20 0:12am

Below is the method which would be called in parallel threads.

public IEnumerable<dynamic> ExecuteQuery(object listParameters, string storedProcedure)
{
IEnumerable<dynamic> results = null;

using (IDbConnection conn = new SqlConnection(connectionString))
{
results = conn.Query(sql: storedProcedure, param: listParameters, commandType: CommandType.StoredProcedure);
}

return results;
}

Could you please help me if this method should be made thread safe and if yes, which is the best way to implement thread safe. Most of the articles on internet suggest to use Lock, but my question is if lock is used then the next threads will be stopped before the thread which is holding the resources has completed with its use. If this is the case then what is the use of invoking parallel threads if each threads has to wait for their turn to execute.

Kornfeld Eliyahu Peter 14-Jan-20 1:56am

https://docs.microsoft.com/en-us/dotnet/framework/data/adonet/asynchronous-programming?view=netframework-4.8

Neetesh_Ch 14-Jan-20 4:20am

Thanks for your help, this will help me.

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)