Browse Button save in textBox

Question

0.00/5 (No votes)

See more:

Hi all,
I will give you a scenario could you tell me if what would likely be the problem.

Scenario:
I have a tool and it has two(2) Browse Button and two(2) textBox named as BrowseButton1, textBox1, BrowseButton2 and textBox2. Now, If I click BrowseButton1 the dialog box appears and then I will chose a file then it will save on textBox1 and then when I click BrowseButton2 and then choose a file it will be save on textBox2 but the problem is after clicking BrowseButton2 it will overwrite the data on BrowseButton1.

Could tell me what's the problem with this?

Code provided by OP:

C#

private void browseTranslationRequest_Click(object sender, EventArgs e)
        {

            openFileDialog.Filter = "Excel Files | *.xls;";
            openFileDialog.ShowDialog();

            textBox1.Text = openFileDialog.FileName;
        }

        private void browseTranslationDictionary_Click(object sender, EventArgs e)
        {

            openFileDialog.Filter = "Excel Files | *.xls;";
            openFileDialog.ShowDialog();

            textBox2.Text = openFileDialog.FileName;
        }

        private void runButton_Click(object sender, EventArgs e)
        {

            if (textBox1.Text == "")
            {
                MessageBox.Show("Please Enter a Translation Request File.");
            }
            else if (textBox2.Text == "")
            {
                MessageBox.Show("Please Enter a Translation Dictionary.");
            }
            else
            {
                if (ExcelObject != null)
                {
                    ExcelObject.CloseXlsInstance();
                    p.Close();
                }


                foreach (String TheFileNamePlusPath in openFileDialog.FileNames)
               {
                   runProcess(TheFileNamePlusPath);
               }
            }
        }

Thanks!
-pao :3

Posted 15-May-11 21:34pm

jcosep

Updated 16-May-11 0:07am

Nithin Sundar

v2

Add a Solution

Comments

Sergey Alexandrovich Kryukov 16-May-11 3:40am

What are the types of all those BrowseButton1, textBox1, etc.?
And I cannot see a problem. After all, run your code under debugger to see what's going on.
--SA

jcosep 16-May-11 3:44am

What do you mean types sir?
Exactly sir, after I ran the debugger I notice that the file/data save on textBox1 will be overwrited by the file/data on textBox2.

Sergey Alexandrovich Kryukov 16-May-11 4:40am

All variables have types. How come you cannot understand what am I asking about?
"textBox" only suggests its type is "TextBox", but it can be anything... and from what library? there are different types under this name, for your information. Just tell us the types. And make some code sample (simplified as much as possible) to show the problem.

Under debugger... if you used it properly you would see what line of code change what... The problem looks very simple, you just need to present it clearly.
--SA

jcosep 16-May-11 4:48am

private void browseTranslationRequest_Click(object sender, EventArgs e)
{

openFileDialog.Filter = "Excel Files | *.xls;";
openFileDialog.ShowDialog();

textBox1.Text = openFileDialog.FileName;
}

private void browseTranslationDictionary_Click(object sender, EventArgs e)
{

openFileDialog.Filter = "Excel Files | *.xls;";
openFileDialog.ShowDialog();

textBox2.Text = openFileDialog.FileName;
}

private void runButton_Click(object sender, EventArgs e)
{

if (textBox1.Text == "")
{
MessageBox.Show("Please Enter a Translation Request File.");
}
else if (textBox2.Text == "")
{
MessageBox.Show("Please Enter a Translation Dictionary.");
}
else
{
if (ExcelObject != null)
{
ExcelObject.CloseXlsInstance();
p.Close();
}

foreach (String TheFileNamePlusPath in openFileDialog.FileNames)
{
runProcess(TheFileNamePlusPath);
}
}
}

Sergey Alexandrovich Kryukov 16-May-11 4:59am

Excuse me, how can you ask question about BrowseButton1, BrowseButton2 if these identifiers are not even shown in your code. What's the point to show it?
--SA

Sergey Alexandrovich Kryukov 16-May-11 4:52am

Sorry, it's not so readable. Will you move is to question via "Improve question" where you can use it inside the tag <pre lang="cs"></pre>?
--SA

Nithin Sundar 16-May-11 6:10am

I think that the Event Handlers are what he has posted. According to him, BrowseButton1 and TextBox1 work together and it goes the same way for BrowseButton2 and TextBox2.

What I'm thinking here is that TranslationRequest is Button1 and TranslationDictionary is Button2.

He should have posted the actual names than generic names.

Sergey Alexandrovich Kryukov 16-May-11 6:26am

A lot of relevant code is missing. Where are the instances consuming events? Types of all relevant instances?...
--SA

Nithin Sundar 16-May-11 6:30am

Yeah that's what might be causing the problem. One thing is the instance of openFileDialog might be causing the problem and what's surprising is that the OP isn't even checking whether the user clicks OK or Cancel on the dialog.

charles henington 16-May-11 16:50pm

I see also that he set the openfileDialog's Filename to textbox1 and again the filename to textbox2 but in the foreach method he calls openFileDialog's FileNames. I think he expects that each time the filename of the openfiledialog is used that it is to add a new filename as if it were a List<String> or an array

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Hemant__Sharma · Accepted Answer · 2011-05-16T01:29:00

Hello @jcosep,

Well this is what i've understood:

1- you have two buttons to browse and 2 textboxes to show the file name you have selected with respective button.

2- And then you have some "Run Process" type of button and on click of this button you want to process all the files selected in the above textboxes.

Well the problem is in your foreach loop you are referring openFileDialog instance, which i believe, is global, hence whatever button you will click in last will overwrite its FileNames property. Instead you should use the values in the textboxes:

C#

foreach (String TheFileNamePlusPath in openFileDialog.FileNames)
{
    runProcess(TheFileNamePlusPath);
}

replace with (i.e. no foreach loop)

C#

runProcess(textbox1.Text);
runProcess(textbox2.Text);

Hope it will help.

Thanks,
Hemant