Tell the error in the program please?

Question

1.00/5 (1 vote)

See more:

Write a program to enter the numbers till the user wants and at the end it should display the count of positive, negative and zeros entered.
In my program the compiler is not asking for y/n and just telling the number of positive, negative and zeroes. Is it that scanf is not being executed or there is some predefined value of choice?

What I have tried:

C++

#include <stdio.h>

int main()
{
    int number, positive = 0, negative = 0, zero = 0;
    char choice;

    do
    {
        printf("Enter a number :");
        scanf("%d", &number);

        if (number > 0)
        {
            positive++;
        }
        else if (number < 0)
        {
            negative++;
        }
        else
        {
            zero++;
        }

        printf("Do you want to Continue(y/n)? ");
        scanf("%c", &choice);

    }while (choice == 'y');


    printf("\nPositive Numbers :%d\nNegative Numbers :%d\nZero Numbers :%d",
        positive, negative, zero);


    return 0;
}

Posted 17-Oct-18 3:19am

Member 14023140

Updated 17-Oct-18 10:06am

Kornfeld Eliyahu Peter

v2

Add a Solution

2 solutions

Solution 2

Quote:
In my program the compiler is not asking for y/n

The compiler don't ask user input because it is not its job.
The compiler compile your source code, it means that it check that source code is correct C code syntax. if correct, it generate an executable, the executable is the one that do what is in your source code. This does not mean the the executable will do what you expect.
"The cat fly high in the sky." is correct English grammar, but means nothing because cats don't fly.
The good news is that the debugger allow you to watch what is going on in the executable, it is a great learning tool.

Your code do not behave the way you expect, or you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your code is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

The downside of this solution:
- It is a DIY, you are the one tracking the problem and finding its roots, which lead to the solution.
The upside of this solution:
- It is also a great learning tool because it show you reality and you can see which expectation match reality.

secondary effects
- Your will be proud of finding bugs yourself.
- Your learning skills will improve.

You should find pretty quickly what is wrong.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]
1.11 — Debugging your program (stepping and breakpoints) | Learn C++[^]
The debugger is here to only show you what your code is doing and your task is to compare with what it should do.

Posted 17-Oct-18 10:07am

Patrice T

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Accepted Answer · 2018-10-17T03:42:00

Solution 1

Add the following line before you ask if they want to continue thus:

C++

// clear the input buffer
fseek(stdin, 0, SEEK_END);

printf("Do you want to Continue(y/n)? ");
scanf("%c", &choice);

Posted 17-Oct-18 3:42am

Richard MacCutchan

Comments

Kornfeld Eliyahu Peter 17-Oct-18 9:56am

Just to make it more clear...
The new-line char from the previous input (the enter key you hit) is still in the buffer after the number, and waiting to be read...

https://gsamaras.wordpress.com/code/caution-when-reading-char-with-scanf-c/

Richard MacCutchan 17-Oct-18 9:57am

Thanks. Now what is all this about a goose crossing a lake?

Kornfeld Eliyahu Peter 17-Oct-18 9:59am

I can explain you that only if you speak VB.NET fluently...

Richard MacCutchan 17-Oct-18 10:03am

:laugh:
Çok teşekkur ederim.

CPallini 17-Oct-18 10:55am

5.

Richard MacCutchan 17-Oct-18 11:53am

Thanks, I seem to get more points for using Google and fixing scanf than for anything else.

CPallini 17-Oct-18 13:04pm

scanf is important. :-)