Click here to Skip to main content
15,884,099 members

Comments by John Brett (Top 19 by date)

John Brett 14-Apr-14 12:02pm View    
Reason for my vote of 2 \n There are too many better articles on Codeproject already on this subject to rate it well.
What we need are more articles on why not to use singletons.
John Brett 23-Oct-13 11:41am View    
Reason for my vote of 2 \n In fairness, the code does illustrate how to use the engine - sort of.
The basic idea has merit, but more explanation is needed, even for a tip.
John Brett 25-Jul-13 7:29am View    
Reason for my vote of 3 \n I'm not sure what advantages this tip/code library brings.
There are plenty of other examples of logging, many showing good coding practice. This doesn't appear to demonstrate any notable features.
This library, for example, spectacularly fails to demonstrate good OO design and separation of concern (by hard-coding the file, console and db output types).
John
John Brett 7-Feb-13 5:04am View    
Reason for my vote of 1 \n An impressive case of missing the point.

The example you give has, as its foundation, the lack of a suitable way of declaring an appropriate constraint that the types should support arithmetic operations. Since these are defined as static methods of the class, you can't express the constraint in terms of an interface.

Any code that switches on the type of object passed in is, IMHO, a seminal example of not understanding OOD.

John
John Brett 21-Jan-13 4:56am View    
Reason for my vote of 3 \n Showing async code that uses Sleep statements for thread synchronisation is not a great example.