Click here to Skip to main content
15,867,308 members

The Weird and The Wonderful

   

The Weird and The Wonderful forum is a place to post Coding Horrors, Worst Practices, and the occasional flash of brilliance.

We all come across code that simply boggles the mind. Lazy kludges, embarrassing mistakes, horrid workarounds and developers just not quite getting it. And then somedays we come across - or write - the truly sublime.

Post your Best, your worst, and your most interesting. But please - no programming questions . This forum is purely for amusement and discussions on code snippets. All actual programming questions will be removed.

 
GeneralRe: Cuter by the day.... Pin
Super Lloyd7-Jan-22 20:32
Super Lloyd7-Jan-22 20:32 
GeneralThis is actually cleaned up! Pin
honey the codewitch14-Dec-21 17:58
mvahoney the codewitch14-Dec-21 17:58 
GeneralRe: This is actually cleaned up! Pin
11917640 Member 14-Dec-21 21:49
11917640 Member 14-Dec-21 21:49 
GeneralRe: This is actually cleaned up! Pin
honey the codewitch15-Dec-21 1:43
mvahoney the codewitch15-Dec-21 1:43 
GeneralRe: This is actually cleaned up! Pin
Slacker00715-Dec-21 7:58
professionalSlacker00715-Dec-21 7:58 
GeneralRe: This is actually cleaned up! Pin
honey the codewitch15-Dec-21 9:17
mvahoney the codewitch15-Dec-21 9:17 
GeneralRe: This is actually cleaned up! Pin
Rick York15-Dec-21 6:30
mveRick York15-Dec-21 6:30 
GeneralRe: This is actually cleaned up! Pin
honey the codewitch15-Dec-21 6:38
mvahoney the codewitch15-Dec-21 6:38 
Yes, it is. There's a comment to that effect the *first* time I do it in the code.

I don't believe the results are cleaner. For starters, you should have seen the nested #ifdefs it took to do this.

Second, the preprocessor method of doing this suffered from a serious design difficiency.

You couldn't use multiple static "instances" of that to drive multiple buses, which is a problem when you have a device that runs more than one display, or even more than one SPI device (doesn't apply to the parallel code but in principle it could)

Everything defined in this code is inside a template, meaning the statics are one-per-instantiation and the arguments to the template are the pin assignments. Ergo, for each different collection of pins tied to a bus, you have a different set of statics to work with, meaning you can drive multiple displays.

I'd also argue this is cleaner because it's all typed, whereas the preprocessor macros are not. That matters for more than safety. These days it also means better intellisense/autocomplete, which means more productive mucking about with the source.
Real programmers use butterflies

GeneralRe: This is actually cleaned up! Pin
Rick York15-Dec-21 6:55
mveRick York15-Dec-21 6:55 
GeneralRe: This is actually cleaned up! Pin
honey the codewitch15-Dec-21 6:58
mvahoney the codewitch15-Dec-21 6:58 
GeneralRe: This is actually cleaned up! Pin
jschell23-Jan-22 8:54
jschell23-Jan-22 8:54 
GeneralRe: This is actually cleaned up! Pin
honey the codewitch24-Jan-22 1:00
mvahoney the codewitch24-Jan-22 1:00 
GeneralRe: This is actually cleaned up! Pin
jschell30-Jan-22 6:13
jschell30-Jan-22 6:13 
GeneralRe: This is actually cleaned up! Pin
honey the codewitch30-Jan-22 9:02
mvahoney the codewitch30-Jan-22 9:02 
GeneralRe: This is actually cleaned up! Pin
jschell17-Feb-22 10:33
jschell17-Feb-22 10:33 
JokeRe: This is actually cleaned up! Pin
Nelek15-Dec-21 10:59
protectorNelek15-Dec-21 10:59 
GeneralRe: This is actually cleaned up! Pin
Fueled By Decaff15-Dec-21 6:30
Fueled By Decaff15-Dec-21 6:30 
GeneralRe: This is actually cleaned up! Pin
honey the codewitch15-Dec-21 6:32
mvahoney the codewitch15-Dec-21 6:32 
GeneralRe: This is actually cleaned up! Pin
Al_Brown31-Dec-21 1:44
Al_Brown31-Dec-21 1:44 
GeneralRe: This is actually cleaned up! Pin
honey the codewitch31-Dec-21 3:14
mvahoney the codewitch31-Dec-21 3:14 
GeneralRe: This is actually cleaned up! Pin
Al_Brown31-Dec-21 4:38
Al_Brown31-Dec-21 4:38 
GeneralMessage Closed Pin
13-Dec-21 14:55
mvahoney the codewitch13-Dec-21 14:55 
GeneralRe: IME, It's a lot harder to shop for people when they get pregnant Pin
Brisingr Aerowing13-Dec-21 15:01
professionalBrisingr Aerowing13-Dec-21 15:01 
GeneralRe: IME, It's a lot harder to shop for people when they get pregnant Pin
honey the codewitch13-Dec-21 15:06
mvahoney the codewitch13-Dec-21 15:06 
GeneralI'm not sure how I feel about Forth implemented on a Cortex M-0 Pin
honey the codewitch13-Dec-21 0:09
mvahoney the codewitch13-Dec-21 0:09 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.