|
Is nothing saved, or just not the changes?
Microsoft MVP, Visual C#
My Articles
|
|
|
|
|
i found the solution, nothing was saved. The problem was that the dataset was not declared public
Stupid mistake 
|
|
|
|
|
The DataSet doesn't have to be declared public if its in the same class as the code that's trying to access it. It can be private. Calling methods on the object is not affected by its access modifiers, only accessing the object is dictated by its access modifiers. So, if your button1_Click event handlers was in a different class and you tried to access a privately declared ds from another class, that would be a problem.
Access modifiers only have to do which whether or not objects can be access just within a class (private), by derivative classes (protected), by all classes (public), by classes defined in the same assembly (internal), and either derivative classes or classes defined in the same assembly (protected internal).
Microsoft MVP, Visual C#
My Articles
|
|
|
|
|
Hi,
Sorry for bringing this again, but I'm having a little problem with C# and Interop.
I want to use mciSendCommand function and a few structures associated with it in C#. I'm declaring this:
<br />
private static UInt32 MCI_OPEN = 0x0803;<br />
private static UInt32 MCI_CLOSE = 0x0804;<br />
<br />
private static ulong MCI_OPEN_SHAREABLE = 0x00000100L;<br />
private static ulong MCI_OPEN_ELEMENT = 0x00000200L;<br />
private static ulong MCI_OPEN_ALIAS = 0x00000400L;<br />
private static ulong MCI_OPEN_ELEMENT_ID = 0x00000800L;<br />
private static ulong MCI_OPEN_TYPE_ID = 0x00001000L;<br />
private static ulong MCI_OPEN_TYPE = 0x00002000L;<br />
<br />
[StructLayout(LayoutKind.Sequential)]<br />
internal class MCI_OPEN_PARMS<br />
{<br />
public UInt32 dwCallback; <br />
public UInt32 wDeviceID; <br />
[MarshalAs(UnmanagedType.LPStr)]<br />
public String lpstrDeviceType;<br />
[MarshalAs(UnmanagedType.LPStr)]<br />
public String lpstrElementName; <br />
[MarshalAs(UnmanagedType.LPStr)]<br />
public String lpstrAlias; <br />
}<br />
<br />
[DllImportAttribute("Winmm.dll")]<br />
protected extern static UInt32 mciSendCommand(UInt32 IDDevice, UInt32 uMsg, ulong fdwCommand, [Out] IntPtr dwParam);<br />
And the I use that like this:
<br />
MCI_OPEN_PARMS openParms = new MCI_OPEN_PARMS();<br />
<br />
openParms.lpstrDeviceType = "cdaudio";<br />
openParms.lpstrElementName = "F:\"<br />
<br />
IntPtr ptr = Marshal.AllocHGlobal(Marshal.SizeOf(openParms));<br />
Marshal.StructureToPtr(openParms, ptr, false);<br />
<br />
error = mciSendCommand(0, MCI_OPEN, MCI_OPEN_SHAREABLE | MCI_OPEN_TYPE | MCI_OPEN_ELEMENT, ptr);<br />
When mciSendCommand executes one exception is thrown with the following message: "Object Reference not set to an instance of an object."
I think the problem is in ptr variable, maybe because it's where the function returns it's data.
What am I doing wrong?
I'm sorry for this long topic.
Thanks,
Pedro
|
|
|
|
|
DrGreen wrote:
[DllImportAttribute("Winmm.dll")]
protected extern static UInt32 mciSendCommand(UInt32 IDDevice, UInt32 uMsg, ulong fdwCommand, [Out] IntPtr dwParam);
And the I use that like this:
MCI_OPEN_PARMS openParms = new MCI_OPEN_PARMS();
openParms.lpstrDeviceType = "cdaudio";
openParms.lpstrElementName = "F:\"
IntPtr ptr = Marshal.AllocHGlobal(Marshal.SizeOf(openParms));
Marshal.StructureToPtr(openParms, ptr, false);
error = mciSendCommand(0, MCI_OPEN, MCI_OPEN_SHAREABLE | MCI_OPEN_TYPE | MCI_OPEN_ELEMENT, ptr);
The first thing I noticed is that you never defined 'ptr', at least in the code sample you provided. I think you need to add a one little line to the code you posted:
MCI_OPEN_PARMS openParms = new MCI_OPEN_PARMS();
IntPtr ptr;
openParms.lpstrDeviceType = "cdaudio";
openParms.lpstrElementName = "F:\"
IntPtr ptr = Marshal.AllocHGlobal(Marshal.SizeOf(openParms));
Marshal.StructureToPtr(openParms, ptr, false);
error = mciSendCommand(0, MCI_OPEN, MCI_OPEN_SHAREABLE | MCI_OPEN_TYPE | MCI_OPEN_ELEMENT, ptr);
RageInTheMachine9532
|
|
|
|
|
Hi Dave, thanks for your awnser.
I define ptr just before I assign the value returned from Marshal.AllocHGlobal to it: IntPtr ptr = Marshal.AllocHGlobal(Marshal.SizeOf(openParms));
I put it there to save some lines in my message.
I also tried to Marshal back the ptr into another instance of MCI_OPEN_PARMS to check if the mashal was going wrong, but no, after I do:
<br />
MCI_OPEN_PARMS temp = new MCI_OPEN_PARMS();<br />
Marshal.PtrToStructure(ptr, temp)<br />
I got the same values in temp, so there is no problem with the marshal (I think... )
Any idea?
Thanks
|
|
|
|
|
 Missed that! I guess that's what I get for trying to write code while drugged up... 
In that case, I can't see what's going wrong with the code. Sorry!
RageInTheMachine9532
|
|
|
|
|
Try passing true to Marshal.STructureToPtr to make sure any possible existing structure is destroyed, otherwise this leads to memory leaks.
Also, a few things about CLS-compliance. Don't use unsigned types if you hope to port your code ever. You can use the signed types and marshal them as unsigned types, using UnmanagedType.U4 for an Int32, for example. Yo also don't need to use "Attribute" when attributing members - it's implied.
Other than that, there's nothing else that could be null except your string members in MCI_OPEN_PARAMS, the last of which is optional according to the documentation. Everything else besides the IntPtr is a value type, which can't be null.
Microsoft MVP, Visual C#
My Articles
|
|
|
|
|
Hello Heath,
I've already tried to do do that (pass true to Marshal.STructureToPtr).
Unfortunately, the problem persists, and when I pass true, the program crashes when it ends (JIT Dialog appears). It's strange... 
I'm start to thinking the problem is in those Marshal functions.
|
|
|
|
|
Nope. I use them all the time. Interop in .NET is what I focus on primarily, just see my article on Java/.NET interop without using web services or remoting, right in the presentation layer.
So true is bad in this case (it would be necessary for repeat calls using the same allocated memory).
One thing, the DWORD_PTR should be an IntPtr, which gets marshalled as a UnmanagedType.SysInt automatically by the CLR. A DWORD_PTR uses the same bit-length as an integer on the target platform, i.e. 32-bits on a 32-bit processor, 64-bits on a 64-bit processor, etc. The rest are fine, but you should consider using CharSet=CharSet.Ansi in the StructureLayoutAttribute instead of marshalling the individual fields. Just makes it much easier to read.
Also, a lot of your consts are defined as ulong (aka UInt64). When you see LONG or ULONG in native API documentation, it's still a 32-bit integer. You might be getting some overflow problems.
Finally, your mciSendCommand should look like this:
[DllImport("winmm.dll")]
[return:MarshalAs(UnmanagedType.U4)]
private static extern int mciSendCommand(
[MarshalAs(UnmanagedType.U4)] int deviceID,
[MarshalAs(UnmanagedType.U4)] int msg,
[MarshalAs(UnmanagedType.U4)] int command,
IntPtr param);If you'll always be using this to send the MCI_OPEN_PARAMS structure, you can declare it as the following, or add the following as an overload:
[DllImport("winmm.dll")]
[return:MarshalAs(UnmanagedType.U4)]
private static extern int mciSendCommand(
[MarshalAs(UnmanagedType.U4)] int deviceID,
[MarshalAs(UnmanagedType.U4)] int msg,
[MarshalAs(UnmanagedType.U4)] int command,
ref MCI_OPEN_PARAMS);
[StructLayout(LayoutKind.Sequential, CharSet=CharSet.Ansi)]
public struct MCI_OPEN_PARAMS
{
public IntPtr callback;
[MarshalAs(UnmanagedType.U4)] public int deviceID;
public string deviceType;
public string elementName;
public string alias;
}
Microsoft MVP, Visual C#
My Articles
|
|
|
|
|
The problem was in ulong data types, I've change them and now it works fine.
Thanks for your help.
Pedro
|
|
|
|
|
Heath Stewart wrote:
Also, a few things about CLS-compliance. Don't use unsigned types if you hope to port your code ever. You can use the signed types and marshal them as unsigned types, using UnmanagedType.U4 for an Int32, for example. Yo also don't need to use "Attribute" when attributing members - it's implied.
CLS complaince is only necessary on the external level. The runtime will work correctly with all .NET intristic types. CLS complaince gaurentees the code can be used by a .NET implemetation (read other language) that only implement the bare minimun language requirements as laid out in the EMCA spec (see JScript.NET for such an example).
top secret
|
|
|
|
|
Perhaps "portable" was the wrong choice of words, but that's what I was getting at.
Microsoft MVP, Visual C#
My Articles
|
|
|
|
|
How many times does this need to get repeated? ULONG in C/C++ == UInt32 in C#, your parameter is likely getting truncated.
top secret
|
|
|
|
|
Hi leppie,
Well... what can I say? You're right. It's the same error I did last time I post here. This time I wont forget. 
Thanks leepie and thanks Heath four your time
Pedro
|
|
|
|
|
Hi,
I am using Listbox controls in C#. Items are need to move in between two or three listboxes.
Buttom used are ADD, ADD ALL, ReMOVE, REMOVE ALL.
Problem being faced is due to absence of itemdata property of listbox. I am using array
for saving IDs. When I move one item of listbox to other list box how can i move the ID from
one array list to another, so that the ist array shold remove the entry automatically ?
I have used a complete class and ARRAYLIST. But here I want to remove an item from a listbox
after binding it to an ArrayList with .Datasource property It is not allowing to delete
the item.
Please help me in this regard
abid
|
|
|
|
|
Hi,
I am using Microsoft Application Blocks for .NET. In which sqlhelper class is available to do different functions. What I need is the output parameter value ?
I do nt know how to get an output parameter value from sqlhelper.ExecuteNonQuery();
Normally we get the output parameter value by executing the nonquery of the sqlcommand.
waiting for a .NET guru response ..........
|
|
|
|
|
I don't know what do you mean by sqlhelper class but for ExecuteNonQuery , when you assign a Parameter to your SqlCommand as I told you in other thread , when you excute this function , output parameters fill automaticlly and you can get them.
Mazy
"I think that only daring speculation can lead us further and not accumulation of facts." - Albert Einstein
|
|
|
|
|
Hi,
SQLHelpder class is given in "Data Access Application Block". This block sample code is availabe on
Microsoft MSDN. Why am I using this becuase of time saving. Useful overloads are available to do more in less time.
What I need in a form is the newly added IDs in a table. For example I wrote the following code
//This module will insert a new role in the tblRole table by calling the stored procedure uspRoleNew
SqlParameter[] arparam = new SqlParameter[9];
arparam[0] = new SqlParameter("@pRoleName",SqlDbType.VarChar, 50);
arparam[0].Value= mRoleName;
arparam[1] = new SqlParameter("@pRoleDesc", SqlDbType.VarChar,50);
arparam[1].Value= mRoleDescription;
.
.
. .
arparam[8] = new SqlParameter("@pRoleIDout", SqlDbType.Int);
arparam[8].Direction=ParameterDirection.Output;
SqlHelper.ExecuteNonQuery(clsGeneral.conStr, "uspRoleNew", arparam);
int _RoleID;
_RoleID = (int)arparam[8].Value;
In paramerter[8] i want the newly added ID. But SqlHelper is not returning any value.
Below is the alternative solution for the above problem
mSqlCommand.Connection= _Sqlconn;
mSqlCommand.CommandText="uspRoleNew";
mSqlCommand.CommandType=CommandType.StoredProcedure;
mSqlCommand.Parameters.Add("@pRoleName",SqlDbType.VarChar, 50);
mSqlCommand.Parameters[0].Value=mRoleName;
mSqlCommand.Parameters.Add("@pRoleDesc", SqlDbType.VarChar,50);
mSqlCommand.Parameters[1].Value= mRoleDescription;
mSqlCommand.Parameters.Add("@pRoleIDout", SqlDbType.Int);
mSqlCommand.Parameters["@pRoleIDout"].Direction= ParameterDirection.Output;
_Sqlconn.Open();
mSqlCommand.ExecuteNonQuery();
mRoleID = (int)mSqlCommand.Parameters["@pRoleIDout"].Value;
return mRoleID;
QUESTION ????? is Why sqlhelper not doing this. If u r aware of "Data Access Application Block" plz reply.
|
|
|
|
|
Hi,
I want to refer the sqlparameter object to sqlcommand object. how can i do that ? I am giving different parameters input, return and output.
regards,
abid
|
|
|
|
|
abidkayani1 wrote:
I want to refer the sqlparameter object to sqlcommand object. how can i do that ?
See SqlCommand.Parameters property. There is an example in MSDN.
Mazy
"I think that only daring speculation can lead us further and not accumulation of facts." - Albert Einstein
|
|
|
|
|
In addition to what Mazdak said about using the SqlCommand.Parameters dictionary to refer to parameters by name, it is faster and far better to save the params as variables when you add them and use those variables to refer to them later. No lookups in the Parameters dictionary are needed, then.
See the example[^] I wrote just yesterday.
Microsoft MVP, Visual C#
My Articles
|
|
|
|
|
Hi there ,
I have a question about the treeview control in .NET.
In my first form I create nodes dynamically.
In my second form I want to show the tree exactly like in the first form.
When I try to pass the treeview like this :
Form2 frm2 = new Form2();
frm2.treeView1 = this.treeView1;
I can see the nodes (when debugging and using quickwatch) of the new tree which are the same of the form1's tree.
The problem is that I cannot display them. Anyone to help me pls?
|
|
|
|
|
Your passing a reference to the first Treeview control, your not copying it. In fact, you CAN'T copy a Treeview control. The Nodes property of the Treeview is read only, so your are limited to recursively walking through the Nodes tree on your first Treeview and using the second Treeview's Add method to add the Nodes to the second tree.
RageInTheMachine9532
|
|
|
|
|
Hi All!!!
I want to show only the shape of my form which i specify e.g. i would liek to draw a form like triagle or in circle or any opolygon. How would i do that rest of the form becomes transparent and only this portion is shown?
Thanx in advance
sorry for my bad English.
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
