Click here to Skip to main content
15,395,877 members
Home / Discussions / C#
   

C#

 
SuggestionRe: Mysql Update Query Error Pin
Eddy Vluggen20-Mar-22 8:40
professionalEddy Vluggen20-Mar-22 8:40 
GeneralRe: Mysql Update Query Error Pin
N Mohamed rafi20-Mar-22 8:45
MemberN Mohamed rafi20-Mar-22 8:45 
GeneralRe: Mysql Update Query Error Pin
OriginalGriff20-Mar-22 8:47
mveOriginalGriff20-Mar-22 8:47 
GeneralRe: Mysql Update Query Error Pin
Eddy Vluggen20-Mar-22 9:43
professionalEddy Vluggen20-Mar-22 9:43 
GeneralRe: Mysql Update Query Error Pin
OriginalGriff20-Mar-22 9:46
mveOriginalGriff20-Mar-22 9:46 
GeneralRe: Mysql Update Query Error Pin
Eddy Vluggen21-Mar-22 7:06
professionalEddy Vluggen21-Mar-22 7:06 
GeneralRe: Mysql Update Query Error Pin
OriginalGriff21-Mar-22 7:34
mveOriginalGriff21-Mar-22 7:34 
GeneralRe: Mysql Update Query Error Pin
Dave Kreskowiak20-Mar-22 10:49
mveDave Kreskowiak20-Mar-22 10:49 
So, it's obvious you're just copying and pasting code from the web and hoping it works. You don't have any idea why there are parameter objects or how they are used in the query.
C#
string query = "update employee set employee_id='" + this.textBox6.Text + "',employee_name='" + this.textBox7.Text + "',employee_salary='" + this.textBox8.Text + "' where employee_id='" + this.textBox6.Text + "';";
using (MySqlCommand cmd = new MySqlCommand(query))
{
cmd.Parameters.AddWithValue("@employee_id", id);
cmd.Parameters.AddWithValue("@employee_name", name);
cmd.Parameters.AddWithValue("@employee_salary", salary);

You're using the TextBox values directly in your query. NEVER DO THIS! User input should be treated like it's the spawn of Satan. Using it directly in your query will lead to SQL Injection Attacks and you risk destroying your database doing that.

Next, you NEVER change or update the value of an ID field in a table. Doing so will destroy your data integrity since records in one table will no longer relate to data in another table.

Your query should look like this (and don't even think of copying and pasting this code!) Try to figure out what the code is doing.
C#
string query = "UPDATE employee SET employee_name=@empName, employee_salary=@empSalary WHERE employee_id=@empId";
using (MySqlCommand cmd = new MySqlCommand(query))
{
cmd.Parameters.AddWithValue("@empId", id);
cmd.Parameters.AddWithValue("@empName", name);
cmd.Parameters.AddWithValue("@empSalary", salary);

I'm ignoring that you're storing salary values as text.

GeneralRe: Mysql Update Query Error Pin
N Mohamed rafi20-Mar-22 18:09
MemberN Mohamed rafi20-Mar-22 18:09 
GeneralRe: Mysql Update Query Error Pin
Richard MacCutchan20-Mar-22 22:25
mveRichard MacCutchan20-Mar-22 22:25 
GeneralRe: Mysql Update Query Error Pin
N Mohamed rafi20-Mar-22 23:45
MemberN Mohamed rafi20-Mar-22 23:45 
GeneralRe: Mysql Update Query Error Pin
Richard MacCutchan20-Mar-22 23:50
mveRichard MacCutchan20-Mar-22 23:50 
GeneralRe: Mysql Update Query Error Pin
Dave Kreskowiak21-Mar-22 2:29
mveDave Kreskowiak21-Mar-22 2:29 
Generalmysql delete code error Pin
N Mohamed rafi19-Mar-22 16:36
MemberN Mohamed rafi19-Mar-22 16:36 
GeneralRe: mysql delete code error Pin
Dave Kreskowiak19-Mar-22 17:54
mveDave Kreskowiak19-Mar-22 17:54 
GeneralRe: mysql delete code error Pin
N Mohamed rafi19-Mar-22 18:01
MemberN Mohamed rafi19-Mar-22 18:01 
GeneralRe: mysql delete code error Pin
Dave Kreskowiak19-Mar-22 18:39
mveDave Kreskowiak19-Mar-22 18:39 
GeneralRe: mysql delete code error Pin
N Mohamed rafi19-Mar-22 19:48
MemberN Mohamed rafi19-Mar-22 19:48 
AnswerRe: mysql delete code error Pin
OriginalGriff19-Mar-22 21:04
mveOriginalGriff19-Mar-22 21:04 
GeneralRe: mysql delete code error Pin
N Mohamed rafi19-Mar-22 23:05
MemberN Mohamed rafi19-Mar-22 23:05 
GeneralRe: mysql delete code error Pin
OriginalGriff19-Mar-22 23:35
mveOriginalGriff19-Mar-22 23:35 
GeneralRe: mysql delete code error Pin
N Mohamed rafi20-Mar-22 0:02
MemberN Mohamed rafi20-Mar-22 0:02 
GeneralRe: mysql delete code error Pin
OriginalGriff20-Mar-22 0:37
mveOriginalGriff20-Mar-22 0:37 
GeneralRe: mysql delete code error Pin
Richard MacCutchan20-Mar-22 2:13
mveRichard MacCutchan20-Mar-22 2:13 
GeneralRe: mysql delete code error Pin
N Mohamed rafi20-Mar-22 2:21
MemberN Mohamed rafi20-Mar-22 2:21 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.