Click here to Skip to main content
15,891,607 members
Home / Discussions / C#
   

C#

 
GeneralRe: problem retrieving info from one table to insert it into another Pin
ago248618-Mar-20 6:57
ago248618-Mar-20 6:57 
GeneralRe: problem retrieving info from one table to insert it into another Pin
OriginalGriff18-Mar-20 7:05
mveOriginalGriff18-Mar-20 7:05 
GeneralRe: problem retrieving info from one table to insert it into another Pin
ago248618-Mar-20 22:28
ago248618-Mar-20 22:28 
GeneralRe: problem retrieving info from one table to insert it into another Pin
OriginalGriff18-Mar-20 22:37
mveOriginalGriff18-Mar-20 22:37 
QuestionC# ATTNDACE Pin
villanueva bryan17-Mar-20 12:01
villanueva bryan17-Mar-20 12:01 
AnswerRe: C# ATTNDACE Pin
OriginalGriff17-Mar-20 12:33
mveOriginalGriff17-Mar-20 12:33 
Questionproblem to retrieve an info in a sql request / problème pour recéper une info dans une requête sql Pin
ago248616-Mar-20 6:53
ago248616-Mar-20 6:53 
AnswerRe: problem to retrieve an info in a sql request / problème pour recéper une info dans une requête sql Pin
OriginalGriff16-Mar-20 6:59
mveOriginalGriff16-Mar-20 6:59 
Don't do it like that! Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'
The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'
Which SQL sees as three separate commands:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';
A perfectly valid SELECT
SQL
DROP TABLE MyTable;
A perfectly valid "delete the table" command
SQL
--'
And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?

And when you've fixed that throughout you app, start looking at the problem you have noticed.
And that is probably in your ExecuteQuery method: if you are creating an SQL Reader ther, then you can't issue any more commands on that connection until the Reader is closed...
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
AntiTwitter: @DalekDave is now a follower!

GeneralRe: problem to retrieve an info in a sql request / problème pour recéper une info dans une requête sql Pin
ago248616-Mar-20 7:08
ago248616-Mar-20 7:08 
GeneralRe: problem to retrieve an info in a sql request / problème pour recéper une info dans une requête sql Pin
OriginalGriff16-Mar-20 7:10
mveOriginalGriff16-Mar-20 7:10 
GeneralRe: problem to retrieve an info in a sql request / problème pour recéper une info dans une requête sql Pin
ago248616-Mar-20 7:10
ago248616-Mar-20 7:10 
Generalrecording problem Pin
ago248617-Mar-20 0:47
ago248617-Mar-20 0:47 
GeneralRe: recording problem Pin
OriginalGriff17-Mar-20 1:24
mveOriginalGriff17-Mar-20 1:24 
GeneralRe: recording problem Pin
ago248617-Mar-20 2:07
ago248617-Mar-20 2:07 
GeneralRe: recording problem Pin
OriginalGriff17-Mar-20 2:13
mveOriginalGriff17-Mar-20 2:13 
GeneralRe: recording problem Pin
ago248617-Mar-20 2:21
ago248617-Mar-20 2:21 
GeneralRe: recording problem Pin
OriginalGriff17-Mar-20 2:34
mveOriginalGriff17-Mar-20 2:34 
GeneralRe: recording problem Pin
ago248617-Mar-20 2:40
ago248617-Mar-20 2:40 
GeneralRe: recording problem Pin
ago248617-Mar-20 2:43
ago248617-Mar-20 2:43 
GeneralRe: recording problem Pin
OriginalGriff17-Mar-20 2:51
mveOriginalGriff17-Mar-20 2:51 
GeneralRe: recording problem Pin
ago248617-Mar-20 3:02
ago248617-Mar-20 3:02 
GeneralRe: recording problem Pin
OriginalGriff17-Mar-20 3:17
mveOriginalGriff17-Mar-20 3:17 
GeneralRe: recording problem Pin
ago248617-Mar-20 3:24
ago248617-Mar-20 3:24 
GeneralRe: recording problem Pin
OriginalGriff17-Mar-20 3:38
mveOriginalGriff17-Mar-20 3:38 
GeneralRe: recording problem Pin
ago248617-Mar-20 3:52
ago248617-Mar-20 3:52 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.