Complexity - C# Discussion Boards

Re: Car tracker

lolinga218-Jul-15 9:42

lolinga2

18-Jul-15 9:42

i just need the basics of GPS speedometer and distance tracker code for a car.

Re: Car tracker

Mycroft Holmes18-Jul-15 14:35

Mycroft Holmes

18-Jul-15 14:35

Sounds like you want someone to write it for you - wrong site. There are many sites where you can buy that service. This is not one of them.

Never underestimate the power of human stupidity
RAH

Error Converting String to Int

Broodje Games18-Jul-15 2:26

Broodje Games

18-Jul-15 2:26

Hi, Im working in C# and trying to get string[] to int when I get an error:

My code:

string htmlCodee = Client.DownloadString("http://tf2casino.cf/prices/key.txt");
string[] htmlCode = htmlCodee.Replace("\r", "").Split('\n');
int low = Convert.ToInt32(htmlCode[1]);

My error:

ERROR: System.FormatException: De indeling van de
invoertekenreeks is onjuist.
bij System.Number.StringToNumber(String str, NumberStyles options, NumberBuff
er& number, NumberFormatInfo info, Boolean parseDecimal)
bij System.Number.ParseInt32(String s, NumberStyles style, NumberFormatInfo i
nfo)
bij System.Convert.ToInt32(String value)
bij SteamBot.SimpleUserHandler.PriceUpdate() in c:\Users\Gebruiker\Documents\
Bot\KeyBot\SteamBot\SimpleUserHandler.cs:regel 136
bij SteamBot.SimpleUserHandler.OnLoginCompleted() in c:\Users\Gebruiker\Docum
ents\Bot\KeyBot\SteamBot\SimpleUserHandler.cs:regel 107
bij SteamBot.Bot.<handlesteammessage>b__5(LoginKeyCallback callback) in c:\Us
ers\Gebruiker\Documents\Bot\KeyBot\SteamBot\Bot.cs:regel 436
bij SteamKit2.CallbackMsgExtensions.Handle[T](ICallbackMsg msg, Action`1 hand
ler)
bij SteamBot.Bot.HandleSteamMessage(ICallbackMsg msg) in c:\Users\Gebruiker\D
ocuments\Bot\KeyBot\SteamBot\Bot.cs:regel 416
bij SteamBot.Bot.BackgroundWorkerOnDoWork(Object sender, DoWorkEventArgs doWo
rkEventArgs) in c:\Users\Gebruiker\Documents\Bot\KeyBot\SteamBot\Bot.cs:regel 89
6

(Sorry for random NL text between it)

-Greetings, Jonathan

Re: Error Converting String to Int

OriginalGriff18-Jul-15 2:31

OriginalGriff

18-Jul-15 2:31

Start by using the debugger and looking at the data you have downloaded from the file: what exactly does it contain?
Then look at the array content post-split: what is in the second array element, exactly?

The chances are that the data is not what you expect, and the "second line" does not contain just a number.
But we can't check that for you!

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...

Re: Error Converting String to Int

miki-bgd18-Jul-15 5:12

miki-bgd

18-Jul-15 5:12

I saw the file, and i suppose you get these 2 strings:
"15.66"
"15.88"
Those strings hold double value, and you get exception because of that.

Greetings

Hide a Panel on MDI Container

Jassim Rahma17-Jul-15 11:13

Jassim Rahma

17-Jul-15 11:13

Hi,

I have frmMain which is an MDI Container and (frmCustomer & frmOrders) which are MDI child

On frmMain I have panelHeader.

I want to hide panelHeader every time frmCustomer or frmOrders are shown and then show it back when MDI child is closed.

so what I want is if an MDI child is shown (MDI Child > 0) then panelHeader visibility to be false else it should be true.

How can I dot this please?

Thanks,
Jassim[^]

Technology News @ www.JassimRahma.com

Re: Hide a Panel on MDI Container

Eddy Vluggen17-Jul-15 11:59

Eddy Vluggen

17-Jul-15 11:59

Toggle the Visibility-property in the appropriate event.

That might mean having a window-focus event recounting how much of those windows are approrpriate (OfType<frmcustomer> and..) and update the status.

What have you tried?

Bastard Programmer from Hell Suspicious | :suss:

If you can't read my code, try converting it here[^]

Complexity

Gilbert Consellado16-Jul-15 22:37

Gilbert Consellado

16-Jul-15 22:37

Ive create a method that will handle keydown event

it has a lot of "if" statment and it say i has a high complexity and its scores 33

is there way to decrease its complexity
actually the method is not finish

here is the code

private static void FlyouCommandEvent(object sender, KeyEventArgs e)
{
    var fd = (FlyoutDialog)sender;
    if ((e.KeyCode == Keys.A || (e.Alt && e.KeyCode == Keys.A)) && fd.CanExecuteCommand(Helpers.FlyoutCommandAbort))
    {
        fd.ExecuteCommand(Helpers.FlyoutCommandAbort);
    }
    else if (e.KeyCode == Keys.Escape && fd.CanExecuteCommand(Helpers.FlyoutCommandCancel))
    {
        fd.ExecuteCommand(Helpers.FlyoutCommandCancel);
    }
    else if ((e.KeyCode == Keys.I || (e.Alt && e.KeyCode == Keys.I)) && fd.CanExecuteCommand(Helpers.FlyoutCommandIgnore))
    {
        fd.ExecuteCommand(Helpers.FlyoutCommandIgnore);
    }
    else if ((e.KeyCode == Keys.N || (e.Alt && e.KeyCode == Keys.N)) && fd.CanExecuteCommand(Helpers.FlyoutCommandNo))
    {
        fd.ExecuteCommand(Helpers.FlyoutCommandNo);
    }
    else if ((e.KeyCode == Keys.N || (e.Alt && e.KeyCode == Keys.N)) && fd.CanExecuteCommand(Helpers.FlyoutCommandNone))
    {
        fd.ExecuteCommand(Helpers.FlyoutCommandNone);
    }
    else if (e.KeyCode == Keys.Enter && fd.CanExecuteCommand(Helpers.FlyoutCommandOK))
    {
        fd.ExecuteCommand(Helpers.FlyoutCommandOK);
    }
    else if ((e.KeyCode == Keys.R || (e.Alt && e.KeyCode == Keys.R)) && fd.CanExecuteCommand(Helpers.FlyoutCommandRetry))
    {
        fd.ExecuteCommand(Helpers.FlyoutCommandRetry);
    }
    else if ((e.KeyCode == Keys.Y || (e.Alt && e.KeyCode == Keys.Y)) && fd.CanExecuteCommand(Helpers.FlyoutCommandYes))
    {
        fd.ExecuteCommand(Helpers.FlyoutCommandYes);
    }
}

any suggestion is highly appreciated
thank you

modified 17-Jul-15 4:47am.

Re: Complexity

Godhaniketan17-Jul-15 0:07

Godhaniketan

17-Jul-15 0:07

there is switch....catch option is availabel as alternate option of if condition

Re: Complexity

Gilbert Consellado17-Jul-15 2:15

Gilbert Consellado

17-Jul-15 2:15

Thank you so much, but i guess switch cant handle expressions. Correct if I am wrong.

Re: Complexity

Pete O'Hanlon17-Jul-15 1:07

Pete O'Hanlon

17-Jul-15 1:07

There's a heck of a lot of code going on here, and it certainly appears as though you're violating SRP here. Rather than doing things like this, I would look to implement separate classes that do what you need to do - each class would then decide whether it was the one that handled the case. There's even a name for this, as a pattern; it's called the Chain Of Responsibility. So, you would end up with something like this:

public abstract class HandlerBase
{
  private IHandler successor;
  public void SetSuccessor(IHandler successor)
  {
    this.successor = handler;
  }
  public virtual void HandleRequest(KeyEventArgs e)
  {
    if (CanHandleRequest(e))
    {
      return;
    }
    if (successor != null)
    {
      successor.HandleRequest(e);
    }
  }

  public abstract bool CanHandleRequest(KeyEventArgs e);
  public abstract void HandleRequest(FlyoutDialog fd);
}

public class FlyoutAbort : HandlerBase
{
  public virtual bool CanHandleRequest(KeyEventArgs e)
  {
    return (e.KeyCode == Keys.A || (e.Alt && e.KeyCode == Keys.A)) && fd.CanExecuteCommand(Helpers.FlyoutCommandAbort);
  }

  public abstract void HandleRequest(FlyoutDialog fd)
  {
    fd.ExecuteCommand(Helpers.FlyoutCommandAbort); // In reality, I would look to move the command from Helpers, into this class.
  }
}

public class FlyoutCancel : HandlerBase
{
  public virtual bool CanHandleRequest(KeyEventArgs e)
  {
    return e.KeyCode == Keys.Escape && fd.CanExecuteCommand(Helpers.FlyoutCommandCancel;
  }

  public abstract void HandleRequest(FlyoutDialog fd)
  {
    fd.ExecuteCommand(Helpers.FlyoutCommandCancel);
  }
}

Then, in your main class, you simply do this:

private FlyoutAbort flyoutAbort;
private FlyoutCancel flyoutCancel;

private void InitializeChain()
{
  flyoutAbort = new FlyoutAbort();
  flyoutCancel = new FlyoutCancel();
  flyoutAbort.SetSuccessor(flyoutCancel);
}

Finally, all you need to do to handle the request (if it can be handled that is), is call:

flyoutAbort.HandleRequest(e);

Re: Complexity

Gilbert Consellado17-Jul-15 2:17

Gilbert Consellado

17-Jul-15 2:17

Nice one, let see what I can do. Thank you so much.

Re: Complexity

Gilbert Consellado17-Jul-15 5:18

Gilbert Consellado

17-Jul-15 5:18

Its all works now. Thank you so much.

Re: Complexity

Alan N17-Jul-15 4:37

Alan N

17-Jul-15 4:37

Off topic with regards to your question but is your key testing code correct?

I assume the intention of the following code is to allow A or Alt-A

if ((e.KeyCode == Keys.A || (e.Alt && e.KeyCode == Keys.A))

The first condition does not test for modifier keys so would be true for A with any combination of modifiers keys (including none). Due to shortcut evaluation the second condition will be evaluated only if the first is false, that is if the Key is NOT A and I'm sure you can see the problem with that. Even if it was evaluated the condition does not exclude additional modifiers so Ctrl-Alt-A would be allowed.

The solution is to test the key and the modifiers separately. Specifically the modifiers test should be for none or just Alt.

if ((e.KeyCode == Keys.A) && (e.Modifiers == Keys.None || e.Modifiers == Keys.Alt))

Hope that helps, Alan.

Re: Complexity

Gilbert Consellado17-Jul-15 5:22

Gilbert Consellado

17-Jul-15 5:22

Oh I didn't realize that. Thank you so much

Pass Anonymous Type To Worker

Kevin Marois16-Jul-15 12:58

Kevin Marois

16-Jul-15 12:58

I have this:

List<long> checkedIds = Sensors.Where(x => x.IsChecked).Select(x => x.ID).ToList();

var filterArgs = new 
{
    Ids = checkedIds,
    DateRangeStart = FilterRangeStart,
    DateRangeEnd = FilterRangeEnd
};

myWorker.RunWorkerAsync(filterArgs);

How do I get the values in the myWorker_DoWork?

private void myWorker_DoWork(object sender, DoWorkEventArgs e)
{
  // e is type object.. How do I get my anonymous type values?
}

If it's not broken, fix it until it is

Re: Pass Anonymous Type To Worker

Dave Kreskowiak16-Jul-15 14:49

Dave Kreskowiak

16-Jul-15 14:49

I really hate using anonymous types because they just make your code harder to debug and understand. I strongly suggest replacing the anonymous type with an actual class. I see no reason why you need to use a anonymous type here.

Anonymous types are good for use inside the method where it's defined, not really for passing around to other methods.

The reason being is that you have to define your anonymous type all over again just so you can cast the value back to that type. That's doubling your work and introducing another opportunity to introduce bugs into your code. This is especially true in this case because if you change the type definition, you have to do it in multiple places. YUK!

A guide to posting questions on CodeProject

Click this: Asking questions is a skill.
Seriously, do it.

Dave Kreskowiak

Re: Pass Anonymous Type To Worker

Kevin Marois16-Jul-15 14:52

Kevin Marois

16-Jul-15 14:52

You're right

If it's not broken, fix it until it is

Re: Pass Anonymous Type To Worker

F-ES Sitecore16-Jul-15 21:45

F-ES Sitecore

16-Jul-15 21:45

Whilst I agree you should really use a concrete class for anything that leaves the context in which it was created, to answer the question you could use this

private void myWorker_DoWork(object sender, DoWorkEventArgs e)
{
    dynamic arg = (dynamic) e.Argument;
    Console.WriteLine(arg.DateRangeStart);
}

form 1 and form 2

jamesmc153516-Jul-15 4:08

jamesmc1535

16-Jul-15 4:08

hi i want to have text(textbox8) show on form 1 (frmLogin)
shown on form2(files) textbox (textbox1)
my code: textbox1.Text = textbox8.text ,,, error,,,,name(textbox8) login form does not exist in current context

Re: form 1 and form 2

Wes Aday16-Jul-15 4:26

Wes Aday

16-Jul-15 4:26

Transferring information between two forms, Part 1: Parent to Child[^]

You can lead a developer to CodeProject, but you can't make them think.
The Theory of Gravity was invented for the sole purpose of distracting you from investigating the scientific fact that the Earth sucks.

i get a error invalid expresion

jamesmc153516-Jul-15 2:57

jamesmc1535

16-Jul-15 2:57

okay this is my code "if (string.IsNullOrEmpty(txtUser.Text)) || (string.IsNullOrEmpty(txtPassword.Text)" i get a invalid expresion on( "||" ) but i have used it before and it worked

Re: i get a error invalid expresion

Richard MacCutchan16-Jul-15 3:02

Richard MacCutchan

16-Jul-15 3:02

Should be:

if (string.IsNullOrEmpty(txtUser.Text) || string.IsNullOrEmpty(txtPassword.Text))

Use the IDE to check where your matching parentheses are, or should be.

Re: i get a error invalid expresion

jamesmc153516-Jul-15 3:09

jamesmc1535

16-Jul-15 3:09

if (string.IsNullOrEmpty(txtPassword.Text) || (string.IsNullOrEmpty(txtUser.Text)))
MessageBox.Show("field empty.", "Error", MessageBoxButtons.OK, MessageBoxIcon.Warning);
Files mf = new Files();
Hide();
mf.ShowDialog();
Close();

}
*theres my code ,its practicly a button that opens another form,and if the fields are empty popup error but when i click ok , the other form still opens, whats the addon code, (== DialogResult.Ok)??

Re: i get a error invalid expresion

Richard MacCutchan16-Jul-15 4:54

Richard MacCutchan

16-Jul-15 4:54

Yes, you should check the result of the MessageBox.Show message, and perhaps put a better message, and extra button, so the user can continue or cancel. Alternatively, if this error is unrecoverable, you should just exit aftger the message is dismissed by the user.

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.