deleting array of objects of a class - C / C++ / MFC Discussion Boards

Re: Converting PCM to GSM06.10 with ACM

Mark Salsbery12-Dec-08 7:40

Mark Salsbery

12-Dec-08 7:40

VuNic wrote:
MEDICAL/NETWORKING/TELECOM/IMAGEPROCESSING.

Just add DATABASE and that's it - everything I do Smile | :)

Mark Salsbery
Microsoft MVP - Visual C++
Java | [Coffee]

Re: Converting PCM to GSM06.10 with ACM

Mark Salsbery12-Dec-08 7:42

Mark Salsbery

12-Dec-08 7:42

Actually, I do very little image processing - that's all snake-oil "science" Poke tongue | ;-P

MEDICAL/NETWORKING/TELECOM/IMAGING/DATABASE

Mark Salsbery
Microsoft MVP - Visual C++
Java | [Coffee]

Re: Converting PCM to GSM06.10 with ACM

Eytukan12-Dec-08 7:51

Eytukan

12-Dec-08 7:51

Okay I'm sending you 5 empty dvds...got burner? Roll eyes | :rolleyes:

OK,. what country just started work for the day ? The ASP.NET forum is flooded with retarded questions. -Christian Graus

Best wishes to Rexx[^]

Re: Converting PCM to GSM06.10 with ACM

Mark Salsbery12-Dec-08 7:58

Mark Salsbery

12-Dec-08 7:58

Heh - OK.

Oh wait, DVD burner just broke right now... Poke tongue | ;-P

Mark Salsbery
Microsoft MVP - Visual C++
Java | [Coffee]

Re: Converting PCM to GSM06.10 with ACM

Eytukan12-Dec-08 8:10

Eytukan

12-Dec-08 8:10

OK,. what country just started work for the day ? The ASP.NET forum is flooded with retarded questions. -Christian Graus

Best wishes to Rexx[^]

UDP server with multiclients

sunny_vc12-Dec-08 2:20

sunny_vc

12-Dec-08 2:20

Hi All,
I am working on UDP sever module.I have developed a simple server for receiving and sending the data from a single client.
in "OnReceive()" handler only I am sending the data to the client using "SendTo()" function,

How can I extend this to multiclients.
Please give me an idea.
Plese provide me if anybody has the sample code.

Regards,
Sunil Kumar

Re: UDP server with multiclients

Eytukan12-Dec-08 7:35

Eytukan

12-Dec-08 7:35

Did I really needed multiple threads to handle UDP clients? Wait..scanning old dumps in brain.....oops, bad sectors. Search ends.
You are unlucky. let;s wait for someone to answer you.

OK,. what country just started work for the day ? The ASP.NET forum is flooded with retarded questions. -Christian Graus

Best wishes to Rexx[^]

deleting array of objects of a class

Andy Rama12-Dec-08 1:35

Andy Rama

12-Dec-08 1:35

Hi to all,

I am have written some classes in C++ as follows,

Class A
{
int b1Len; //count of B type objects in b1Collection
B *b1Collection; //stores collection of object of type B

int b2Len; //count of B type objects in b2Collection
B *b2Collection; //stores collection of object of type B
};
Class B
{
int cLen; //count of C type objects in cCollection //cLen is atleast 30
C *cCollection; //stores collection of object of type C
};
Class C
{
int d1Len; //count of D type objects in d1Collection //d1Len is atleast 140
D *d1Collection; //stores collection of object of type D

int d2Len; //count of D type objects in d2Collection
D *d2Collection; //stores collection of object of type D

int e1Len; //count of E type objects in e1Collection
E *e1Collection; //stores collection of object of type E

int e2Len; //count of E type objects in e2Collection
E *e2Collection; //stores collection of object of type E

};
Class D
{
int fLen; //count of F type objects in fCollection //fLen is atleast 2
F *fCollection; //stores collection of object of type F
};
Class F
{
int len; //count of characters in str //len is atleast 200
char *str; //stores multiple characters
};

int aLen; //count of A type objects in aCollection
A *aCollection; //stores collection of object of type A

DelAll(aCollection, aLen); //aLen is atleast 30

//it's a macro to delete array of objects of any type
#define DelAll(obj, no) if( obj != NULL ) { if( 0 < no ) { delete[] obj; obj = NULL; } }
I am using this macro in destructor of all class (above) to delete array of objects.

My problem is, it's takes atleast 0.86 secs

Is there anything wrong I am doing?

I am using VC++ 2008 as IDE.

Thanks & Regards,
Aniket A. Salunkhe

Re: deleting array of objects of a class

Sarath C12-Dec-08 2:41

Sarath C

12-Dec-08 2:41

It'd be helpful if you post a working code. The above class structure and objects wont take too much time.

Please carefully check the destructors of the classes. You can roughly calculate the time using OutputDebugString API. Just start Debug View Tool and set the time to display in Milliseconds. then execute the code after putting enough log. or use some profiling or logging mechanisms to get the critical point.

-Sarath.
"Great hopes make everything great possible" - Benjamin Franklin

My blog - Sharing My Thoughts

Re: deleting array of objects of a class

Andy Rama17-Dec-08 21:30

Andy Rama

17-Dec-08 21:30

Hi to all,

Thanks for your suggestions.

In every class I was using Add___() function to add object of other class.
I was reading a 35 MB xml & using that I was calling Add___() every time a found an object of class A, B, C, D, .. & I was getting problem at DelAll macro (it was taking more time to execute that might be due to lot of data).

Now I have replaced the Add___() function call, by it’s function body. Now it is taking normal time to execute DelAll macro

<br />
class A<br />
{<br />
	void Add_B(const B* newBs, int newBsCount)<br />
	{<br />
		if( newBsCount <= 0 )<br />
			return;<br />
<br />
		B* temp_Bs = NULL;<br />
<br />
		if( 0 < AllBsCount )<br />
			temp_Bs = new B[AllBsCount ];<br />
<br />
		int i<br />
		for( i= 0 ; i < AllBsCount; i++ )<br />
			temp_ Bs [i] = AllDays[i];<br />
<br />
		DelAll(AllBs, AllBsCount)   //problem macro<br />
<br />
		AllBs = new B[AllBsCount + newBsCount];<br />
		for( i = 0 ; i < AllBsCount; i++ )<br />
			AllBs [i] = temp_Days[i];<br />
		for( i = 0 ; i < newBsCount; i++ )<br />
			AllBs [AllBsCount +i] = newBs [i]; <br />
<br />
		DelAll(temp_ Bs, AllBsCount);<br />
<br />
		AllBsCount += newBsCount;<br />
	}<br />
}<br />

Thanks & Best Regards,
Aniket A. Salunkhe

Re: deleting array of objects of a class

Maximilien12-Dec-08 3:08

Maximilien

12-Dec-08 3:08

(not really an answer)

Why are you using C type "collections" instead of std::vector (or std::list) ?
Are you checking the time in DEBUG or in RELEASE ?

I don't see much wrong in what you presented if the destructors are really deleting what has been allocated;
you probably have more data than you are expecting.

Re: deleting array of objects of a class

Alan Balkany12-Dec-08 4:00

Alan Balkany

12-Dec-08 4:00

It looks like you have many arrays of objects, and a destructor is called for EACH array element. It may be possible to delete the whole array with one statement, if your destructor is just freeing memory (as opposed to executing cleanup code).

For example:

D* dArray = (D *) malloc (numberOfDObjects * sizeof (D));

...

delete [] (char *) dArray;

This invokes delete once, rather than numberOfDObjects times. You may be able to use similar logic for arrays of arrays of objects.

Re: deleting array of objects of a class

Maximilien12-Dec-08 4:44

Maximilien

12-Dec-08 4:44

malloc and delete do not play well together.

did you meant to use free instead of delete ?

Re: deleting array of objects of a class

Alan Balkany12-Dec-08 7:36

Alan Balkany

12-Dec-08 7:36

Oops, my mistrake. You can use free ((char *) dArray), or

D* dArray = (D *) new char [numberOfDObjects * sizeof (D)]; and
delete [] (char *) dArray

Re: deleting array of objects of a class

Eytukan12-Dec-08 7:19

Eytukan

12-Dec-08 7:19

Is it surrounded by a bunch of try ... catch blocks? it shouldn't take is much time though. Even in debug mode.

OK,. what country just started work for the day ? The ASP.NET forum is flooded with retarded questions. -Christian Graus

Best wishes to Rexx[^]

using SAFEARRAY

KASR112-Dec-08 1:29

KASR1

12-Dec-08 1:29

How to insert struct data using SafeArrayPutElement() method?

Re: using SAFEARRAY

Jijo.Raj12-Dec-08 1:44

Jijo.Raj

12-Dec-08 1:44

This thread[^] seems useful to you.

Regards,
Jijo.

_____________________________________________________

http://weseetips.com[^] Visual C++ tips and tricks. Updated daily.

Re: using SAFEARRAY

David Crow12-Dec-08 3:16

David Crow

12-Dec-08 3:16

What type (e.g., VT_x) of VARIANT object to you have?

"Love people and use things, not love things and use people." - Unknown

"The brick walls are there for a reason...to stop the people who don't want it badly enough." - Randy Pausch

Re: using SAFEARRAY

KASR112-Dec-08 3:17

KASR1

12-Dec-08 3:17

struct type.

Re: using SAFEARRAY

David Crow12-Dec-08 3:19

David Crow

12-Dec-08 3:19

"Love people and use things, not love things and use people." - Unknown

"The brick walls are there for a reason...to stop the people who don't want it badly enough." - Randy Pausch

Re: using SAFEARRAY

KASR112-Dec-08 3:23

KASR1

12-Dec-08 3:23

VT_ARRAY

Re: using SAFEARRAY

KASR112-Dec-08 3:24

KASR1

12-Dec-08 3:24

type VT_ARRAY

Size of memory pointed to by void * pointer.

VC++Maniac12-Dec-08 1:00

VC++Maniac

12-Dec-08 1:00

How to get the size of memory pointed by void * pointer?

Thanks in advance!

Re: Size of memory pointed to by void * pointer.

Naveen12-Dec-08 1:16

Naveen

12-Dec-08 1:16

Generally there is no way that will work on all conditions. How ever if you are sure that, the pointer will be pointing to a memory allocated using new operator, you can use the _msize function.

nave

[OpenedFileFinder] [My Blog]

Re: Size of memory pointed to by void * pointer.

Jijo.Raj12-Dec-08 1:18

Jijo.Raj

12-Dec-08 1:18

You could use _msize()[^]. For instance,

#include "malloc.h"

...

// Allocate 100 bytes.
void* pPointer = new BYTE[100];

// Get the size from void ptr. Remember, It will return size in bytes.
int size = _msize( Ptr );

Please note that it won't work if the memory is allocated in stack. Only for memory allocated on heap. Hope it helps.

Regards,
Jijo.

_____________________________________________________

http://weseetips.com[^] Visual C++ tips and tricks. Updated daily.

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.