C / C++ / MFC

monsieur_jj wrote:

break;
return true;

monsieur_jj wrote:

RMUpdates* update = new RMUpdates;

bool CUpdateServiceModule::DoCheckForProductUpdates(ns1__Update oUpdateCode, RMproduct* prd)
{

	int iRet = SOAP_ERR;
	_ns1__DoCheckForProductUpdates			*pDoCheckForProductUpdates;
	_ns1__DoCheckForProductUpdatesResponse	*pDoCheckForProductUpdatesResponse;

	pDoCheckForProductUpdates = InstantiateCheckUpdate();
	pDoCheckForProductUpdatesResponse = InstantiateCheckUpdateResponse();
	
	USES_CONVERSION;

	pDoCheckForProductUpdates->productName = new std::string(W2A(prd->m_Name.c_str()));
	pDoCheckForProductUpdates->productVersion = new std::string(W2A(prd->m_VersionNo.c_str()));
	pDoCheckForProductUpdates->serialNumber = new std::string(W2A(prd->m_SerialNo.c_str()));
	pDoCheckForProductUpdates->siteCode = new std::string(W2A(prd->m_SiteCode.c_str()));
	_ns1__DoGetLatestProduct				*pDoGetLatestProduct;
	_ns1__DoGetLatestProductResponse		*pDoGetLatestProductResponse;

	pDoGetLatestProduct	= InstantiateGetProduct();
	pDoGetLatestProductResponse = InstantiateGetProductResponse();

	iRet = m_pWebServiceSoap->__ns2__DoCheckForProductUpdates(pDoCheckForProductUpdates,pDoCheckForProductUpdatesResponse);
	
	switch(iRet)
	{
	case SOAP_OK :
		{
			if(pDoCheckForProductUpdatesResponse->DoCheckForProductUpdatesResult)
			{
			pDoGetLatestProduct->productName = pDoCheckForProductUpdates->productName;
			pDoGetLatestProduct->productVersion = pDoCheckForProductUpdates->productVersion;
			pDoGetLatestProduct->serialNumber = pDoCheckForProductUpdates->serialNumber;
			pDoGetLatestProduct->siteCode = pDoCheckForProductUpdates->siteCode;
			iRet = m_pWebServiceSoap->__ns2__DoGetLatestProduct(pDoGetLatestProduct,pDoGetLatestProductResponse);

			switch(iRet)
			{
			case SOAP_OK :
				{
					RMUpdates* update = new RMUpdates;
					update->prdName = prd->m_Name.c_str();
					update->nameVer = std::wstring(A2W(pDoGetLatestProductResponse->DoGetLatestProductResult->Version->c_str()));
					update->link.append(DOWNLOADLINK);
					update->link.append(std::wstring(A2W(pDoGetLatestProductResponse->DoGetLatestProductResult->Link->c_str())));
					update->savePath = SetDestination(update->link.c_str()); 
					prd->updateList->push_back(update);
					return true;
				}
			default:
				{
				Log(GetSoapError());	
				}
			}
			}
		}
	case SOAP_CLI_FAULT :
	{
		return false;
	}
	case SOAP_SVR_FAULT :
	{
		return false;
	}		
	case SOAP_TAG_MISMATCH :
	{
		return false;
	}	
	case SOAP_TYPE :
	{
		return false;
	}		
	case SOAP_SYNTAX_ERROR :
	{
		return false;
	}		
	case SOAP_NO_TAG :	
	{
		return false;
	}		
	case SOAP_IOB :
	{
		return false;
	}		
	case SOAP_MUSTUNDERSTAND :
	{
		return false;
	}	
	default:
		{
		Log(GetSoapError());
		}
	}
	return false;
}

void resize(size_type _Newsize, _Ty _Val)
    {   // determine new length, padding with _Val elements as needed
    if (size() < _Newsize)
        _Insert_n(end(), _Newsize - size(), _Val);
    else if (_Newsize < size())
        erase(begin() + _Newsize, end());
    }

size_type size() const
    {   // return length of sequence
    return (_Myfirst == 0 ? 0 : _Mylast - _Myfirst);
    }

monsieur_jj wrote:

it keeps crashing when it gets to return.

DavidCrow wrote:

As there are two, which return are you referring to?

Roger Stoltz wrote:

Can only be the last one since the first is unreachable due to the break-statement.
This also means that the function always returns false...

DavidCrow wrote:

I know. I couldn't think of any other way to say, "What's with this code?"

Roger Stoltz wrote:

unreachable code....

ThatsAlok like this type of coding

Roger Stoltz wrote:

Playing it safe, Alok? [Big Grin]