Does vc7/8 supprot declare a variable in switch case? - C / C++ / MFC Discussion Boards

Anil_vvs31-May-06 19:26

31-May-06 19:26

This is how I implemented my QueryCOntextMenu

STDMETHODIMP MyShellFOlder::QueryContextMenu(HMENU hMenu, UINT uiIndexMenu, UINT idCmdFirst, UINT idCmdLast, UINT uFlags)
{
AFX_MANAGE_STATE(AfxGetStaticModuleState())

m_hMenu = hMenu;
m_idCmdFirst = uiIndexMenu;
m_id = idCmdFirst;
if (CMF_DEFAULTONLY & uFlags)
return MAKE_HRESULT(SEVERITY_SUCCESS,FACILITY_NULL,0);
int i = uiIndexMenu;
MxSNECmdMgr cmdMgr;
try
{
if(!cmdMgr.IsConnectedFromShell())
{

MENUITEMINFO mii = { 0 };

mii.cbSize = sizeof(MENUITEMINFO);
mii.fMask = MIIM_ID | MIIM_TYPE | MIIM_STATE;
mii.wID = idCmdFirst + ID_CONNECT;
mii.fType = MFT_STRING;
mii.dwTypeData = _T("Connect");
mii.fState = MFS_ENABLED;
bool b = InsertMenuItem(hMenu, uiIndexMenu++, TRUE, &mii);

mii.cbSize = sizeof(MENUITEMINFO);
mii.fMask = MIIM_ID | MIIM_TYPE | MIIM_STATE;
mii.wID = idCmdFirst + ID_SEARCH;
mii.fType = MFT_STRING;
mii.dwTypeData = _T("Search");
mii.fState = MFS_DISABLED;
b = InsertMenuItem(hMenu, uiIndexMenu++, TRUE, &mii);

mii.cbSize = sizeof(MENUITEMINFO);
mii.fMask = MIIM_ID | MIIM_TYPE | MIIM_STATE;
mii.wID = idCmdFirst + ID_CREATEUSINGTEMPLATE;
mii.fType = MFT_STRING;
mii.dwTypeData = _T("Create Using Template");
mii.fState = MFS_DISABLED;
b = InsertMenuItem(hMenu, uiIndexMenu++, TRUE, &mii);

mii.cbSize = sizeof(MENUITEMINFO);
mii.fMask = MIIM_ID | MIIM_TYPE | MIIM_STATE;
mii.wID = idCmdFirst + ID_DISCONNECT;
mii.fType = MFT_STRING;
mii.dwTypeData = _T("Disconnect");
mii.fState = MFS_DISABLED;
b = InsertMenuItem(hMenu, uiIndexMenu++, TRUE, &mii);

mii.cbSize = sizeof(MENUITEMINFO);
mii.fMask = MIIM_ID | MIIM_TYPE | MIIM_STATE;
mii.wID = idCmdFirst + ID_ABOUT;
mii.fType = MFT_STRING;
mii.dwTypeData = _T("About");
mii.fState = MFS_ENABLED;
b = InsertMenuItem(hMenu, uiIndexMenu++, TRUE, &mii);
}
catch(...)
{

}

return MAKE_HRESULT(SEVERITY_SUCCESS, 0, USHORT(i-uiIndexMenu));
}

vc++

Y_Kaushik31-May-06 18:58

Y_Kaushik

31-May-06 18:58

Hai to all of you
i am doing my project in VC++ as Front End and MySQL as an Back End,
i am feeling some problem whenever i insert data using Form (VC++ dialog based form) i am sending some line of code written below .Please help me
where i am wrong........

void CEmpDetail::OnSubmit()
{
int i, j;
MYSQL * Conn;
MYSQL_RES * res;
MYSQL_ROW row;
CString sDAt,sEmpid,sEmpf,sEmpl,sDes,iPh,iEx,dDt,sMm,iYy,sQf,sTs,iTx,iHcx,sVis,sLoc,iOdc,sPrj,sGp,iPk,sMid,iFs,iOs;
CString sStr;
if ( (Conn = mysql_init((MYSQL*) 0)) &&
mysql_real_connect( Conn, "localhost", "", NULL, NULL, MYSQL_PORT, NULL, CLIENT_MULTI_STATEMENTS ) )
{
if ( mysql_select_db( Conn, "project") < 0 )
{
SetDlgItemText(IDC_STATIC_LOGIN_MSG, "Can't select the database !\nTry later.") ;
goto exit_here;
}
}
else
{
SetDlgItemText(IDC_STATIC_LOGIN_MSG, "Can't connect to the mysql server !\nPlease try later.") ;
goto exit_here;
}

GetDlgItemText(IDC_EMPID,sEmpid) ; ///////// Getting emp id from user
GetDlgItemText(IDC_EMPNMF,sEmpf) ;/////////emp first name
GetDlgItemText(IDC_EMPNML,sEmpl) ;///////////emp last name
GetDlgItemText(IDC_DESIGNATION,sDes) ;/////////////emp designation
GetDlgItemText(IDC_PHONENO,iPh) ;///////////phone
GetDlgItemText(IDC_EXTEN,iEx) ;//////////ext
GetDlgItemText(IDC_COMBO_DD,dDt) ;////////date
GetDlgItemText(IDC_COMBO_MM,sMm) ;////////Month
GetDlgItemText(IDC_COMBO_YY,iYy) ;////////Year
GetDlgItemText(IDC_EDIT_QFLN,sQf) ;/////qualification
GetDlgItemText(IDC_EDIT_TKSKL,sTs) ;/////////////////technical skill
GetDlgItemText(IDC_EDIT_TOTAL,iTx) ;///////////total exp
GetDlgItemText(IDC_EDIT_HCL,iHcx) ;///////hcl exp
GetDlgItemText(IDC_EDIT_VISA,sVis) ;//////////visa
GetDlgItemText(IDC_LOC,sLoc) ;////////////////loc
GetDlgItemText(IDC_ODC,iOdc) ;//////////odc
GetDlgItemText(IDC_PROJID,sPrj) ;/////////proj
GetDlgItemText(IDC_GROUP,sGp) ;///////////////group
GetDlgItemText(IDC_PACKAGE,iPk) ;//////////////package
GetDlgItemText(IDC_EMPMAIL,sMid) ;///////mail id
GetDlgItemText(IDC_OFFSH,iFs) ;/////////////////offshore
GetDlgItemText(IDC_ONSH,iOs) ;/////////onsite"vas"

if (!mysql_query( Conn,"INSERT INTO emp VALUES (\'" + sEmpid + "\',\'" + sEmpf + "\',\'" + sEmpl + "\',\'" + sDes + "\',\'" + iPh + "\',\'" + iEx + "\',\'" + dDt + "\',\'" + sMm + "\',\" + iYy + "\',\'" + sQf + "\',\'" + sTs + "\',\'" + iTx + "\',\'" + iHcx + "\',\'" + sVis + "\',\'" + sLoc + "\',\'" + iOdc + "\',\'" + sPrj + "\',\'" + sGp + "\,\'" + iPk + "\',\'" + sMid + "\',0,1)")))
{
res = mysql_store_result(Conn);
if(res)
{
MessageBox("Your Data Submit Successfully","Yse...",MB_ICONASTERISK);

}

else
{
MessageBox("Data Not Submitted","Error...",MB_ICONQUESTION);
goto exit_here;
}
}
else
{
MessageBox(" Query Not Execute ","Error...",MB_ICONQUESTION);
goto exit_here;
}

exit_here:
mysql_close( Conn );
UpdateData(FALSE);

}

i think i am lack of using any API Please help me where i am wrong.
Thanking you
Yogendra kumar kaushik

mailing me
Yogi

Re: vc++

Stephen Hewitt31-May-06 19:40

Stephen Hewitt

31-May-06 19:40

I'm not sure what you're asking but all the GetDlgItemText calls could be replaced with the DDX (Dialog Data eXchange). Use ClassWizard to add member variables for the controls then call UpdateData(TRUE) to get all the values.

Steve

Re: vc++ [modified]

NiceNaidu31-May-06 19:47

NiceNaidu

31-May-06 19:47

After the strings are retrieved, u need to format the strings accordingly.

Suppose if u get sEmpid from the corresponding control,

Then in order to convert it into int,

u need to do

CString sEmpid ;<br />
	GetDlgItemText(IDC_EDIT1,sEmpid );<br />
	int iEmpId;<br />
        iEmpId= atoi(strTest.GetBuffer(strTest.GetLength()));

Appu..
"If you judge people, you have no time to love them."

-- modified at 2:01 Thursday 1st June, 2006

Re: vc++

NiceNaidu31-May-06 19:50

NiceNaidu

31-May-06 19:50

Or Use GetDlgItemInt to get the Int data from the control

Appu..
"If you judge people, you have no time to love them."

Re: vc++

Steve Echols31-May-06 20:07

Steve Echols

31-May-06 20:07

A couple of things I noticed.

1. Are all the fields in your table "text"? You are inserting values as if they are text, which probably will give you a type mismatch error (I'm not real familiar with MySql).

2. I don't think you need to escape the single quote characters (i.e. instead of \', can't you just use '?). Makes it hard for me to read. Smile | :)

What error are you getting exactly?

- S
50 cups of coffee and you know it's on!

Re: vc++

David Crow1-Jun-06 4:15

David Crow

1-Jun-06 4:15

yogikaushik wrote:
where i am wrong........

You're going to need to narrow the problem down to just a few lines of code. No one likes to wade through a bunch of irrelevant code. What is the problem you are seeing? Have you single-stepped through the code to find the offending statement(s)? Help us to help you.

"The largest fire starts but with the smallest spark." - David Crow

Does vc7/8 supprot declare a variable in switch case?

followait31-May-06 18:46

followait

31-May-06 18:46

like:

switch (n) {
case 0:
int i=0; //<<<<<<<<<<<<<<<<<
break;
case 1:
break;
}

Re: Does vc7/8 supprot declare a variable in switch case?

_AnsHUMAN_ 31-May-06 18:49

_AnsHUMAN_

31-May-06 18:49

switch (n) {
case 0:
{
int i=0; //<<<<<<<<<<<<<<<<<
}
break;
case 1:
break;
}

This is how it is done in VC7

Somethings seem HARD to do, until we know how to do them.
Wink | ;-)

_AnShUmAn_

Re: Does vc7/8 supprot declare a variable in switch case?

Steve Mayfield31-May-06 19:30

Steve Mayfield

31-May-06 19:30

It is my understanding that you can only use the variable within the case block. When you exit out of the block, the variable goes out of scope and it is destroyed.

Steve

Re: Does vc7/8 supprot declare a variable in switch case?

_AnsHUMAN_ 31-May-06 19:36

_AnsHUMAN_

31-May-06 19:36

Yes this is very true . The scope of the variable is only in the case block.

Somethings seem HARD to do, until we know how to do them.
Wink | ;-)

_AnShUmAn_

Re: Does vc7/8 supprot declare a variable in switch case?

David Crow1-Jun-06 4:17

David Crow

1-Jun-06 4:17

_AnShUmAn_ wrote:

This is how it is done in VC7

Nothing VC7-specific about it. This is how it has been done in C as far back as I can remember.

"The largest fire starts but with the smallest spark." - David Crow

link two visual projects [modified]

widoxs31-May-06 18:39

widoxs

31-May-06 18:39

how i link two MFC projects to visual C++ 6.0 ?? Unsure | :~

-- modified at 0:39 Thursday 1st June, 2006

Re: link two visual projects [modified]

NiceNaidu31-May-06 18:55

NiceNaidu

31-May-06 18:55

U mean, inserting a project into another project.

Do this.

Right Click on the workspace,then click on Insert project in to workspace.

then u can observe both the project in the same workspace.

hope this helps.

Appu..
"If you judge people, you have no time to love them."

Memory problem

Anu_Bala31-May-06 18:20

Anu_Bala

31-May-06 18:20

Hi,
I am working in vc++ for past 4 months.But i dont know very much about MFC.That is where the variables stored and memory allocation like that.When im doing coding,i got error as unhandled exception,Out of memory like that.So, i think im unaware about the memory allocation.So, Is there any tutorial about this allocation etc.,..?

Re: Memory problem

Hamid_RT31-May-06 18:29

Hamid_RT

31-May-06 18:29

I think that these links are helpful to you
Dynamic memory allocation in C++[^] and Memory leaks in C++ and how to avoid them[^]

whitesky

Re: Memory problem [modified]

Nibu babu thomas31-May-06 19:05

Nibu babu thomas

31-May-06 19:05

Anu_Bala wrote:
I am working in vc++ for past 4 months.But i dont know very much about MFC.That is where the variables stored and memory allocation like that.When im doing coding,i got error as unhandled exception,Out of memory like that.So, i think im unaware about the memory allocation.So, Is there any tutorial about this allocation etc.,..?

Well some of the things I know I would like to share. Smile | :)

Use new and delete.
Always use delete[] with new[] and delete with new
Do not mix up c, c++. Either you use C, or use C++ for memory allocation.
Always set a pointer to NULL after deletion.

Always allocate sufficient amount of memory. Do not allocate memory like this...

char *str = new char[ strlen( someStr ) ];//stingy
strcpy( str, someStr );// well asking for trouble
delete [] str;//error here
str = NULL;//good practice

instead use

char *str = new char[ strlen(someStr) + 1 ];//bring it on
strcpy( str, someStr );//gooood, very gooood.
delete [] str;//hehe fine
str = NULL;//good practice

Try using auto_ptr;
Maintain a list of pointers to memory that you have allocated. When you exit from your app you can delete them all at one go if any of them hasn't been deleted.
Always check for NULL on pointers after a new.
Always check for NULL on pointers before using them.
Be really really afraid to dynamically allocate memory.

Nibu thomas
A Developer

Programming tips[^] My site[^]

Re: Memory problem [modified]

David Crow1-Jun-06 4:20

David Crow

1-Jun-06 4:20

Nibu thomas wrote:
strcpy( str, someStr );// well asking for trouble

True, use strncpy() instead.

Nibu thomas wrote:
delete [] str;//error here

Why do you assert this is in error?

Nibu thomas wrote:
Be really really afraid to dynamically allocate memory.

Why?

"The largest fire starts but with the smallest spark." - David Crow

Re: Memory problem [modified]

Nibu babu thomas1-Jun-06 17:23

Nibu babu thomas

1-Jun-06 17:23

DavidCrow wrote:
Nibu thomas wrote:
delete [] str;//error here

That was in relation to the point I mentioned. i.e. to allocate sufficient amount of memory. Well if you are using strcpy for that purpose strcpy will put a NULL char just after the end of the memory block. And when you try to delete such pointers it will result in memory damaged error message.

strcpy was used here just to regenerate that issue.

DavidCrow wrote:
Nibu thomas wrote:
Be really really afraid to dynamically allocate memory.

Why?

Yeah, use it as a last resort. For eg: using standard stl classes can avoid most of the issues.

Note: I didn't say not to use it but instead to be afraid. Sometimes being afraid is good. Smile | :)

Nibu thomas
A Developer

Programming tips[^] My site[^]

Re: Memory problem [modified]

David Crow2-Jun-06 2:56

David Crow

2-Jun-06 2:56

Nibu thomas wrote:
Well if you are using strcpy for that purpose strcpy will put a NULL char just after the end of the memory block.

But the point is that the source could be longer than the destination, which is why strcpy() should not be used, regardless of how it deals with the \0 terminator.

Nibu thomas wrote:
For eg: using standard stl classes can avoid most of the issues.

Last time I checked, STL used memory from the heap (i.e., dynamic). There's just not any way around not using memory from the heap.

"The largest fire starts but with the smallest spark." - David Crow

Re: Memory problem [modified]

Nibu babu thomas2-Jun-06 3:03

Nibu babu thomas

2-Jun-06 3:03

DavidCrow wrote:
But the point is that the source could be longer than the destination, which is why strcpy() should not be used, regardless of how it deals with the \0 terminator.

Exactly, I was just demonstrating how such things could happen.

DavidCrow wrote:
Last time I checked, STL used memory from the heap (i.e., dynamic). There's just not any way around not using memory from the heap.

Exactly, they work by allocating on the heap. But then we don't have to do it. These are proven classes (AFAIK) which work efficiently. Hence using them would be best for us. These classes takes the onus on them to do memory clean up.

Nibu thomas
A Developer

Programming tips[^] My site[^]

Re: Memory problem

Sarath C31-May-06 19:14

Sarath C

31-May-06 19:14

I suggest you to read Effective C++ 2nd Edition or the latest 3rd Edition.

If u r confused about pointers, read Pointers in C to know more about pointers.

as nibu said if u r much concerned about pointers, try using auto_pointers that is the best way to handle memory leaks. but I suggest that not to use auto_pointer because simply u can handle those allocation and deallocation of objects.
In MFC, it is not using any special allocation strategy, its all C++.

Code Complete 2 is a book which contains some best practices.

Sa^Rath

"D on't blindly follow rules you read somewhere without verifying that it makes sense for your situation!"

Re: Memory problem

led mike31-May-06 19:32

led mike

31-May-06 19:32

SaRath C wrote:
In MFC, it is not using any special allocation strategy, its all C++.

That is not entirely accurate.

See this MSDN Article[^]

"What classes are you using ? You shouldn't call stuff if you have no idea what it does"
Christian Graus in the C# forum

led mike

Re: Memory problem [modified]

Sarath C31-May-06 19:52

Sarath C

31-May-06 19:52

Thanks for ur information. It was quite new for me.

Anu said that (he/she) is new to MFC and suffering with some exception and all.
Everything has an user point of view. We are the users of C++ right, at our point of view, operator new has a standard form and a predefined way which it should be used. I just indicated about that fact. never I meant any regarding internal handling of compiler. I think the language I used was something not proper Frown | :(

Sa^Rath

"D on't blindly follow rules you read somewhere without verifying that it makes sense for your situation!"

-- modified at 1:55 Thursday 1st June, 2006

Re: Memory problem [modified]

palbano1-Jun-06 4:50

palbano

1-Jun-06 4:50

SaRath C wrote:
at our point of view, operator new has a standard form and a predefined way which it should be used. I just indicated about that fact.

ah, I understand now, thanks. Smile | :)

-- signature under construction --

-pete

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.