C / C++ / MFC

naguu wrote:

char * getmestring()
{
char *str = new char[20];
str = "myname";
return str; --> str not at all release..
}

char * getmestring()
{
  char *str = new char[20];
  strcpy(str, "myname");
  return str; --> str not at all release..
}

int main()
{
char *name = getmestring(); --> modify this line
cout<<name<<endl;
if(name != NULL)
{
name = NULL; ---> Add this line
delete [] name; --> this is causing the debug assertion failed..
}
}

int main()
{
char *name = NULL;  
name = getmestring(); 
cout<<name<<endl;

if(name != NULL)
delete [] name;

}

namaskaaram wrote:

assigning name =NULL and then deleting it will give u an error since u r trying to delete a block that points to the null address!!!!

char * getmestring()
{
char *str = new char[20];

// FROM <a href = "http://www.codeproject.com/script/comments/forums.asp?msg=1371347&forumid=1647#xx1371359xx" rel="nofollow">Stephen Hewitt</a>[<a href = "http://www.codeproject.com/script/comments/forums.asp?msg=1371347&forumid=1647#xx1371359xx" target = "_blank" rel="nofollow">^</a>]
// str = "myname";
strcpy(str, "myname"); 
return str;
}
int main()
{

// FROM <a href = "http://www.codeproject.com/script/comments/forums.asp?msg=1371347&forumid=1647#xx1371347xx" rel="nofollow">namaskaaram</a>[<a href = "http://www.codeproject.com/script/comments/forums.asp?msg=1371347&forumid=1647#xx1371347xx" target = "_blank" rel="nofollow">^</a>]
//char name = getmestring();
char *name = getmestring(); 
cout<<name<<endl;
if(name != NULL)
{
delete [] name; 
}
}

BadKarma wrote:

//char name = getmestring();char *name = getmestring();

namaskaaram wrote:

assigning name =NULL and then deleting it will give u an error since u r trying to delete a block that points to the null address!!!!
rather the code should be more like.....

namaskaaram wrote:

int main(){char *name = NULL; name = getmestring(); cout<<name<<endl;if(name !="NULL)delete" []="" name;}<="" blockquote="">

change it to

if(name != NULL)
delete [] name;
name=NULL

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow

cheers,
Alok Gupta
VC Forum Q&A :- I/ IV

"The greatest good you can do for another is not just to share your riches but to reveal to him his own." - Benjamin Disraeli

extern int nVar_Subbu;

int nVar_Subbu = 1;