Re: WPF DialogService Question - WPF Discussion Boards

Ron Beyer30-Dec-13 5:39

30-Dec-13 5:39

Although answered in the above post, I will say this:

To me, the word "service" screams static class. What use is a service if you have to create it and register all your views every time you are in a different scope? I would create the service class as a static item and register views on it, that way the registered views are available to the entire application without having to recreate the registry.

You would have to use some kind of initialization logic to set up the service (register all the available views) that should be called during the startup process of your program.

Kevin Marois30-Dec-13 6:56

30-Dec-13 6:56

I agree. Just wanted to get it running first. I'll convert it to a static class

If it's not broken, fix it until it is

Kevin Marois30-Dec-13 7:06

30-Dec-13 7:06

So, making it static, I now have:

DialogService<Window, _DialogBaseViewModel>.RegisterView(typeof(SQLConnectionView), typeof(SQLConnectionViewModel));

bool? dialogResult = DialogService<Window, _DialogBaseViewModel>.ShowDialog(new SQLConnectionViewModel());

I'm not sure I like having to specify the types each time I call ShowDialog

If it's not broken, fix it until it is

Ron Beyer30-Dec-13 7:22

30-Dec-13 7:22

Ok, here's how I would change it:

Implementation:

public static class DialogService
{
    private static Dictionary<Type, Type> registry = new Dictionary<Type, Type>();

    public static void RegisterView(Type dialogType, Type viewModelType)
    {
        //Rest of the implementation here
    }

    public static bool? ShowDialog<TViewModelType>(TViewModelType viewModel) where TViewModelType : DialogBaseViewModel
    {
        //Rest of the implementation here
    }
}

You don't seem to be using the TDialogType anywhere (you could replace it with "Window" in the RegisterView and ShowDialog methods and get exactly the same effect). There is no reason that I see that you need type parameters on the class itself where the type parameters on the method work fine (you only need them if you were using your dictionary as TDialogType,TViewModelType, which you aren't.

Kevin Marois30-Dec-13 7:22

30-Dec-13 7:22

LOL, I just did that very change!

Thanks

If it's not broken, fix it until it is

Kevin Marois30-Dec-13 7:35

30-Dec-13 7:35

Ok, so here's what I have now. Then a question..

Service

public static class DialogService
{
    private static Dictionary<Type, Type> registry = new Dictionary<Type, Type>();

    public static void RegisterDialog(Type dialogType, Type viewModelType)
    {
        if (!dialogType.IsSubclassOf(typeof(Window)))
        {
            throw new ArgumentException("The dialogType must be a subclass of type Window.");
        }

        bool exists = registry.Where(x => x.Key == dialogType).Any();

        if (!exists)
        {
            registry.Add(dialogType, viewModelType);
        }
    }

    public static bool? ShowDialog<TViewModelType>(TViewModelType viewModel) where TViewModelType : _DialogBaseViewModel
    {
        Type dialogType = registry.Where(x => x.Value == viewModel.GetType()).Select(x => x.Key).FirstOrDefault();
        var dialog = (Window)Activator.CreateInstance(dialogType);

        dialog.DataContext = viewModel;
        dialog.ShowDialog();
            
        bool? result = dialog.DialogResult;

        return result;
    }
}

Usage

DialogService.RegisterDialog(typeof(PersonView), typeof(PersonViewModel));
bool? dialogResult = DialogService.ShowDialog(new PersonViewModel());

The reason I'm forcing the VM to inherit from _DialogBaseViewModel is that _DialogBaseViewModel has a property called DialogResult. I have a DP that is set in a window's header XAML that sets the DialogResult from the VM and closes the window. Works real nice:

<Window x:Class="Osprey.UI.WPF.Views.MyDialog"
        xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        xmlns:i="http://schemas.microsoft.com/expression/2010/interactivity"
        xmlns:ei="http://schemas.microsoft.com/expression/2010/interactions"
        xmlns:behaviors="clr-namespace:Osprey.UI.WPF.Classes.Behaviors"
        Title="My Dialog" 
        xmlns:xc="clr-namespace:Osprey.UI.WPF.Classes"
        xc:DialogCloser.DialogResult="{Binding DialogResult}">

Problem
How would you return an object from this service?

Assume a dialog prompts the user to enter some data. That data could be stored to a model. I would want the service to return the model if DialogResult was true.

My first thought was to have a static wrapper class around this service that has methods for each type I would want to return. If null is returned then the dialog's DialogResult was false.

What do you think?

If it's not broken, fix it until it is

Ron Beyer30-Dec-13 7:46

30-Dec-13 7:46

I would add another class, something like:

public class DialogResultEx
{
    public bool? DialogResult { get; set; }
    public object DialogData { get; set; }
}

Then in your ShowDialog method:

public static DialogResultEx ShowDialog<TViewModelType>(TViewModelType viewModel) where TViewModelType : _DialogBaseViewModel
    {
        Type dialogType = registry.Where(x => x.Value == viewModel.GetType()).Select(x => x.Key).FirstOrDefault();
        var dialog = (Window)Activator.CreateInstance(dialogType);
 
        dialog.DataContext = viewModel;
        dialog.ShowDialog();
            
        DialogResultEx dlgResult = new DialogResult();
        dlgResult.DialogResult = dialog.DialogResult;
        dlgResult.DialogData = viewModel.WhateverData;    //Modify as needed
 
        return dlgResult;
    }

You could even make it implicitly castable to a bool...

public class DialogResultEx
{
    public bool? DialogResult { get; set; }
    public object DialogData { get; set; }

    public static implicit operator bool?(DialogResultEx dlgResult)
    {
        return dlgResult.DialogResult;
    }
}

So you wouldn't have to change much of your upstream code that didn't need the entire class.

Kevin Marois30-Dec-13 7:53

30-Dec-13 7:53

I like it. One question....

In the ShowDialog you have:

DialogResultEx dlgResult = new DialogResultEx();
dlgResult.DialogResult = dialog.DialogResult;
dlgResult.DialogData = viewModel.WhateverData;    //Modify as needed

How does this method know what object/value on the VM to get? How does 'viewModel.WhateverData' get set from with in this method?

If it's not broken, fix it until it is

Ron Beyer30-Dec-13 8:03

30-Dec-13 8:03

I figured that your model derives from a base type, you can have an object in the model to store any return value (or you could just store the entire view model if you want).

I don't know where you would store the return value in the view model, so I put a placeholder there. You didn't really specify where this would be stored, but I assume you have a field in the model that you can store return data in.

I would put a virtual field in the viewmodel base class (returns null by default) that the derived classes can override to return whatever.

For example:

public abstract class _DialogBaseViewModel
{
    public virtual object DialogData { get { return null; } }
}

Then a derived class could write:

public class InputDialogViewModel : _DialogBaseViewModel
{
    private string _textData = string.Empty;

    public override object DialogData
    {
        get
        {
            return _textData;
        }
    }
}

Kevin Marois30-Dec-13 8:08

30-Dec-13 8:08

OK, I see.. I like the design.

I just coded this:

Service
Same as before....

public static class DialogService
{
    private static Dictionary<Type, Type> registry = new Dictionary<Type, Type>();

    public static void RegisterDialog(Type dialogType, Type viewModelType)
    {
        if (!dialogType.IsSubclassOf(typeof(Window)))
        {
            throw new ArgumentException("The dialogType must be a subclass of type Window.");
        }

        bool exists = registry.Where(x => x.Key == dialogType).Any();

        if (!exists)
        {
            registry.Add(dialogType, viewModelType);
        }
    }

    public static bool? ShowDialog<TViewModelType>(TViewModelType viewModel) where TViewModelType : _DialogBaseViewModel
    {
        Type dialogType = registry.Where(x => x.Value == viewModel.GetType()).Select(x => x.Key).FirstOrDefault();
        var dialog = (Window)Activator.CreateInstance(dialogType);

        dialog.DataContext = viewModel;
        dialog.ShowDialog();

        return dialog.DialogResult.Value;
    }
}

DialogManager
A wrapper class to the Sertvice:

public static class DialogManager
{
    static DialogManager()
    {
        // Register all dialogs here
        DialogService.RegisterDialog(typeof(SQLConnectionView), typeof(SQLConnectionViewModel));
    }

    public static string OpenSQLConnectionDialog()
    {
        string result = string.Empty;

        SQLConnectionViewModel vm = new SQLConnectionViewModel();

        bool? dialogResult = DialogService.ShowDialog(vm);

        if (dialogResult.Value)
        {
            result = vm.ConnectionString;
        }

        return result;
    }
}

Usage

var connString = DialogManager.OpenSQLConnectionDialog();

By doing it with the wrapper, I can return a value, or the whole VM if I want.

Drawback is that I'd have to specified methods for each dialog I want to open, and possibly more if I wanted different return values;

If it's not broken, fix it until it is

Kevin Marois30-Dec-13 8:45

30-Dec-13 8:45

Ok, I set it up like you suggested. Very nice, and no need for a wrapper class.

Thank you Sir!

If it's not broken, fix it until it is

Ron Beyer30-Dec-13 8:54

30-Dec-13 8:54

Simplicity is a beautiful thing Smile | :)

Kevin Marois30-Dec-13 9:18

30-Dec-13 9:18

Yes it is.

One thing I forgot was the Owner window. So I added an overload.

public static DialogResultEx ShowDialog<TViewModelType>(TViewModelType viewModel) where TViewModelType : _DialogBaseViewModel
{
    Type dialogType = registry.Where(x => x.Value == viewModel.GetType()).Select(x => x.Key).FirstOrDefault();

    if (dialogType == null)
    {
        throw new ArgumentException(string.Format("There is no registered dialog corresponding to a view model of type {0}.", viewModel));
    }

    var dialog = (Window)Activator.CreateInstance(dialogType);

    dialog.DataContext = viewModel;
    dialog.ShowDialog();

    DialogResultEx dlgResult = new DialogResultEx();
    dlgResult.DialogResult = dialog.DialogResult;
    dlgResult.DialogData = viewModel.DialogData;

    return dlgResult;
}




public static DialogResultEx ShowDialog<TViewModelType, TOwnerType>(TViewModelType viewModel, Type ownerType) where TViewModelType : _DialogBaseViewModel
{
    Type dialogType = registry.Where(x => x.Value == viewModel.GetType()).Select(x => x.Key).FirstOrDefault();

    if (dialogType == null)
    {
        throw new ArgumentException(string.Format("There is no registered dialog corresponding to a view model of type {0}.", viewModel));
    }



    var dialog = (Window)Activator.CreateInstance(dialogType);

    dialog.DataContext = viewModel;

    if (ownerType != null)
    {
        Window ownerWindow = FindWindow(ownerType);
        dialog.Owner = ownerWindow;
    }

    dialog.ShowDialog();

    DialogResultEx dlgResult = new DialogResultEx();
    dlgResult.DialogResult = dialog.DialogResult;
    dlgResult.DialogData = viewModel.DialogData;

    return dlgResult;
}

Usage:

DialogResultEx dialogResult1 = DialogService.ShowDialog<SQLConnectionViewModel>(new SQLConnectionViewModel());

DialogResultEx dialogResult2 = DialogService.ShowDialog<SQLConnectionViewModel, MainWindowView>(new SQLConnectionViewModel(), typeof(MainWindowView));

Given the generics, how do I combine this into one method?

If it's not broken, fix it until it is

Ron Beyer30-Dec-13 10:25

30-Dec-13 10:25

I would overload it...

public static DialogResultEx ShowDialog<TViewModelType>(TViewModelType viewModel, Type ownerType) where TViewModelType : _DialogBaseViewModel
        {
            Type dialogType = registry.Where(x => x.Value == viewModel.GetType()).Select(x => x.Key).FirstOrDefault();
 
            if (dialogType == null)
            {
                throw new ArgumentException(string.Format("There is no registered dialog corresponding to a view model of type {0}.", viewModel));
            }
 

 
            var dialog = (Window)Activator.CreateInstance(dialogType);
 
            dialog.DataContext = viewModel;
 
            if (ownerType != null)
            {
                Window ownerWindow = FindWindow(ownerType);
                dialog.Owner = ownerWindow;
            }
            
            dialog.ShowDialog();
 
            DialogResultEx dlgResult = new DialogResultEx();
            dlgResult.DialogResult = dialog.DialogResult;
            dlgResult.DialogData = viewModel.DialogData;
 
            return dlgResult;
        }

public static DialogResultEx ShowDialog<TViewModelType>(TViewModelType viewModel) where TViewModelType : _DialogBaseViewModel
        {
            return ShowDialog<TViewModelType>(viewModel, null);
        }

Again, watch those generics and how you use them. You declare the generic TOwnerType but you don't ever use it, so there is no need for it. Using the above you can have both for when you need the owner window and for when you don't, and you have all the code re-use so you only have to maintain in one place.

Kevin Marois30-Dec-13 10:28

30-Dec-13 10:28

OK, I see.. I was trying to set the Owner type in the generic list. Couldn't make it work.

Many thanks!

If it's not broken, fix it until it is

Kevin Marois31-Dec-13 5:54

31-Dec-13 5:54

Thanks for all your help. I appreciate it. It's working great. I added a ShowMessageBox method.

So now that I have this done, I was thinking of writing an article. I know it's been done before, but what do you think?

If it's not broken, fix it until it is

Ron Beyer31-Dec-13 6:09

31-Dec-13 6:09

Go for it!

Convert BitmapImage into byte arrays in wpf

Mycroft Holmes6-Jan-14 21:57

Mycroft Holmes

6-Jan-14 21:57

Kevin Marois wrote:
I was thinking of writing an article

Excellent - it would save me at least 2 bookmarks and chasing through the thread. I have been looking for a simple dialog service and this seems to meet the requirements without delving too deep (I LIKE simple).

Never underestimate the power of human stupidity
RAH

Member 1001614027-Dec-13 0:23

Member 10016140

27-Dec-13 0:23

Hello,
I found this class in my research but I do not know how to use it. Moreover, it seems to me that the ConvertBack () method is not completely completed.If someone has already used his help will be invaluable for me.
here is the class

[ValueConversion(typeof(byte[]), typeof(ImageSource))]
   public class ByteArrayToImageSource : IValueConverter
   {
       #region Implementation of IValueConverter

       public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
       {
           var byteArrayImage = value as byte[];

           if (byteArrayImage != null && byteArrayImage.Length > 0)
           {
               var ms = new MemoryStream(byteArrayImage);

               var bitmapImg = new BitmapImage();

               bitmapImg.BeginInit();
               bitmapImg.StreamSource = ms;
               bitmapImg.EndInit();

               return bitmapImg;
           }

           return null;
       }

       public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
       {
           return null;
       }

       #endregion
   }

Re: Convert BitmapImage into byte arrays in wpf

Pete O'Hanlon27-Dec-13 0:58

Pete O'Hanlon

27-Dec-13 0:58

This is a converter - it's meant to be used in your XAML to convert from one type to another - in this case, to take a series of bytes and to return an image from it. If you're using this in XAML and you aren't updating the image on the screen, you don't need to worry about the ConvertBack method - it's there to support Binding back from the XAML to the property you're binding to.

Re: Convert BitmapImage into byte arrays in wpf

Member 1001614027-Dec-13 3:44

Member 10016140

27-Dec-13 3:44

a small code example or a case already studied help me please!

WPF App Content Presenter in Main Window

Kevin Marois23-Dec-13 7:21

Re: WPF App Content Presenter in Main Window

23-Dec-13 7:21

I am working on this[^] app.

The area in red is a ContentPresenter in the MainWindow. When the user clicks a link in the left Recent Items area, I send a message to the MainWindow to load the view.

That gives me this[^].

I am defining my Views/VM in my resource file:

<DataTemplate DataType="{x:Type vm:HomeViewModel}">
    <vw:HomeView/>
</DataTemplate>

<DataTemplate DataType="{x:Type vm:ClientViewModel}">
    <vw:ClientView/>
</DataTemplate>

The first question is this...How can the Save button on the MainWindow know that the current view is dirty?

Second, given how I'm designing this... view inside a view in a ContentPresenter, is messaging the right way to communicate?

I'm open to suggestion on my design.

Thanks

If it's not broken, fix it until it is

SledgeHammer0123-Dec-13 10:22

SledgeHammer01

23-Dec-13 10:22

I recently discovered CompositeCommand and find it works great for this scenario. It's part of Prism, but I just ripped it out since I don't use Prism.

https://prism.svn.codeplex.com/svn/V1/spikes/AGCompositeApplicationLibrary/AGComposite.Wpf/Commands/CompositeCommand.cs[^]

The toolbar will bind to a static CompositeCommand (i.e. in something like a GlobalCommands.cs) and then a view would attach to it with a RelayCommand. Something like:

GlobalCommands.SaveCommand.RegisterCommand(SaveCommand);

Multiple views can attach to the same command and all get notified when the button is clicked. The one gotcha though is the IActiveAware portion. Your ViewModelBase class needs to be tweaked to properly set the IsActive flags in the commands somehow.

Basically the way the CompositeCommand works is that say vmA and vmB attach... by default, the button will only enable if both return true for canExecute. By setting the IsActive flag on the commands properly, you can make it work in a way where the inactive commands are ignored. For example, if vmA.SaveCommand is not active, only vmB.SaveCommand will get the canexecute/execute calls.

Re: WPF App Content Presenter in Main Window

Kevin Marois3-Jan-14 10:29