C# Discussion Boards - CodeProject

Richard Deeming4-Mar-14 23:13

Richard Deeming

4-Mar-14 23:13

Start by fixing the SQL Injection vulnerability[^] in your code:

private void btnSave_Click(object sender, EventArgs e)
{
    try
    {
        sc.Open();
        
        using (SqlCommand cmd = new SqlCommand("INSERT INTO emails (id, emails, pbid) VALUES (@id, @emails, @pbid)"))
        {
            cmd.Parameters.AddWithValue("@id", txtId.Text);
            cmd.Parameters.AddWithValue("@emails", txtEm.Text);
            cmd.Parameters.AddWithValue("@pbid", txtPbid.Text);
            cmd.ExecuteNonQuery();
            
            MessageBox.Show("Update Successfull to the database");
        }
    }
    catch (Exception ex)
    {
        MessageBox.Show(ex.Message);
        System.Diagnostics.Debug.WriteLine(ex);
    }
    finally
    {
        sc.Close();
    }
}

If it still doesn't work, you'll need to post the error message. Look in the debug output in Visual Studio to get the full details.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Message Closed

6-Mar-14 3:15

FesAlex

6-Mar-14 3:15

Message Closed

Pete O'Hanlon6-Mar-14 3:32

Pete O'Hanlon

6-Mar-14 3:32

You do know that you need to reply to the original poster don't you? Richard doesn't need your help and the OP won't be informed that you have posted a reply because it's not against them.

thatraja6-Mar-14 3:59

thatraja

6-Mar-14 3:59

He's a spammer. The link from his signature & profile page

thatraja

Code converters | Education Needed
No thanks, I am all stocked up. - Luc Pattyn
When you're wrestling a gorilla, you don't stop when you're tired, you stop when the gorilla is - Henry Minute

bayaa6-Mar-14 16:09

6-Mar-14 16:09

My debug output information is:

XML

'WindowsFormsApplication1.vshost.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_32\mscorlib\v4.0_4.0.0.0__b77a5c561934e089\mscorlib.dll', Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
'WindowsFormsApplication1.vshost.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\assembly\GAC_MSIL\Microsoft.VisualStudio.HostingProcess.Utilities\10.0.0.0__b03f5f7f11d50a3a\Microsoft.VisualStudio.HostingProcess.Utilities.dll', Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
'WindowsFormsApplication1.vshost.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System.Windows.Forms\v4.0_4.0.0.0__b77a5c561934e089\System.Windows.Forms.dll', Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
'WindowsFormsApplication1.vshost.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System.Drawing\v4.0_4.0.0.0__b03f5f7f11d50a3a\System.Drawing.dll', Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
'WindowsFormsApplication1.vshost.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System\v4.0_4.0.0.0__b77a5c561934e089\System.dll', Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
'WindowsFormsApplication1.vshost.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\assembly\GAC_MSIL\Microsoft.VisualStudio.HostingProcess.Utilities.Sync\10.0.0.0__b03f5f7f11d50a3a\Microsoft.VisualStudio.HostingProcess.Utilities.Sync.dll', Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
'WindowsFormsApplication1.vshost.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\assembly\GAC_MSIL\Microsoft.VisualStudio.Debugger.Runtime\10.0.0.0__b03f5f7f11d50a3a\Microsoft.VisualStudio.Debugger.Runtime.dll', Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
'WindowsFormsApplication1.vshost.exe' (Managed (v4.0.30319)): Loaded 'C:\Users\bayaraa\Documents\Visual Studio 2010\Projects\WindowsFormsApplication1\WindowsFormsApplication1\bin\Debug\WindowsFormsApplication1.vshost.exe', Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
'WindowsFormsApplication1.vshost.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System.Core\v4.0_4.0.0.0__b77a5c561934e089\System.Core.dll', Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
'WindowsFormsApplication1.vshost.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System.Xml.Linq\v4.0_4.0.0.0__b77a5c561934e089\System.Xml.Linq.dll', Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
'WindowsFormsApplication1.vshost.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System.Data.DataSetExtensions\v4.0_4.0.0.0__b77a5c561934e089\System.Data.DataSetExtensions.dll', Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
'WindowsFormsApplication1.vshost.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_MSIL\Microsoft.CSharp\v4.0_4.0.0.0__b03f5f7f11d50a3a\Microsoft.CSharp.dll', Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
'WindowsFormsApplication1.vshost.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_32\System.Data\v4.0_4.0.0.0__b77a5c561934e089\System.Data.dll', Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
'WindowsFormsApplication1.vshost.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System.Deployment\v4.0_4.0.0.0__b03f5f7f11d50a3a\System.Deployment.dll', Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
'WindowsFormsApplication1.vshost.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System.Xml\v4.0_4.0.0.0__b77a5c561934e089\System.Xml.dll', Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
The thread 'vshost.NotifyLoad' (0xc44) has exited with code 0 (0x0).
The thread '<No Name>' (0x44c) has exited with code 0 (0x0).
The thread 'vshost.LoadReference' (0x63c) has exited with code 0 (0x0).
'WindowsFormsApplication1.vshost.exe' (Managed (v4.0.30319)): Loaded 'C:\Users\bayaraa\Documents\Visual Studio 2010\Projects\WindowsFormsApplication1\WindowsFormsApplication1\bin\Debug\WindowsFormsApplication1.exe', Symbols loaded.
'WindowsFormsApplication1.vshost.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System.Configuration\v4.0_4.0.0.0__b03f5f7f11d50a3a\System.Configuration.dll', Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
The thread '<No Name>' (0x1494) has exited with code 0 (0x0).
The thread 'vshost.RunParkingWindow' (0xc8c) has exited with code 0 (0x0).
The thread '<No Name>' (0x1644) has exited with code 0 (0x0).
The program '[4284] WindowsFormsApplication1.vshost.exe: Managed (v4.0.30319)' has exited with code 0 (0x0).

bayaa6-Mar-14 16:10

6-Mar-14 16:10

please help me

Member 104046945-Mar-14 21:18

Member 10404694

5-Mar-14 21:18

Hi,

What error message are you getting?

More information would help...

Tempo Allegro

Neva Bull

bayaa6-Mar-14 15:55

6-Mar-14 15:55

don't error. but don't saving to sql server. i don't understand

bayaa6-Mar-14 19:29

6-Mar-14 19:29

I'm mongolia. I'm a beginner of C#, so my English level is really poor.

bayaa6-Mar-14 19:52

6-Mar-14 19:52

Could someone help me with a video or picture description please?

Inheriting binding list

Gilbert Consellado4-Mar-14 21:52

4-Mar-14 21:52

Hello everyone,

I found that i can use bindinglist as datasource, now when i implement in a griedview datasource i came up with a problem that i cant track which item has been modified. so i make a little research and found about the INotifyPropertyChanged and will trigger if there is data that has been modified.

but what i need is a list of item that has been modified. not triggering an event for every property of the object that has been modified, and also found out that implementing INotifyPropertyChanged can cause some drawback in performance as i read in some blog.

so i came up inheriting bindinglist and add some features, without implementing NotifyPropertyChanged in the item class.

so this is my solution.

First the IEditableObject

namespace gcsc.Interface
{
    public interface IEditableObject
    {
        bool IsNew();

        void IsNew(bool status);

        bool IsDirty();

        void IsDirty(bool status);
    }
}

then the class that should be inherited by the item

namespace gcsc.UI
{
    public abstract class EditableObject : Interface.IEditableObject
    {
        private bool _isNew;
        private bool _isDirty;

        public bool IsNew()
        {
            return _isNew;
        }

        public void IsNew(bool status)
        {
            _isNew = status;
        }

        public bool IsDirty()
        {
            return _isDirty;
        }

        public void IsDirty(bool status)
        {
            _isDirty = status;
        }
    }
}

then that last is the GCSCBindingList<t> that will inherit the binding list

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Linq;
using GI = gcsc.Interface;

namespace gcsc.Util
{
    public sealed class GCSCBindingList<T> : BindingList<T>
    {
        private readonly List<T> _removeItems;
        private readonly bool _initValues;

        public IEnumerable<T> GetRemovedItems()
        {
            return _removeItems.AsEnumerable();
        }

        public IEnumerable<T> GetUpdatedItems()
        {
            foreach (GI.IEditableObject item in this)
            {
                if (item.IsDirty())
                    yield return (T)item;
            }
        }

        public IEnumerable<T> GetNewItems()
        {
            foreach (GI.IEditableObject item in this)
            {
                if (item.IsNew())
                    yield return (T)item;
            }
        }

        public GCSCBindingList()
        {
            if (!typeof(T).ImplementsInterface<GI.IEditableObject>())
                throw new ArrayTypeMismatchException("T must implement gcsc.Interface.IEditableObject");

            _removeItems = new List<T>();

            AllowEdit = true;
            AllowNew = true;
            AllowRemove = true;
        }

        public GCSCBindingList(IList<T> list)
        {
            if (!typeof(T).ImplementsInterface<GI.IEditableObject>())
                throw new ArrayTypeMismatchException("T must implement gcsc.Interface.IEditableObject");

            _removeItems = new List<T>();

            AllowEdit = true;
            AllowNew = true;
            AllowRemove = true;

            _initValues = true;

            foreach (var v in list)
                base.Add(v);

            _initValues = false;
        }

        protected override void InsertItem(int index, T item)
        {
            if (!_initValues)
                ((GI.IEditableObject)item).IsNew(true);
            base.InsertItem(index, item);
        }

        public new void Insert(int index, T item)
        {
            ((GI.IEditableObject)item).IsNew(true);
            base.Insert(index, item);
        }

        protected override void RemoveItem(int index)
        {
            if (index >= 0 && index < base.Count)
            {
                var item = base[index];
                _removeItems.Add(item);
                base.RemoveItem(index);
            }
        }
    }
}

XML

Now with the GCSCBindingList<T>

i can retrieve all deleted items and all the new items, but still i cant find a way to collect all edited items.

the IsDirty(bool status) method should set to true if the item has been modified, but i cant find the way to implement this.

Could you help me do this?

this is my sample usage, first the class

public class person : gcsc.UI.EditableObject
    {
        public person()
        {
        }

        public person(string lastname, string firstname)
        {
            LastName = lastname;
            FirstName = firstname;
        }

        public override string ToString()
        {
            return string.Format("{0}, {1} status new:{2}, dirty:{3}", LastName, FirstName, IsNew(), IsDirty());
        }

        public string FirstName { get; set; }

        public string LastName { get; set; }
    }

then can be used like this

List<person> p = new List<person>();
p.Add(new person("John", "smith"));
p.Add(new person("pual", "carl"));

GB = new gcsc.Util.GCSCBindingList<person>(p);

private void simpleButton1_Click(object sender, EventArgs e)
        {

            GB.RemoveAt(0);

            foreach (person p in GB.GetNewItems())
            {
                XtraMessageBox.Show(p.ToString());
            }

            foreach (person p in GB.GetRemovedItems())
            {
                XtraMessageBox.Show(p.ToString());
            }

            foreach (person p in GB.GetUpdatedItems())
            {
                MessageBox.Show(p.ToString());
            }
        }

now the GB.GetUpdatedItems() is empty because the IsDirty() is still return false even there is item edited.

Is there way enumerating all edited items?

Please help me solving this problem.

I Will appreciate for any help will come.

Thank you,

PS. sorry for my bad english

BobJanova5-Mar-14 0:56

BobJanova

5-Mar-14 0:56

Implementing INotifyPropertyChanged on your item class (e.g. Person) will cause a BindingList to fire ListChanged (subtype ItemChanged) events whenever your object fires a property notification event (usually in property setters). You can then hook up to that to store a list of what's been touched. It will also ensure that whatever you bind the list to in your UI will get updated when the items actually change.

Putting INotifyPropertyChanged on your domain objects is a bit ugly but I think it's the right way to go here.

Gilbert Consellado5-Mar-14 22:19

5-Mar-14 22:19

Thank you for the reply

BobJanova wrote:
Putting INotifyPropertyChanged on your domain objects is a bit ugly but I think it's the right way to go here.

yes your right.

That is the main purpose of GCSCBindingList<t>, creating object without implementing INotifyPropertyChanged.

I am still digging on the internet for solution.

Trying to figure out how to implement IBindingList instead of BindingList<t> as my last resort.

But if i cant figure it, there is nothing i can do but to implement INotifyPropertyChanged.

Gilbert Consellado5-Mar-14 22:42

5-Mar-14 22:42

I think INotifyPropertyChanged is not good to implement, there is some articles saying that, implementing INotifyPropertyChanged will cause performance issue.

modified 7-Mar-14 3:57am.

BobJanova6-Mar-14 6:10

BobJanova

6-Mar-14 6:10

Implementing INPC will cause your property getters to be called every time you notify the binding list that a property is changed. If you have expensive property getters (e.g. talking to an external data source), that could cause a problem – best practice is not to do that. If you're updating a lot of properties on the same item repeatedly, you'll want some kind of BeginUpdate/EndUpdate mechanism whereby you can turn off notifications while you make a lot of changes.

Gilbert Consellado6-Mar-14 22:05

6-Mar-14 22:05

BobJanova wrote:
Implementing INPC will cause your property getters to be called every time you notify the binding list that a property is changed. If you have expensive property getters (e.g. talking to an external data source), that could cause a problem – best practice is not to do that.

Yes that is what i want, to exclude INotifyPropertyChanged

BobJanova wrote:
If you're updating a lot of properties on the same item repeatedly, you'll want some kind of BeginUpdate/EndUpdate mechanism whereby you can turn off notifications while you make a lot of changes.

Could you give me some hint about that.
Please

Actually my plan is, when i initialize the bindingList it will get data from external source, then after that if one of the object property has been modified that object will be mark "Dirty" (its means it should be updated to the external data source). So while the bindinglist data has on the stage that some of its object is modifying, it will not reflected to the external source. then after that if i already finished modifying the bindinglist, that is the time that i should update the external data source.

My big problem here is, what object of the bindingList has been modified? "without implementing INPC".

So What i want is to enumerate all dirty objects, then after that it will update the external datasource.

Thanks.

Eddy Vluggen6-Mar-14 7:10

Eddy Vluggen

6-Mar-14 7:10

Gilbert Consellado wrote:
Is there way enumerating all edited items?

Depends on how you track what has been edited. From your base-class, I'd expect that flag to be set in the setter of the affected properties of all derived classes. It won't be set automatically.

INotifyPropertyChanged isn't "slow", but it'd be a bit overkill if you're using it merely to track which record has changed.

Alternatively, you can override Object.GetHashCode[^] and present a hash of the combined properties. That'd make comparing easy Smile | :)

Bastard Programmer from Hell Suspicious | :suss:

If you can't read my code, try converting it here[^]

Gilbert Consellado6-Mar-14 22:25

Is C# is fully object oriented or not?

6-Mar-14 22:25

Eddy Vluggen wrote:
Depends on how you track what has been edited. From your base-class, I'd expect that flag to be set in the setter of the affected properties of all derived classes. It won't be set automatically.

I am sorry, but how i should do that.

Eddy Vluggen wrote:
Alternatively, you can override Object.GetHashCode[^] and present a hash of the combined properties. That'd make comparing easy

I was thinking if i have huge amount of data, then comparing each of them, could that be potential for performance issue.

Member 102864334-Mar-14 21:48

Member 10286433

4-Mar-14 21:48

Tell me the answer for this one.

Peter Leow4-Mar-14 21:59

Peter Leow

4-Mar-14 21:59

Read this: is-c-sharp-a-100-object-oriented-programming-language[^]

BobJanova5-Mar-14 0:39

BobJanova

5-Mar-14 0:39

That's not really an answer as apparently SO can't agree!

Personally I'd say that it is almost 100% OO, everything in C# is an object, even primitive types ... except methods and classes, which can easily be manipulated into object types (Delegate and Type respectively), but which are not actually objects in and of themselves.

OriginalGriff4-Mar-14 22:14

OriginalGriff

4-Mar-14 22:14

Yes.

Those who fail to learn history are doomed to repeat it. --- George Santayana (December 16, 1863 – September 26, 1952)
Those who fail to clear history are doomed to explain it. --- OriginalGriff (February 24, 1959 – ∞)

BillWoodruff4-Mar-14 23:08

BillWoodruff

4-Mar-14 23:08

Well, I think that all depends on how you define what an OO Language is. If you met someone at Xerox Parc in the 1970's who programmed in SmallTalk, and showed them the C# Language specification, they might say C# is not a full OO Language because it doesn't support "true" multiple-inheritance, and it distinguishes value Types from reference Types. But, that same person would probably also say that Java, Ruby, and Python, are not OO Languages.

But, if you ask the question as: "Is C# an object-oriented language ?:" then, I would say: "yes," because you can't do squat in C# without creating and using objects; and, yes, because C# supports the key-features of object-oriented languages, including classes, and inheritance.

“The best hope is that one of these days the Ground will get disgusted enough just to walk away ~ leaving people with nothing more to stand ON than what they have so bloody well stood FOR up to now.” Kenneth Patchen, Poet

harold aptroot5-Mar-14 1:21

harold aptroot

5-Mar-14 1:21

What exactly do you mean by "fully object oriented"? That doesn't seem to be a well-defined term.