What the error in this code.

Question

0.00/5 (No votes)

See more:

cmd3.CommandText = "UPDATE Seats SET SeatStatus = 'Y' WHERE (FlightId =('" + flightf + "') AND SeatName =('" + DropDownList4.SelectedValue + "'))";

thanks for helping

the problem is

DropDownList4.SelectedValue

:

when i do it like this its work:

C#

string ss = "Y";
string sn =  "C07";
cmd3.CommandText = "UPDATE Seats SET SeatStatus = ('" + ss + "') WHERE FlightId =('" + flightf + "') AND SeatName =('" + sn + "')";

so the problem in the value

i try this:

string sn = Convert.ToString(DropDownList4.SelectedValue);

not worked

Posted 29-Aug-13 23:48pm

Aiham85

Updated 30-Aug-13 3:38am

v2

Add a Solution

Comments

Aiham85 30-Aug-13 5:53am

i change it like this:

cmd3.CommandText = "UPDATE Seats SET SeatStatus = 'Y' WHERE FlightId = ('" + flightf + "') AND SeatName = ('" + DropDownList4.SelectedValue + "')";

not working

Nelek 30-Aug-13 5:55am

Have you tried to compile it and / or to debug it?

[no name] 30-Aug-13 5:56am

Is FlightId really a string? Is flightf empty? Is there anything selected in DropDownList4? Is the selected value of DropDownList4 really a string? Is your connection string correct? Is your connection open? Did you execute your query? Are you getting the feeling that your "question" is way too vague yet? Did you debug your code?

Herman<T>.Instance 30-Aug-13 5:58am

that are indeed the only things to check!

phil.o 30-Aug-13 6:21am

I wish I could vote 5 to this one ;)

Simon_Whale 30-Aug-13 6:05am

Is there an error message? is it .NET or SQL?

Dholakiya Ankit 30-Aug-13 7:42am

solution2 is advice for you take it and if you still want to get result from this then put code that you are seeing while watch add cmd3.CommandText to watch then put whole code here this may easy to answer

4 solutions

Solution 3

C#

cmd3.CommandText = "UPDATE Seats SET SeatStatus = 'Y' WHERE FlightId ='" + flightf + "' AND SeatName ='" + DropDownList4.SelectedValue + "'";

Posted 30-Aug-13 0:51am

Abhishek Ginani

Updated 30-Aug-13 1:13am

v2

Comments

Herman<T>.Instance 30-Aug-13 7:15am

use String.Format like:
cmd3.CommandText = string.Format("UPDATE Seats SET SeatStatus = 'Y' WHERE FlightId ='{0}' AND SeatName ='{1}'", flightf, DropDownList4.SelectedValue ) ;
Makes it all more readable

Solution 4

I feel that the dropdownlist is not returning the value due to which you are getting the error. So, make it sure that you are getting some value against DropDownList4.SelectedValue; if you don't get some value you can try getting value by using DropDownList4.Text or DropDownList4.SelectedItem.

Posted 30-Aug-13 4:35am

SaqibRasheed

Solution 1

It maosi has no fault,please remove '+',and retry

Posted 29-Aug-13 23:51pm

zj493241838@sina.com

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

phil.o · Accepted Answer · 2013-08-29T23:53:00

Solution 2

The main error is you are constructing a SQL query by concatenating string input from user.
This is prone to SQL injection attacks.
Better use parameterized query.

Other error could be a problem with the selected value of your DropDownList (for example, it contains the character '). It's just a guess with the little information you are providing.

Posted 29-Aug-13 23:53pm

phil.o

Comments

Herman<T>.Instance 30-Aug-13 5:59am

pointing out preventing SQL injections is Always my 5!

phil.o 30-Aug-13 6:02am

Thanks :)