How do I display (an update) a progressbar while copying multiple files?

Question

0.00/5 (No votes)

See more:

This is a good example of the progressbar on it's own thread but where do I place my code that is actually performing the real work? Copying multiple files.

BackgroundWorker and ProgressBar demo[^]

What I have tried:

I put my code in the DoWork before the for loop but the progress bar does not update until my code finishes.

void backgroundWorker1_DoWork(object sender, DoWorkEventArgs e)
{
    // Your background task goes here

    string sourceDirectory = @"N:\0000\Current_Project";
    string targetDirectory = @"C:\0000\Current_Project";

    Cursor.Current = Cursors.WaitCursor;
    Copy(sourceDirectory, targetDirectory);
    Cursor.Current = Cursors.Default;

    for (int i = 0; i <= 100; i++)
    {
        // Report progress to 'UI' thread
        backgroundWorker1.ReportProgress(i);
        // Simulate long task
        System.Threading.Thread.Sleep(100);
    }
}

Posted 1-Sep-22 7:49am

Member 15754822

Updated 2-Sep-22 4:49am

v2

Add a Solution

Comments

Richard MacCutchan 1-Sep-22 14:08pm

You put the copying code in the background worker.

Member 15754822 2-Sep-22 8:13am

Could it be because I'm calling a method from the DoWork?
Copy(sourceDirectory, targetDirectory);

2 solutions

Solution 1

Your code goes in the DoWork event, and uses the sender parameter to identify the specific worker. You then use that to call the ReportProgress method to signal to the main (UI) thread that it should update the ProgressBar.

Posted 1-Sep-22 8:09am

OriginalGriff

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

JudyL_MD · Accepted Answer · 2022-09-02T04:49:00

Background_DoWork is running in the background but it is still a sequentially executing chunk of code like any other method. It's doing exactly what you told it to in the order you told it:
1) Copy directory
2) update progress

You need to update the progress bar as you're copying the contents of the directory. You didn't post the contents of your Copy method so I'm just guessing how to update it. Something like

string[] fileList = Directory.GetFiles (sourceDir);
for (int i = 0; i < fileList.Length; i++)
{
    // copy fileList[i] to targetDir

    // !!! here is where you update the progress bar, each time you finish copying one file
    backgroundWorker1.ReportProgress(i * 100 / fileList.Length);
}

(edit: fixed the for loop exit test (was <=))