Write a function to concatenate two strings and use this to concatenate n (i.e, say 2) strings. Note: DO NOT USE STRCAT() or ANY INBUILT FUNCTIONS

Question

1.00/5 (1 vote)

See more:

C

#include<stdio.h>
#include<string.h>


void stringConcatenate(char str1[], char str2[]){
    int i,j;
    i = strlen(str1);
    //for (int i = 0; str1[i] != '\0'; ++i){
        for (j = 0; str2[j] != '\0'; i++, j++) {
            str1[i] = str2[j];
        }
    str1[i] = '\0';
}


int main() {
    char s1[50], s2[30];
    int N,Z;
    gets(s1);
    gets(s2);
    scanf("%d", &N);

    stringConcatenate(s1,s2);
    printf("%s", s1);
    //printf("%d", )

    return 0;
}

What I have tried:

The code is working properly, but passes only one test case.
The test cases are -
Rick manord 1 ---> Rickmanord
Hello world 2 ---> Hellowworldworld
Gram piece 3 Grampiecepiecepiece
Anyone please help with why it isn't passing the other testcases

Posted 15-May-22 5:53am

Achyuth S.S.

Updated 15-May-22 6:24am

k5054

v2

Add a Solution

2 solutions

Solution 1

The reason it only passes the first test is that you haven't done anything with the numeric value, other than read it into a variable.
Look at the inputs, and then look at the output. It's pretty obvious what you should be doing with it.

But the arrays you allocate are probably going to cause you real problems: they are pretty small, and if the number gets larger, you will run out of space very quickly and overwrite the input. I'd suggest you look at malloc instead of fixed length arrays.

Posted 15-May-22 6:11am

OriginalGriff

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

k5054 · Accepted Answer · 2022-05-15T06:24:00

Are you sure you have the correct input parameters? What's the purpose of the number at the end of the line?

Assuming that the number should be to tell you how many strings to concatenate, I'd expect the number to come first e.g.

2 Rick Manood
3 Hello Rick Manood
11 By the pricking of my thumbs something wicked this way comes

Some thoughts:
1) 50 may be too short for some test cases, you're probably better off using dynamic memory, e.g. malloc()
2) The problem states that you need to concatenate n strings, not just 2, so you probably want to use a function something like

C

char *stringCatenate(size_t nargs, const char **strings)

So you'd pass in a counter of the number of strings, and an array of strings, getting back a dynamically allocated string of the strings concatenated together. If you're going to get a fail for using malloc() (a builtin function - at least for the purposes of this discussion), then you could use a large destination buffer, and then add that as a parameter to stringCatenate e.g.

C

char *stringCatenate(char *dest, size_t nargs, const char **strings)

Note that any fixed size array has the potential for overflow, leading to unexpected behavior (google "undefined behavior"), but 4K is likely to be enough.