How can I fix the path for counting files and directories?

Question

0.00/5 (No votes)

See more:

edit: original message deleted
Edit number 284 148
So I redid it, I don't know if it was correct.Now I'm having trouble fitting my results into form2.maybe it's all wrong and I didn't get the OriginalGriff article Transferring information between two forms, Part 1: Parent to Child[^]
Thank you so much for all your help and patience OriginalGriff
Now I have trouble transmitting information to Form2

What I have tried:

Form1:

using System;
using System.Drawing;
using System.IO;
using System.Linq;
using System.Windows.Forms;


namespace pocetadresaru
{
    public partial class Form1 : Form
    {
        private Form2 form2;
        

        public Form1()
        {
            InitializeComponent();
        }

        private void Form1_Shown(object sender, EventArgs e)
        {
            form2 = new Form2();
            form2.FormClosed += new FormClosedEventHandler(form2_FormClosed);
            form2.Location = new Point(Location.X, Location.Y + Height + 80);
            form2.Show();
            textBox1.Focus();
        }

        private void form2_FormClosed(object sender, FormClosedEventArgs e)
        {
            Close();
        }

        private void button1_Click_1(object sender, EventArgs e)

        {
            string folderPath= String.Empty;
            var folder = new FolderBrowserDialog();

            if (folder.ShowDialog() == DialogResult.OK)
            {
                folderPath = Path.GetFullPath(folder.SelectedPath);
                textBox1.Text = folderPath;
            }
        }

        public static int GetDirectoryCount(string folderPath)
        {
            return Directory.EnumerateDirectories(folderPath).Count();
            
          
        }

        public static int GetFileCount(string folderPath)
        {
          return Directory.EnumerateFiles(folderPath).Count();
            
             
        }


    }
}

Form2:

using System;
using System.Windows.Forms;

namespace pocetadresaru
{
    public partial class Form2 : Form
    {
        public string Data
        {
            get { return richTextBox1.Text; }
            set { richTextBox1.Text = "Adresář:" + GetDirectoryCount + Environment.NewLine + "Soubor:" + GetFileCount; }
        }
        public Form2()
        {
            InitializeComponent();

        }
    }
}

Posted 13-Oct-20 19:41pm

dejf111

Updated 14-Oct-20 19:00pm

v4

Add a Solution

Comments

Richard MacCutchan 14-Oct-20 7:13am

Get rid of Form2 and do everything on Form1. It will be less confusing.

1 solution

Add a Solution

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2020-10-13T20:02:00

Solution 1

You are doing it very wrong: your Form2 shouldn't know that Form1 even exists, but less what properties or fields it has.
As soon as I see the keywords public static it's obvious you are going wrong - you shouldn't need to be using static variables in code this simple, and you shouldn't make fields or controls public at all!

Start by reading this: Transferring information between two forms, Part 1: Parent to Child[^]
Form1 is your Parent, Form2 is your Child.
Then create the property in Form2 and set it when you create the instance. Now your forms are "decoupled" so only the Parent needs to know anything about the Child.

Then fix your null problem - and that's simple as well:

C#

FolderPath = Path.GetDirectoryName(folder.SelectedPath);

Path.GetDirectoryName expects a path to a file, not a folder - and it returns the folder that file is in. So when you pass it a folder instead of a file, it "strips out" the final folder name:
C:\docs\today becomes C:\docs
C:\docs becomes C:
C:\ becomes null
The SelectedPath property of the FolderBrowserDialog is already a folder, not a file - you don't need to get a folder name from that!

Posted 13-Oct-20 20:02pm

OriginalGriff

Comments

dejf111 14-Oct-20 2:09am

When I read the article, can I suggest here how I solve it?

OriginalGriff 14-Oct-20 2:16am

Help yourself!

dejf111 14-Oct-20 2:18am

in translation into my language it means two things and I don't know which one you mean

OriginalGriff 14-Oct-20 2:21am

And without any idea what you are saying, neither do I!

Go back to your original comment "When I read the article, can I suggest here how I solve it?" and write that again in your own language - use plenty of detail. Then use Google Translate to convert that to English and post teh translation here.

dejf111 14-Oct-20 2:35am

I hope I didn't upset you

OriginalGriff 14-Oct-20 2:51am

No, no - I'm sorry if I gave that impression.
Your comment "When I read the article, can I suggest here how I solve it?" In English comes over as "When I have read the article, am I allowed to post my solution here?" - hence my reply.
If that isn't what you meant, then please use Google translate to try and explain in better detail! :laugh:

dejf111 14-Oct-20 2:43am

your article is amazing maybe I'm starting to get it

OriginalGriff 14-Oct-20 2:52am

Oh good! :thumbsup:

dejf111 14-Oct-20 3:54am

I tried to rewrite it according to the article

OriginalGriff 14-Oct-20 4:21am

And? What happened?

dejf111 14-Oct-20 4:24am

two things don't work for me, one shifting form2 and the other close() didn´t close any of my window

OriginalGriff 14-Oct-20 4:38am

"one shifting form2"
"close() didn´t close any of my window"

These don't make any sense to me in isolation - .
Remember that we can't see your screen, access your HDD, or read your mind - we only get exactly what you type to work with. So if you write code that doesn't work, we can't tell what exactly you wrote unless you show it to us!

dejf111 14-Oct-20 4:43am

perhaps I can explain it more
private void form2_FormClosed(object sender, FormClosedEventArgs e)
{
Close();
}
writes error StackOverflowException and neither window closes

form2.Location = new Point( Location.X,Location.Y+Height+30);
I suppose it should move the second window under the main window, me just overlap

OriginalGriff 14-Oct-20 5:27am

"Writes stack overflow exception" - that shows you were just guessing what to do! :laugh:

What's happening is that you are handling a FormClosed event for Form2 in Form2, and closing the form in that. What that does is causes the system to call the FormClosing handler again, which closes the form, which calls the handler, which ... until the stack is full and the app crashes with a Stack Overflow exception.
Why do you think you need to close a form in the close handler for it?

Go back to the article and read it again - pay attention to what needs to be handled where!

dejf111 14-Oct-20 5:51am

okey I'm going to read it again :D

dejf111 14-Oct-20 6:14am

I read as much as I can and I still can't see the mistake

OriginalGriff 14-Oct-20 6:58am

What does you code look like at the moment?
What does the debugger show you is happening - you have used the debugger, haven't you?

dejf111 14-Oct-20 7:02am

with debugger I'm not a very good friend as well as with everything

OriginalGriff 14-Oct-20 7:23am

Get to know the debugger - it's the best tool you have, and you will spend more time with it that writing code!
It can save you days, even weeks of fault finding.

dejf111 14-Oct-20 7:39am

Is that better?

OriginalGriff 14-Oct-20 8:00am

Why are you doing this?

        public static int GetDirectoryCount()
        {
            var directoryCount = 0;
            var directoryIter = Directory.EnumerateDirectories(folderPath);
            foreach (var directory in directoryIter)
                directoryCount++;
            return directoryCount;
        }

When you could just do this:

        public static int GetDirectoryCount()
        {        
return Directory.EnumerateDirectories(folderPath).Count();
        }

dejf111 14-Oct-20 8:05am

I don't know why but I thought that cycles must be used

OriginalGriff 14-Oct-20 8:03am

And why are you using a static variable to transfer the path, use a parameter instead:

public static int GetDirectoryCount(string folderPath)
...

dejf111 15-Oct-20 3:15am

you may be happy for me but I finally got it working :) :D

OriginalGriff 15-Oct-20 3:29am

Yay! Well done! :thumbsup:

dejf111 15-Oct-20 4:01am

One more question, is it possible that it's miscalculating?

OriginalGriff 15-Oct-20 4:19am

:laugh:
How would I know? I have no access to your code or your system, so I can't tell from here!

What have you done to test it, and why do you think it's wrong?

dejf111 15-Oct-20 4:29am

I asked for the opinion of a more experienced man if he had encountered it :)
some directories it counts well, documents all well but I don't know how it's possible

OriginalGriff 15-Oct-20 5:13am

Without knowing what directories it does work for and which it doesn't, I can't help!
As a suggestion, try adding a log file to your code so it records each folder it tries, and how many it found - you can then check manually afterwards and verify the counts. Any discrepancies, and you can start looking at why they are different - but unless you have specific information you are just whistling in the dark ...

dejf111 15-Oct-20 5:26am

hmmm I'll try something

dejf111 16-Oct-20 3:50am

Purpose accomplished, for me great work.
Thank you so much!

OriginalGriff 16-Oct-20 4:29am

You're welcome!

dejf111 14-Oct-20 7:04am

this moment I'm thinking about how I'm going to attach the individual counting

dejf111 14-Oct-20 7:01am

In my defense, it wasn't my fault, I started a new project file and it already worked :D

BillWoodruff 14-Oct-20 2:21am

+5 between the two of us, he might get somewhere:

https://www.codeproject.com/Answers/5282505/How-to-load-text-in-richtext-box

How can I fix the path for counting files and directories?

1 solution

Solution 1

Add your solution here

Preview 0

How can I fix the path for counting files and directories?

1 solution

Solution 1

Add your solution here

Preview 0

Existing Members

...or Join us