C / C++ / MFC

CheckRadioButton makes recursive calls

7-Jul-04 3:33

CRichEditCtrl &ctrl = GetRichEditCtrl();
ctrl.SetWindowText(_T("This is my text!"));

"When I was born I was so surprised that I didn't talk for a year and a half." - Gracie Allen

elephantstar6-Jul-04 13:57

6-Jul-04 13:57

Hi there,

I have a group of three checkboxes. When I click on CheckBox2, a dialog box appears asking for user input. What it's suppose to do is when a user cancels a selection it should default to the first checkbox by making a call to CheckRadioButton. It does default but once the user clicks away from the application, the dialog box reappears as if the function to open up the dialog box is called once again. I isolated the problem and found that its the CheckRadioButton() that performs the recursive calls. How can I stop it from doing that? Thanks.

void CCheckBox::OnCheckBox2
{
CMyDialog dlg;

int nRet = -1;
nRet = dlg.DoModal();

// Handle the return value from DoModal
switch ( nRet )
{
case -1:
AfxMessageBox("Dialog box could not be created!");
break;
case IDOK:
{
..code...
break;
}
case IDABORT:
{
OnCheckBox1();
break;
}
case IDCANCEL:
{
OnCheckBox1();
break;
}
default:
break;
};
}

void CCheckBox::OnCheckBox1()
{
CheckRadioButton(IDC_RADIO1, IDC_RADIO3, IDC_RADIO1); //problem lies here
}

David Crow7-Jul-04 3:54

7-Jul-04 3:54

elephantstar wrote:
...when a user cancels a selection...

Cancels what selection?

elephantstar wrote:
...once the user clicks away from the application...

Closes the application, or puts focus on another application?

elephantstar wrote:
CheckRadioButton(IDC_RADIO1, IDC_RADIO3, IDC_RADIO1);

While I don't think it is related to the problem, are the values for IDC_RADIO1, IDC_RADIO2, and IDC_RADIO3 contiguous?

Why are you using CheckRadioButton() with checkboxes and not radio buttons?

"When I was born I was so surprised that I didn't talk for a year and a half." - Gracie Allen

elephantstar7-Jul-04 9:41

7-Jul-04 9:41

-When the user selects cancel (CASE IDCANCEL) in the popup dialog box, it would call OnCheckBox1() to check the first radio button. The first button is the default selection.

-Puts focus on another application.

-The radio button values are contiguous. The buttons are radio buttons not checkboxes. Sorry to confuse you with the names.

David Crow7-Jul-04 10:01

7-Jul-04 10:01

elephantstar wrote:
-When the user selects cancel (CASE IDCANCEL) in the popup dialog box, it would call OnCheckBox1() to check the first radio button. The first button is the default selection.

Blake's suggestion is definitely the cleanest. Assign each of the radio buttons a CButton member variable (e.g., m_btnRadio1, m_btnRadio2, m_btnRadio3). Something like:

void CCheckBox::OnCheckBox1( void )
{
    m_btnRadio2.SetCheck(BST_UNCHECKED);
    m_btnRadio3.SetCheck(BST_UNCHECKED);
}
 
void CCheckBox::OnCheckBox2( void )
{
    CMyDialog dlg;
    int nReturn;
 
    nReturn = dlg.DoModal();
    if (IDABORT == nReturn || IDCANCEL == nReturn)
        m_btnRadio1.SetCheck(BST_CHECKED);
    else
        m_btnRadio1.SetCheck(BST_UNCHECKED);
    
    m_btnRadio3.SetCheck(BST_UNCHECKED);
}
 
void CCheckBox::OnCheckBox3( void )
{
    m_btnRadio1.SetCheck(BST_UNCHECKED);
    m_btnRadio2.SetCheck(BST_UNCHECKED);
}

"When I was born I was so surprised that I didn't talk for a year and a half." - Gracie Allen

elephantstar7-Jul-04 11:55

7-Jul-04 11:55

I did as you suggested but there's a problem. The second radio button does not uncheck so I inserted m_btnRadio2.SetCheck(BST_UNCHECKED) when nReturn is either IDABORT or IDCANCEL. The recursion appears once again. Why is that? I grouped the buttons such that the first button has group property checked while the other two does not. What is going on?

Blake Miller7-Jul-04 5:11

Blake Miller

7-Jul-04 5:11

I would manually check or uncheck the OTHER radio or checkbox buttons in a handler for a particular button. You are getting recursed because the handler for button 1 is calling a function that will try to UNCHECK buttons 2 and three and CHECK button 1 AGAIN. As a result, your button 1 OnCheckBox1 is getting called from itself.
If you want these three items to be mutualy exclusive, you should try to use radio buttons, and not check boxes. If you group them properly and make them all automatic, you won't even need such a handler to 'set' them in your code. Windows will do it automatically.
If you insist on following your current path, you should do the following instead:

void CCheckBox::OnCheckBox1()
{
// button 1 will check or uncheck itself
// uncheck button 2
CButton* pButton = (CButton*)GetDlgItem(IDC_RADIO2);
pButton->SetCheck(0);
// uncheck button 3
pButton = (CButton*)GetDlgItem(IDC_RADIO3);
pButton->SetCheck(0);
}

void CCheckBox::OnCheckBox2()
{
// uncheck button 1
CButton* pButton = (CButton*)GetDlgItem(IDC_RADIO1);
pButton->SetCheck(0);
// button 2 will check or uncheck itself
// uncheck button 3
pButton = (CButton*)GetDlgItem(IDC_RADIO3);
pButton->SetCheck(0);
}

similarly for button 3.

elephantstar7-Jul-04 9:48

7-Jul-04 9:48

Sorry to confuse you. These buttons are radio buttons and they are contiguous and grouped properly. It's just giving me problems with the CheckRadioButton in OnCheckBox1().

Blake Miller7-Jul-04 11:38

Blake Miller

7-Jul-04 11:38

In that case, I would not bother with the call to 'set' the radio buttons in the radio button handler. They should be toggling on and off properly on their own.
Your call is just redundant - so redundant, it actually recurses on itself.

elephantstar7-Jul-04 12:40

7-Jul-04 12:40

So then what was wrong with my initial code? All I want to do is call CheckRadioButton to check the first button when the user cancels the dialog box selection in OnCheckBox2().

David Crow8-Jul-04 2:41

8-Jul-04 2:41

elephantstar wrote:
So then what was wrong with my initial code?

I'm not sure, but this code snippet works for me:

void CT9Dlg::DoDataExchange(CDataExchange* pDX)
{
	CDialog::DoDataExchange(pDX);
	//{{AFX_DATA_MAP(CT9Dlg)
	DDX_Control(pDX, IDC_RADIO1, m_btnRadio1);
	DDX_Control(pDX, IDC_RADIO2, m_btnRadio2);
	DDX_Control(pDX, IDC_RADIO3, m_btnRadio3);
	//}}AFX_DATA_MAP
}
 
BEGIN_MESSAGE_MAP(CT9Dlg, CDialog)
	//{{AFX_MSG_MAP(CT9Dlg)
	ON_BN_CLICKED(IDC_RADIO1, OnRadio1)
	ON_BN_CLICKED(IDC_RADIO2, OnRadio2)
	ON_BN_CLICKED(IDC_RADIO3, OnRadio3)
	//}}AFX_MSG_MAP
END_MESSAGE_MAP()
 
BOOL CT9Dlg::OnInitDialog()
{
    CDialog::OnInitDialog();
 
    m_btnRadio1.SetCheck(BST_CHECKED);	// default
 
    return TRUE;
}
 
void CT9Dlg::OnRadio1() 
{
}
 
void CT9Dlg::OnRadio2() 
{
    CMyDialog dlg;
 
    if (IDCANCEL == dlg.DoModal())
    {
        m_btnRadio1.SetCheck(BST_CHECKED);	
        m_btnRadio2.SetCheck(BST_UNCHECKED);	
    }
}
 
void CT9Dlg::OnRadio3() 
{	
}

"When I was born I was so surprised that I didn't talk for a year and a half." - Gracie Allen

elephantstar8-Jul-04 11:14

8-Jul-04 11:14

I have the exact same setup, but the button in its event handler function does not like to uncheck itself (ie. m_btnRadio2.SetCheck(BST_UNCHECKED);) This is what causes the recursion and it recursivelly calls OnRadio2() about four times. I tried to test this on OnRadio1() by doing the following:

void CT9Dlg:OnRadio1()
{
MessageBox("Hello");
m_btnRadio1.SetCheck(BST_UNCHECKED); //recursive calls
m_btnRadio2.SetCheck(BST_CHECKED);
m_btnRadio3.SetCheck(BST_UNCHECKED);
}

OnRadio1() is repeately called because of that line of code. I just don't understand it. Should the group properties for each radio button be checked or just the first in the group? This bug is really bugging me.....

David Crow9-Jul-04 4:50

Calling all people, I need your input.

9-Jul-04 4:50

elephantstar wrote:
Should the group properties for each radio button be checked or just the first in the group?

Yes. The three radio buttons must also be next to each other in the Z-order.

elephantstar wrote:
This bug is really bugging me

If you can package the project up fairly small and still be able to reproduce the problem, feel free to send it to me and I'll take a look.

"When I was born I was so surprised that I didn't talk for a year and a half." - Gracie Allen

mayanxn036-Jul-04 13:17

mayanxn03

6-Jul-04 13:17

My question is simple enough, I have project that I have been working on for probably 1 and a half years. It is written in C++ and is a fully fucntional RAM/memory searcher capable of searching for floats, ints, bytes , etc in RAM. I was curious as to WHERE I would have to go, to sell this project. By sell I meant give away the rights, and source code. I am looking for a site that allows one to sell their source codes/rights to it. If anyone knows any, please tell me.

Re: Calling all people, I need your input.

David Crow7-Jul-04 3:57

InsertMenuItem makes menu display with wrong width

7-Jul-04 3:57

www.download.com comes to mind, while www.tucows.com is another.

"When I was born I was so surprised that I didn't talk for a year and a half." - Gracie Allen

siggapet6-Jul-04 13:03

siggapet

6-Jul-04 13:03

Im loading a menu from a resource with LoadMenu and then i insert an extra item using InsertMenuItem, this item has a bitmap, which causes the menu to be extended on the left, adding room for the bitmap. However, now the little arrows on the right that indicates submenus are drawn over the texts. Ive tried making the new item longer than all preexisting items and then everything looks okay. So my guess is that somewhere the width of the menu is precomputed and it doesnt get updated correctly when the extra room for the bitmap is added.

The documentation tells me to call DrawMenuBar(HWND) after changing a menu, but my menu is for a contextmenu not a window.

What am i doing wrong?

Tray icon tooltip

ace//236-Jul-04 10:06

ace//23

6-Jul-04 10:06

Hi there!
I'm working on a little service creating an icon in the syste tray. I want it to provide information through tooltips. Now my problem is that neither the system tray icons nor their tooltips can (afaik) be handled like other controls.
Is there a way to modify a tooltip's text while it is displayed or to display one without moveing the mouse over it? If not is it possible to receive a tooltip's mouse-over messages or it's position for implementing my own tooltip-like control?

thx

EDIT: i would prefer plain win32 code to mfc...

Re: Tray icon tooltip

Ravi Bhavnani6-Jul-04 10:44

Ravi Bhavnani

6-Jul-04 10:44

Will this[^] article help?

/ravi

My new year's resolution: 2048 x 1536
Home | Articles | Freeware | Music
ravib@ravib.com

Re: Tray icon tooltip

ThatsAlok7-Jul-04 0:18

ThatsAlok

7-Jul-04 0:18

you can see my my article at following location it easy to understand here[^]

I Think It will Work
-----------------------------
Alok Gupta
visit me at http://www.thisisalok.tk

What's the best leak finder tool for VC 6?

CherezZaboro6-Jul-04 9:46

CherezZaboro

6-Jul-04 9:46

subject. Please!
Thanks a lot in advance.

Johan Rosengren6-Jul-04 10:44

Johan Rosengren

6-Jul-04 10:44

Rigid programming discipline.

If that is not enough, Boundschecker.

CherezZaboro6-Jul-04 11:40

CherezZaboro

6-Jul-04 11:40

You had to go out and type in that first remark, right? What if it's not my code? Cool | :cool:

"Boundschecker" - now I remember. D'Oh! | :doh:

Johan Rosengren6-Jul-04 21:05

Johan Rosengren

6-Jul-04 21:05

inner wrote:
You had to go out and type in that first remark, right? What if it's not my code?

Of course I had Smile | :)

There is an almost religious belief in leak finding tools, garbage collectors etc. With stricter discipline, leaks are much less of a problem.

And even if the code is not yours, a global search for all instances of new, replacement of dynamically allocated stuff with static variables etc. will increase code quality - something that a memory leak tool will not - you'll only fix leaks, not bad memory usage. An example:

void SomeFunction()
{
  CSomething* obj = new CSomething;
  // code
}

Boundschecker will find that you never deallocate obj. The chances are big that you replace the code with:

void SomeFunction()
{
  CSomething* obj = new CSomething;
  // code
  delete obj;
}

No leak. So far, so good. Now, the next maintaining developer copies part of the code to another function, so:

void SomeOtherFunction()
{
  CSomething* obj = new CSomething;
  // other code
}

New leak. If you instead corrected the code from the beginning to:

void SomeFunction()
{
  CSomething obj;
  // code
}

you'll have less lines of code to analyze for the next maintainer, easier to find the necessary but risky dynamic allocations, and no temptations for the copy and paste brigade = higher quality code!